Skip to contentSkip to conversation

don't export ext3_fs.h and jbd.h

PATCH In review Christoph Hellwig 3 participants 5 messages Mar 26, 2008 – Mar 27, 2008 VFS

lore
Share & tools
lore

Christoph Hellwig

author
#0 lore raw

PATCH 1/1 don't export ext3_fs.h and jbd.h

either of the headers actually compiles when included from userpsace nor should it be made available as userspace tools should be using the libraries or at least headers from e2fsprogs.

Signed-off-by Christoph Hellwig <[email protected]>
include/linux/Kbuild +0 -2
Index: linux-2.6/include/linux/Kbuild
===================================================================
@@ -195,7 +195,6 @@ unifdef-y += ethtool.h
 unifdef-y += eventpoll.h
 unifdef-y += signalfd.h
 unifdef-y += ext2_fs.h
-unifdef-y += ext3_fs.h
 unifdef-y += fb.h
 unifdef-y += fcntl.h
 unifdef-y += filter.h

@@ -248,7 +247,6 @@ unifdef-y += isdn.h
 unifdef-y += isdnif.h
 unifdef-y += isdn_divertif.h
 unifdef-y += isdn_ppp.h
-unifdef-y += jbd.h
 unifdef-y += joystick.h
 unifdef-y += kdev_t.h
 unifdef-y += kd.h
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Christoph Hellwig

either of the headers actually compiles when included from userpsace nor should it be made available as userspace tools should be using the libraries or at least headers from e2fsprogs.

I was planning on simply moving ext3_fs.h to fs/ext3, per your previously submitted patches.

I agree that removing jbd.h from the exported list makes sense.

Acked-by "Theodore Ts'o" <[email protected]>

- Ted

author
#2 lore raw
Quoted 9 lines · Theodore Tso
Quoted 3 lines · Christoph Hellwig

either of the headers actually compiles when included from userpsace nor should it be made available as userspace tools should be using the libraries or at least headers from e2fsprogs.

I was planning on simply moving ext3_fs.h to fs/ext3, per your previously submitted patches.

I agree that removing jbd.h from the exported list makes sense.

Let's get it out of the exported headers list for .25 so people can't accidentally include it anymore and do the big reshuffle for .26, ok?

#3 lore raw
Quoted 3 lines · Christoph Hellwig

Let's get it out of the exported headers list for .25 so people can't accidentally include it anymore and do the big reshuffle for .26, ok?

It's OK with me; I'm not sure the Great Penguin would consider it to be a bug fix, though. We can always ask...

- Ted

#4 lore raw
Quoted 8 lines · On Thu, 27 Mar 2008 06:01:04 -0400 Theodore Tso <[email protected]> wrote:
Quoted 3 lines · Christoph Hellwig

Let's get it out of the exported headers list for .25 so people can't accidentally include it anymore and do the big reshuffle for .26, ok?

It's OK with me; I'm not sure the Great Penguin would consider it to be a bug fix, though. We can always ask...

I queued it for 2.6.25.