Skip to contentSkip to conversation

lxfb: add power management functionality

PATCH In review Andres Salomon 2 participants 2 messages Mar 28, 2008 – Mar 31, 2008 Framebuffer layer

lore
Share & tools
lore

Andres Salomon

author
#0 lore raw

PATCH 5/7 lxfb: add power management functionality

This adds the ability to suspend/resume the lxfb driver, which includes:
- Register and palette saving code; registers are stored in lxfb_par. A few MSR values are saved as well.
- lx_powerup and lx_powerdown functions which restore/save registers and enable/disable graphic engines.
- lxfb_suspend/lxfb_resume

Originally based on a patch by Jordan Crouse.

Signed-off-by Andres Salomon <[email protected]>
---
 drivers/video/geode/lxfb.h      |   45 +++++++
 drivers/video/geode/lxfb_core.c |   46 +++++++
 drivers/video/geode/lxfb_ops.c  |  263 +++++++++++++++++++++++++++++++++++++--
 3 files changed, 345 insertions(+), 9 deletions(-)
drivers/video/geode/lxfb.h +45 -0
index b3fbc56..3b9416f 100644
@@ -3,6 +3,16 @@
 
 #include <linux/fb.h>
 
+#define GP_REG_COUNT	(0x7c / 4)
+#define DC_REG_COUNT	(0xf0 / 4)
+#define VP_REG_COUNT	(0x158 / 8)
+#define FP_REG_COUNT	(0x60 / 8)
+
+#define DC_PAL_COUNT	0x104
+#define DC_HFILT_COUNT	0x100
+#define DC_VFILT_COUNT	0x100
+#define VP_COEFF_SIZE	0x1000
+
 #define OUTPUT_CRT   0x01
 #define OUTPUT_PANEL 0x02
 

@@ -12,6 +22,27 @@ struct lxfb_par {
 	void __iomem *gp_regs;
 	void __iomem *dc_regs;
 	void __iomem *vp_regs;
+#ifdef CONFIG_PM
+	int powered_down;
+
+	/* register state, for power mgmt functionality */
+	struct {
+		uint64_t padsel;
+		uint64_t dotpll;
+		uint64_t dfglcfg;
+		uint64_t dcspare;
+	} msr;
+
+	uint32_t gp[GP_REG_COUNT];
+	uint32_t dc[DC_REG_COUNT];
+	uint64_t vp[VP_REG_COUNT];
+	uint64_t fp[FP_REG_COUNT];
+
+	uint32_t pal[DC_PAL_COUNT];
+	uint32_t hcoeff[DC_HFILT_COUNT * 2];
+	uint32_t vcoeff[DC_VFILT_COUNT];
+	uint32_t vp_coeff[VP_COEFF_SIZE / 4];
+#endif
 };
 
 static inline unsigned int lx_get_pitch(unsigned int xres, int bpp)

@@ -27,6 +58,11 @@ int lx_blank_display(struct fb_info *, int);
 void lx_set_palette_reg(struct fb_info *, unsigned int, unsigned int,
 			unsigned int, unsigned int);
 
+#ifdef CONFIG_PM
+int lx_powerdown(struct fb_info *info);
+int lx_powerup(struct fb_info *info);
+#endif
+
 
 /* Graphics Processor registers (table 6-29 from the data book) */
 enum gp_registers {

@@ -182,6 +218,9 @@ enum dc_registers {
 #define DC_DV_CTL_DV_LINE_SIZE_2K	(1 << 10)
 #define DC_DV_CTL_DV_LINE_SIZE_4K	(1 << 11)
 #define DC_DV_CTL_DV_LINE_SIZE_8K	((1 << 10) | (1 << 11))
+#define DC_DV_CTL_CLEAR_DV_RAM		(1 << 0)
+
+#define DC_IRQ_FILT_CTL_H_FILT_SEL	(1 << 10)
 
 #define DC_CLR_KEY_CLR_KEY_EN		(1 << 24)
 

@@ -267,6 +306,8 @@ enum vp_registers {
 	VP_A2YE,
 
 	VP_A3YE,	/* 0x150 */
+
+	VP_VCR = 0x1000, /* 0x1000 - 0x1fff */
 };
 
 #define VP_VCFG_VID_EN			(1 << 0)

@@ -319,6 +360,10 @@ enum fp_registers {
 #define FP_PT2_SCRC			(1 << 27)	/* shfclk free */
 
 #define FP_PM_P				(1 << 24)	/* panel power ctl */
+#define FP_PM_PANEL_PWR_UP		(1 << 3)	/* r/o */
+#define FP_PM_PANEL_PWR_DOWN		(1 << 2)	/* r/o */
+#define FP_PM_PANEL_OFF			(1 << 1)	/* r/o */
+#define FP_PM_PANEL_ON			(1 << 0)	/* r/o */
 
 #define FP_DFC_BC			((1 << 4) | (1 << 5) | (1 << 6))
drivers/video/geode/lxfb_core.c +46 -0

58 lines not on this page · raw message

drivers/video/geode/lxfb_ops.c +254 -9

278 lines not on this page · raw message

Signature · 8 lines
1.5.3.7


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
#1 lore raw

Hi!

drivers/video/geode/lxfb_core.c static struct fb_info * __init lxfb_init_fbinfo(struct device *dev) · line 437

Quoted 6 lines
drivers/video/geode/lxfb_core.c +6 -0
+static int lxfb_suspend(struct pci_dev *pdev, pm_message_t state)
+{
+	struct fb_info *info = pci_get_drvdata(pdev);
+
+	if (pdev->dev.power.power_state.event == state.event)
+		return 0;

This should never trigger. See Doc*/feature-removal-sch*.

drivers/video/geode/lxfb_core.c static struct fb_info * __init lxfb_init_fbinfo(struct device *dev) · line 449

Quoted 4 lines
drivers/video/geode/lxfb_core.c +4 -0
+	/* there's no point in setting PCI states; we emulate PCI, so
+	 * we don't end up getting power savings anyways */
+
+	pdev->dev.power.power_state = state;

And there's no point doing this.

drivers/video/geode/lxfb_core.c static struct fb_info * __init lxfb_init_fbinfo(struct device *dev) · line 468

Quoted 1 line
drivers/video/geode/lxfb_core.c +1 -0
+	pdev->dev.power.power_state = PMSG_ON;

Or this.

Signature · 8 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace