Skip to contentSkip to conversation

scsi: le*_add_cpu conversion

PATCH In review [email protected] 2 participants 2 messages Mar 28, 2008

Subsystems (4)
SCSI Aacraid SCSI RAID driver IBM ServeRAID RAID driver Ips SCSI RAID driver
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 5/17 scsi: le*_add_cpu conversion

From: Marcin Slusarz <[email protected]>

replace all:
little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) +

					expression_in_cpu_byteorder);
with:
	leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder);

generated with semantic patch

Signed-off-by Marcin Slusarz <[email protected]>
Cc [email protected]
Acked-by "Salyzyn, Mark" <[email protected]>
Signed-off-by Andrew Morton <[email protected]>

---

 drivers/scsi/aacraid/commsup.c |    2 +-
 drivers/scsi/ips.c             |    8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)
drivers/scsi/aacraid/commsup.c renamed from drivers/scsi/aacraid/commsup.c~scsi-le_add_cpu-conversion +1 -1
diff -puN drivers/scsi/aacraid/commsup.c~scsi-le_add_cpu-conversion drivers/scsi/aacraid/commsup.c
@@ -594,7 +594,7 @@ void aac_consumer_free(struct aac_dev * 
 	if (le32_to_cpu(*q->headers.consumer) >= q->entries)
 		*q->headers.consumer = cpu_to_le32(1);
 	else
-		*q->headers.consumer = cpu_to_le32(le32_to_cpu(*q->headers.consumer)+1);
+		le32_add_cpu(q->headers.consumer, 1);
 
 	if (wasfull) {
 		switch (qid) {
drivers/scsi/ips.c renamed from drivers/scsi/ips.c~scsi-le_add_cpu-conversion +2 -6
diff -puN drivers/scsi/ips.c~scsi-le_add_cpu-conversion drivers/scsi/ips.c
@@ -3664,9 +3664,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * 
 			scb->cmd.basic_io.sg_count = scb->sg_len;
 
 			if (scb->cmd.basic_io.lba)
-				scb->cmd.basic_io.lba =
-				    cpu_to_le32(le32_to_cpu
-						(scb->cmd.basic_io.lba) +
+				le32_add_cpu(&scb->cmd.basic_io.lba,
 						le16_to_cpu(scb->cmd.basic_io.
 							    sector_count));
 			else

@@ -3712,9 +3710,7 @@ ips_send_cmd(ips_ha_t * ha, ips_scb_t * 
 			scb->cmd.basic_io.sg_count = scb->sg_len;
 
 			if (scb->cmd.basic_io.lba)
-				scb->cmd.basic_io.lba =
-				    cpu_to_le32(le32_to_cpu
-						(scb->cmd.basic_io.lba) +
+				le32_add_cpu(&scb->cmd.basic_io.lba,
 						le16_to_cpu(scb->cmd.basic_io.
 							    sector_count));
 			else

_

#1 lore raw
Quoted 13 lines · [email protected] wrote:

From: Marcin Slusarz <[email protected]>

replace all:
little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) +

					expression_in_cpu_byteorder);
with:
	leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder);

generated with semantic patch

Signed-off-by Marcin Slusarz <[email protected]>
Cc [email protected]
Acked-by "Salyzyn, Mark" <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
Quoted 5 lines

---

 drivers/scsi/aacraid/commsup.c |    2 +-
 drivers/scsi/ips.c             |    8 ++------
 2 files changed, 3 insertions(+), 7 deletions(-)

Not commenting on the patch, but the API: it should be le32_add() not le32_add_cpu()

Jeff