Skip to contentSkip to conversation

rt2x00: Invert scheduled packet_filter check

PATCH New Ivo van Doorn 1 participant 1 message Mar 29, 2008 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rt2x00: Invert scheduled packet_filter check

Invert the check for scheduling the packet_filter configuration. When DRIVER_REQUIRE_SCHEDULED is not set we should immediately configure the the filter.

This fixes the 'infinite calls to rt2x00mc_configure_filter' bug reported by Bas Hulsken.

---
 drivers/net/wireless/rt2x00/rt2x00mac.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/rt2x00/rt2x00mac.c +2 -2
index 7063743..5131767 100644
@@ -423,9 +423,9 @@ void rt2x00mac_configure_filter(struct ieee80211_hw *hw,
 	rt2x00dev->packet_filter = *total_flags;
 
 	if (!test_bit(DRIVER_REQUIRE_SCHEDULED, &rt2x00dev->flags))
-		queue_work(rt2x00dev->hw->workqueue, &rt2x00dev->filter_work);
-	else
 		rt2x00dev->ops->lib->config_filter(rt2x00dev, *total_flags);
+	else
+		queue_work(rt2x00dev->hw->workqueue, &rt2x00dev->filter_work);
 }
 EXPORT_SYMBOL_GPL(rt2x00mac_configure_filter);
 
Signature · 1 line
1.5.4.4