Skip to contentSkip to conversation

disable CONFIG_ZERO_BOOTDELAY for lwmon5

PATCH New Sascha Laue 2 participants 4 messages Apr 3, 2008 – Apr 18, 2008

lore
Share & tools
lore

Sascha Laue

author
#0 lore raw

PATCH 1/1 disable CONFIG_ZERO_BOOTDELAY for lwmon5

Hi,

Subject: [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

Change configuartion for lwmon5 board.

Signed-off-by Sascha Laue <[email protected]>
---
 include/configs/lwmon5.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/configs/lwmon5.h +2 -0
index ced7ba6..ff4bc80 100644
@@ -434,7 +434,9 @@
 #define CONFIG_CMDLINE_EDITING	1	/* add command line history	*/
 #define CONFIG_LOOPW            1       /* enable loopw command         */
 #define CONFIG_MX_CYCLIC        1       /* enable mdc/mwc commands      */
+#if 0                               /* enable only for debug */
 #define CONFIG_ZERO_BOOTDELAY_CHECK	/* check for keypress on bootdelay==0 */
+#endif
 #define CONFIG_VERSION_VARIABLE 1	/* include version env variable */
 
 /*-----------------------------------------------------------------------
Signature · 1 line
1.5.2.4
#1 lore raw

PATCH 1/1 disable CONFIG_ZERO_BOOTDELAY for lwmon5

Quoted 16 lines · In message <[email protected]> you wrote:

Hi,

Subject: [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

Change configuartion for lwmon5 board.

Signed-off-by Sascha Laue <[email protected]>
---
 include/configs/lwmon5.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/configs/lwmon5.h +0 -0
index ced7ba6..ff4bc80 100644

include/configs/lwmon5.h line 440

Quoted 7 lines
include/configs/lwmon5.h +2 -0
@@ -434,7 +434,9 @@
 #define CONFIG_CMDLINE_EDITING	1	/* add command line history	*/
 #define CONFIG_LOOPW            1       /* enable loopw command         */
 #define CONFIG_MX_CYCLIC        1       /* enable mdc/mwc commands      */
+#if 0                               /* enable only for debug */
 #define CONFIG_ZERO_BOOTDELAY_CHECK	/* check for keypress on bootdelay==0 */
+#endif
 #define CONFIG_VERSION_VARIABLE 1	/* include version env variable */

Please don't add dead code. If you want to remove that line, then please remove it. No "#if 0", please.

Viele Gr??e,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something done:
        (1) Do it yourself.
        (2) Hire someone to do it for you.
        (3) Forbid your kids to do it.
author
#2 lore raw

PATCH 1/1 disable CONFIG_ZERO_BOOTDELAY for lwmon5

Subject: [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5 Change configuartion for lwmon5 board.

Signed-off-by Sascha Laue <[email protected]>
---
 include/configs/lwmon5.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
include/configs/lwmon5.h +0 -1
index ced7ba6..cb2c4b5 100644
@@ -434,7 +434,6 @@
 #define CONFIG_CMDLINE_EDITING	1	/* add command line history	*/
 #define CONFIG_LOOPW            1       /* enable loopw command         */
 #define CONFIG_MX_CYCLIC        1       /* enable mdc/mwc commands      */
-#define CONFIG_ZERO_BOOTDELAY_CHECK	/* check for keypress on bootdelay==0 */
 #define CONFIG_VERSION_VARIABLE 1	/* include version env variable */
 
 /*-----------------------------------------------------------------------
Signature · 3 lines
1.5.2.4

-------- Original-Nachricht --------
Quoted 49 lines

Datum: Thu, 03 Apr 2008 11:38:20 +0200
Von: Wolfgang Denk <[email protected]>
An: "Sascha Laue" <[email protected]>
CC: u-boot-users at lists.sourceforge.net
Betreff: Re: [U-Boot-Users] [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

Quoted 16 lines · In message <[email protected]> you wrote:

Hi,

Subject: [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5

Change configuartion for lwmon5 board.

Signed-off-by Sascha Laue <[email protected]>
---
 include/configs/lwmon5.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/configs/lwmon5.h +0 -0
index ced7ba6..ff4bc80 100644

include/configs/lwmon5.h line 435

Quoted 2 lines
include/configs/lwmon5.h +0 -0
@@ -434,7 +434,9 @@
 #define CONFIG_CMDLINE_EDITING	1	/* add command line history	*/
 #define CONFIG_LOOPW            1       /* enable loopw command

*/

include/configs/lwmon5.h line 436

Quoted 1 line
include/configs/lwmon5.h +0 -0
 #define CONFIG_MX_CYCLIC        1       /* enable mdc/mwc commands

*/

include/configs/lwmon5.h line 438

Quoted 2 lines
include/configs/lwmon5.h +1 -0
+#if 0                               /* enable only for debug */
 #define CONFIG_ZERO_BOOTDELAY_CHECK	/* check for keypress on

bootdelay==0 */

include/configs/lwmon5.h line 440

Quoted 2 lines
include/configs/lwmon5.h +1 -0
+#endif
 #define CONFIG_VERSION_VARIABLE 1	/* include version env variable */

Please don't add dead code. If you want to remove that line, then please remove it. No "#if 0", please.

Viele Gr??e,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something done:
        (1) Do it yourself.
        (2) Hire someone to do it for you.
        (3) Forbid your kids to do it.
Applied
#3 lore raw

PATCH 1/1 disable CONFIG_ZERO_BOOTDELAY for lwmon5

Quoted 7 lines · In message <[email protected]> you wrote:

Subject: [PATCH] disable CONFIG_ZERO_BOOTDELAY for lwmon5 Change configuartion for lwmon5 board.

Signed-off-by Sascha Laue <[email protected]>
---
 include/configs/lwmon5.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
God made the integers; all else is the work of Man.       - Kronecker