Skip to contentSkip to conversation

xfsqa - 008 is unreliable on 64k page size

PATCH In review David Chinner 2 participants 4 messages Apr 8, 2008 – Apr 28, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfsqa - 008 is unreliable on 64k page size

Test 008 is unreliable on 64k page size. The I/O size is large enough that the probability of extent merging results in intermittent failures due to fewer extents that the +/- 10% tolerance allows.

Fix by making the files larger.

---
 xfstests/008     |   10 +++++-----
 xfstests/008.out |   10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)
xfstests/008 +5 -5
Index: xfs-cmds/xfstests/008
===================================================================
@@ -79,13 +79,13 @@ _setup_testdir
 
 rm -f $here/$seq.out.full
 
-_do_test 1 50 "-l 5000000 -c 50 -b $pgsize"
-_do_test 2 100 "-l 10000000 -c 100 -b $pgsize"
-_do_test 3 100 "-l 10000000 -c 100 -b 512"   # test partial pages
+_do_test 1 50 "-l 50000000 -c 50 -b $pgsize"
+_do_test 2 100 "-l 100000000 -c 100 -b $pgsize"
+_do_test 3 100 "-l 100000000 -c 100 -b 512"   # test partial pages
 
 # rinse, lather, repeat for direct IO
-_do_test 4 50 "-d -l 5000000 -c 50 -b $pgsize"
-_do_test 5 100 "-d -l 10000000 -c 100 -b $pgsize"
+_do_test 4 50 "-d -l 50000000 -c 50 -b $pgsize"
+_do_test 5 100 "-d -l 100000000 -c 100 -b $pgsize"
 # note: direct IO requires page aligned IO
 
 # todo: realtime.
xfstests/008.out +5 -5
Index: xfs-cmds/xfstests/008.out
===================================================================
@@ -1,21 +1,21 @@
 QA output created by 008
 
-randholes.1 : -l 5000000 -c 50 -b PGSIZE
+randholes.1 : -l 50000000 -c 50 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.2 : -l 10000000 -c 100 -b PGSIZE
+randholes.2 : -l 100000000 -c 100 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.3 : -l 10000000 -c 100 -b 512
+randholes.3 : -l 100000000 -c 100 -b 512
 ------------------------------------------
 holes is in range
 
-randholes.4 : -d -l 5000000 -c 50 -b PGSIZE
+randholes.4 : -d -l 50000000 -c 50 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.5 : -d -l 10000000 -c 100 -b PGSIZE
+randholes.5 : -d -l 100000000 -c 100 -b PGSIZE
 ------------------------------------------
 holes is in range
#1 lore raw

Ping?

Quoted 66 lines · David Chinner

Test 008 is unreliable on 64k page size. The I/O size is large enough that the probability of extent merging results in intermittent failures due to fewer extents that the +/- 10% tolerance allows.

Fix by making the files larger.

---
 xfstests/008     |   10 +++++-----
 xfstests/008.out |   10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

Index: xfs-cmds/xfstests/008
===================================================================

xfstests/008 +5 -5
@@ -79,13 +79,13 @@ _setup_testdir
 
 rm -f $here/$seq.out.full
 
-_do_test 1 50 "-l 5000000 -c 50 -b $pgsize"
-_do_test 2 100 "-l 10000000 -c 100 -b $pgsize"
-_do_test 3 100 "-l 10000000 -c 100 -b 512"   # test partial pages
+_do_test 1 50 "-l 50000000 -c 50 -b $pgsize"
+_do_test 2 100 "-l 100000000 -c 100 -b $pgsize"
+_do_test 3 100 "-l 100000000 -c 100 -b 512"   # test partial pages
 
 # rinse, lather, repeat for direct IO
-_do_test 4 50 "-d -l 5000000 -c 50 -b $pgsize"
-_do_test 5 100 "-d -l 10000000 -c 100 -b $pgsize"
+_do_test 4 50 "-d -l 50000000 -c 50 -b $pgsize"
+_do_test 5 100 "-d -l 100000000 -c 100 -b $pgsize"
 # note: direct IO requires page aligned IO
 
 # todo: realtime.

Index: xfs-cmds/xfstests/008.out
===================================================================

xfstests/008.out +5 -5
@@ -1,21 +1,21 @@
 QA output created by 008
 
-randholes.1 : -l 5000000 -c 50 -b PGSIZE
+randholes.1 : -l 50000000 -c 50 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.2 : -l 10000000 -c 100 -b PGSIZE
+randholes.2 : -l 100000000 -c 100 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.3 : -l 10000000 -c 100 -b 512
+randholes.3 : -l 100000000 -c 100 -b 512
 ------------------------------------------
 holes is in range
 
-randholes.4 : -d -l 5000000 -c 50 -b PGSIZE
+randholes.4 : -d -l 50000000 -c 50 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.5 : -d -l 10000000 -c 100 -b PGSIZE
+randholes.5 : -d -l 100000000 -c 100 -b PGSIZE
 ------------------------------------------
 holes is in range
Signature · 3 lines
Dave Chinner
Principal Engineer
SGI Australian Software Group
#2 lore raw

ping again?

Quoted 74 lines · David Chinner

Ping?

Quoted 66 lines · David Chinner

Test 008 is unreliable on 64k page size. The I/O size is large enough that the probability of extent merging results in intermittent failures due to fewer extents that the +/- 10% tolerance allows.

Fix by making the files larger.

---
 xfstests/008     |   10 +++++-----
 xfstests/008.out |   10 +++++-----
 2 files changed, 10 insertions(+), 10 deletions(-)

Index: xfs-cmds/xfstests/008
===================================================================

xfstests/008 +5 -5
@@ -79,13 +79,13 @@ _setup_testdir
 
 rm -f $here/$seq.out.full
 
-_do_test 1 50 "-l 5000000 -c 50 -b $pgsize"
-_do_test 2 100 "-l 10000000 -c 100 -b $pgsize"
-_do_test 3 100 "-l 10000000 -c 100 -b 512"   # test partial pages
+_do_test 1 50 "-l 50000000 -c 50 -b $pgsize"
+_do_test 2 100 "-l 100000000 -c 100 -b $pgsize"
+_do_test 3 100 "-l 100000000 -c 100 -b 512"   # test partial pages
 
 # rinse, lather, repeat for direct IO
-_do_test 4 50 "-d -l 5000000 -c 50 -b $pgsize"
-_do_test 5 100 "-d -l 10000000 -c 100 -b $pgsize"
+_do_test 4 50 "-d -l 50000000 -c 50 -b $pgsize"
+_do_test 5 100 "-d -l 100000000 -c 100 -b $pgsize"
 # note: direct IO requires page aligned IO
 
 # todo: realtime.

Index: xfs-cmds/xfstests/008.out
===================================================================

xfstests/008.out +5 -5
@@ -1,21 +1,21 @@
 QA output created by 008
 
-randholes.1 : -l 5000000 -c 50 -b PGSIZE
+randholes.1 : -l 50000000 -c 50 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.2 : -l 10000000 -c 100 -b PGSIZE
+randholes.2 : -l 100000000 -c 100 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.3 : -l 10000000 -c 100 -b 512
+randholes.3 : -l 100000000 -c 100 -b 512
 ------------------------------------------
 holes is in range
 
-randholes.4 : -d -l 5000000 -c 50 -b PGSIZE
+randholes.4 : -d -l 50000000 -c 50 -b PGSIZE
 ------------------------------------------
 holes is in range
 
-randholes.5 : -d -l 10000000 -c 100 -b PGSIZE
+randholes.5 : -d -l 100000000 -c 100 -b PGSIZE
 ------------------------------------------
 holes is in range
Signature · 3 lines
Dave Chinner
Principal Engineer
SGI Australian Software Group
Signature · 3 lines
Dave Chinner
Principal Engineer
SGI Australian Software Group
#3 lore raw
In reply to David Chinner
Quoted 3 lines · David Chinner

Test 008 is unreliable on 64k page size. The I/O size is large enough that the probability of extent merging results in intermittent failures due to fewer extents that the +/- 10% tolerance allows.

Looks good.