Skip to contentSkip to conversation

mpparse merge

DISCUSSION Ingo Molnar 2 participants 2 messages Apr 10, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

(Cc:-ing lkml because obviously others are interested in this topic too)

Quoted 6 lines · Andi Kleen

Refering to

commit 9d92083afb7cabe86c166dce9cc569eabbbd6f99

Author: Alexey Starikovskiy <[email protected]>
Date:   Fri Apr 4 23:43:18 2008 +0400
Quoted 8 lines
    x86: merge mpparse_{32,64}.c

in linux-next.

About half of the ifdefs seem to be because 32bit does irq compression and 64bit does not. Len removed that at some point, but when the files are merged I would rather just readd 64bit irq compression (or move 64bit over to per cpu vectors) than have this ifdef jungle

the way Alexey did it is the safest way of doing unifications: keep it simple and finegrained first, keep the more complex steps to later. We try to stick to that even if there's a temporary jungle of #ifdefs. In a related discussion (which was unfortunately private too so no URLs) you suggested to Alexey to redesign the mp-parsing code first, then unify it. That's the worst possible approach to unification and i advise everyone against doing it that way. I very much agree with unifying irq vector management - it's not a simple task at all.

Ingo

#2 lore raw
Quoted 2 lines

the way Alexey did it is the safest way of doing unifications: keep it simple and finegrained first, keep the more complex steps to later. We

If he unifies dumbly like you seem to be fond of doing CONFIG_X86_32 when it should be CONFIG_FUNCTIONALITY is the wrong way. Can we agree on that? The ifdef jungle is not any less from that, but at least it is clear what the code does which makes further changes much easier. Basically it preserves more information.

Quoted 4 lines

try to stick to that even if there's a temporary jungle of #ifdefs. In a related discussion (which was unfortunately private too so no URLs) you suggested to Alexey to redesign the mp-parsing code first, then unify it. That's the worst possible approach to unification and i advise

The best approach depends on the code, not on a static rule of thumb. It can be either depending on the code and the circumstances or often a mix of both.

A good example where the static rule of thumb went totally wrong is Glauber's recent smpboot unification without fixing the state machine first. I'm still not sure he has all the races out caused by that yet and I predict you'll have some debugging fun with that in the .26 cycle.

-Andi