Skip to contentSkip to conversation

bttv: Fix memory leak in radio_release

PATCH New Robert Fitzsimons 1 participant 1 message Apr 10, 2008 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bttv: Fix memory leak in radio_release

Fix the leak of the bttv_fh structure allocated in radio_open which was introduced by commit 5cd3955cb8adfc1edf481e9e1cb2289db50ccacb.

---
 drivers/media/video/bt8xx/bttv-driver.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Seeing as commit 'V4L/DVB (7277): bttv: Re-enabling radio support requires the use of struct bttv_fh' made it into mainline I better fix the memory leak I introduced.

Robert

drivers/media/video/bt8xx/bttv-driver.c +3 -0
index fcf8f2d..59a8847 100644
@@ -3457,6 +3457,9 @@ static int radio_release(struct inode *inode, struct file *file)
 	struct bttv *btv = fh->btv;
 	struct rds_command cmd;
 
+	file->private_data = NULL;
+	kfree(fh);
+
 	btv->radio_user--;
 
 	bttv_call_i2c_clients(btv, RDS_CMD_CLOSE, &cmd);
Signature · 6 lines
1.5.4.3.484.g60e3

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list