proper prototypes for mmc_attach_*()
PATCH 1/1 proper prototypes for mmc_attach_*()
This patch adds proper prototypes for mmc_attach_*() in drivers/mmc/core/core.h
---
drivers/mmc/core/core.c | 4 ---- drivers/mmc/core/core.h | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-)
bb340d80c76a77876462f62612a0795ca21f2362 diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c index ab91b02..01ced4c 100644
drivers/mmc/core/core.c +0 -4
@@ -35,10 +35,6 @@#include "sd_ops.h" #include "sdio_ops.h" -extern int mmc_attach_mmc (struct mmc_host *host,u32 ocr); -extern int mmc_attach_sd (struct mmc_host *host,u32 ocr); -extern int mmc_attach_sdio (struct mmc_host *host,u32 ocr); -static struct workqueue_struct *workqueue;/*
drivers/mmc/core/core.h +4 -0
@@ -46,6 +46,10 @@ void mmc_rescan(struct work_struct *work);void mmc_start_host (struct mmc_host *host);void mmc_stop_host (struct mmc_host *host); +int mmc_attach_mmc (struct mmc_host *host,u32 ocr); +int mmc_attach_sd (struct mmc_host *host,u32 ocr); +int mmc_attach_sdio (struct mmc_host *host,u32 ocr); +extern int use_spi_crc;#endif
Quoted 5 lines · On Sun, 13 Apr 2008 21:15:50 +0300 Adrian Bunk <[email protected]> wrote:
This patch adds proper prototypes for mmc_attach_*() in
drivers/mmc/core/core.hSigned-off-by Adrian Bunk <[email protected]>
I'm not entirely convinced about these, but seems they seem to bother you... ;)
Signature · 5 lines
-- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org PulseAudio, core developer http://pulseaudio.org rdesktop, core developer http://www.rdesktop.org
Quoted 11 lines · Pierre Ossman
Quoted 5 lines · On Sun, 13 Apr 2008 21:15:50 +0300 Adrian Bunk <[email protected]> wrote:
This patch adds proper prototypes for mmc_attach_*() in
drivers/mmc/core/core.hSigned-off-by Adrian Bunk <[email protected]>I'm not entirely convinced about these, but seems they seem to bother you... ;)
With proper prototypes in a header gcc can check that caller and callee agree about the function signature.
Otherwise someone might accidentally change only one of them.
That's a rare issue, but when it happens it's a nasty runtime error.
Quoted 1 line
-- Pierre Ossman
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed