Skip to contentSkip to conversation

UIO: Implement a UIO interface for the SMX Cryptengine

DISCUSSION Ben Nizette 2 participants 2 messages Apr 14, 2008 – Apr 22, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

[putting lkml back in CC]

Quoted 2 lines · Uwe Kleine-König

The line "depends on UIO" isn't needed (anymore) because the whole config item is located in a "if UIO"/"endif".

Right, just saw your patch fly by. Given mine's been taken up by gregkh already I was kinda hoping someone further up the tree would end up fixing it. If not I can of course rebase and resend.

Quoted 2 lines

The "default n" isn't necessary because that's the default anyhow.

Eh, I like to be explicit.

Quoted 2 lines

I didn't look deeper into that patch, but it might be possible to

share

Quoted 1 line

code with my patch

Indeed, I quite like your patch. I spend a fair bit of time on the AVRFreaks AVR32 support community and I can see a great need for what you've done. That said, if HJK/ GregKH don't object I think I'll leave mine pretty much as-is; having a device-specific ISR in platform code just doesn't quite sit smooth with me :-)

Thanks!

	--Ben.
#2 lore raw

Hello,

Quoted 11 lines · Ben Nizette

[putting lkml back in CC]

Quoted 2 lines · Uwe Kleine-König

The line "depends on UIO" isn't needed (anymore) because the whole config item is located in a "if UIO"/"endif".

Right, just saw your patch fly by. Given mine's been taken up by gregkh already I was kinda hoping someone further up the tree would end up fixing it. If not I can of course rebase and resend.

Your patch is in Linus' tree in the meantime and mine is not (yet). I suggest to prepare a patch such that both drivers share some code after my driver has hit mainline.

Quoted 3 lines
Quoted 1 line

The "default n" isn't necessary because that's the default anyhow.

Eh, I like to be explicit.

I expect this to be cleaned up later by someone à la:

	git log -E --grep='([Rr]emove|useless|unnecessary).*default n\>'

:-)

Best regards
Uwe

Signature · 3 lines
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962