Skip to contentSkip to conversation

x86/trace: uses/depends on PCI

PATCH In review Randy Dunlap 2 participants 2 messages Apr 16, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/trace: uses/depends on PCI

From: Randy Dunlap <[email protected]>

Don't try to build mmiotrace when CONFIG_PCI=n.

next-20080416/kernel/trace/trace_mmiotrace.c: In function 'mmio_print_pcidev':
next-20080416/kernel/trace/trace_mmiotrace.c:62: error: implicit declaration of function 'pci_dev_driver'

---
 arch/x86/Kconfig.debug |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/Kconfig.debug +2 -2
@@ -186,7 +186,7 @@ config MMIOTRACE_HOOKS
 
 config MMIOTRACE
 	bool "Memory mapped IO tracing"
-	depends on DEBUG_KERNEL
+	depends on DEBUG_KERNEL && PCI
 	select TRACING
 	select MMIOTRACE_HOOKS
 	default y
@@ -194,7 +194,7 @@ config MMIOTRACE
 	  Mmiotrace traces Memory Mapped I/O access and is meant for
 	  debugging and reverse engineering. It is called from the ioremap
 	  implementation and works via page faults. Tracing is disabled by
-	  default and can be enabled run-time.
+	  default and can be enabled at run-time.
 
 	  See Documentation/tracers/mmiotrace.txt.
 	  If you are not helping to develop drivers, say N.
#1 lore raw
Quoted 6 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Don't try to build mmiotrace when CONFIG_PCI=n.

next-20080416/kernel/trace/trace_mmiotrace.c: In function 'mmio_print_pcidev':
next-20080416/kernel/trace/trace_mmiotrace.c:62: error: implicit declaration of function 'pci_dev_driver'

thanks Randy, applied.

Ingo