oss git tree busted....
Lachlan,
Looks like the last update fom the ptools tree missed a bunch of mods.
This (log of all changes with fs/xfs):
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs-2.6.git;a=history;f=fs/xfs;hb=HEAD
Shows:
6 days ago Eric Sandeen [XFS] Ensure "both" features2 slots are consistent 6 days ago David Chinner [XFS] Fix superblock features2 field alignment problem 6 days ago Eric Sandeen [XFS] remove shouting-indirection macros from xfs_sb.h 7 days ago David Chinner [XFS] Catch log unmount failures. 7 days ago David Chinner [XFS] Sanitise xfs_log_force error checking. 7 days ago David Chinner [XFS] Check for errors when changing buffer pointers. 7 days ago David Chinner [XFS] Don't allow silent errors in xfs_inactive(). 7 days ago David Chinner [XFS] Catch errors from xfs_imap(). 7 days ago David Chinner [XFS] [email protected] xfs_bulkstat_one_dinode() never ... 7 days ago David Chinner [XFS] xfs_iflush_fork() never returns an error. 7 days ago David Chinner [XFS] Catch unwritten extent conversion errors. 7 days ago David Chinner [XFS] xfs_bdwrite() does not return errors.
....
It appears that most of the error checking changes I made have been pushed. Note that there's an error in one fo the titles that the scripts have not caught (the reviewers email address!). Can you fix this commit up?
However the real problem is that there are several mods that have not been pushed:
xfs-linux-melb:xfs-kern:30836a xfs-linux-melb:xfs-kern:30838a xfs-linux-melb:xfs-kern:30845a
These are fixes to my original series, and without them you cannot mount an XFS filesystem at all. Can you please push these to the git tree ASAP?
Cheers,
Dave.
Signature · 3 lines
Dave Chinner Principal Engineer SGI Australian Software Group
I pushed all available changes, at the time I did the merge, into the master branch so all these changes must have been checked in after (or during) the last merge. I'll run another merge now.
Quoted 43 lines · David Chinner
Lachlan,
Looks like the last update fom the ptools tree missed a bunch of mods.
This (log of all changes with fs/xfs):
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs-2.6.git;a=history;f=fs/xfs;hb=HEAD
Shows:
6 days ago Eric Sandeen [XFS] Ensure "both" features2 slots are consistent 6 days ago David Chinner [XFS] Fix superblock features2 field alignment problem 6 days ago Eric Sandeen [XFS] remove shouting-indirection macros from xfs_sb.h 7 days ago David Chinner [XFS] Catch log unmount failures. 7 days ago David Chinner [XFS] Sanitise xfs_log_force error checking. 7 days ago David Chinner [XFS] Check for errors when changing buffer pointers. 7 days ago David Chinner [XFS] Don't allow silent errors in xfs_inactive(). 7 days ago David Chinner [XFS] Catch errors from xfs_imap(). 7 days ago David Chinner [XFS] [email protected] xfs_bulkstat_one_dinode() never ... 7 days ago David Chinner [XFS] xfs_iflush_fork() never returns an error. 7 days ago David Chinner [XFS] Catch unwritten extent conversion errors. 7 days ago David Chinner [XFS] xfs_bdwrite() does not return errors.....
It appears that most of the error checking changes I made have been pushed. Note that there's an error in one fo the titles that the scripts have not caught (the reviewers email address!). Can you fix this commit up?
However the real problem is that there are several mods that have not been pushed:
xfs-linux-melb:xfs-kern:30836a xfs-linux-melb:xfs-kern:30838a xfs-linux-melb:xfs-kern:30845aThese are fixes to my original series, and without them you cannot mount an XFS filesystem at all. Can you please push these to the git tree ASAP?
Cheers,
Dave.
The master branch should now be fully up-to-date. The three mods listed below were in the merge.
Quoted 60 lines · Lachlan McIlroy
I pushed all available changes, at the time I did the merge, into the master branch so all these changes must have been checked in after (or during) the last merge. I'll run another merge now.
Quoted 52 lines · David Chinner
Lachlan,
Looks like the last update fom the ptools tree missed a bunch of mods.
This (log of all changes with fs/xfs):
http://oss.sgi.com/cgi-bin/gitweb.cgi?p=xfs/xfs-2.6.git;a=history;f=fs/xfs;hb=HEAD
Shows:
6 days ago Eric Sandeen [XFS] Ensure "both" features2 slots are
consistent
6 days ago David Chinner [XFS] Fix superblock features2 field
alignment problem
6 days ago Eric Sandeen [XFS] remove shouting-indirection macros
fromxfs_sb.h7 days ago David Chinner [XFS] Catch log unmount failures. 7 days ago David Chinner [XFS] Sanitise xfs_log_force error checking. 7 days ago David Chinner [XFS] Check for errors when changing buffer pointers. 7 days ago David Chinner [XFS] Don't allow silent errors in xfs_inactive(). 7 days ago David Chinner [XFS] Catch errors from xfs_imap(). 7 days ago David Chinner [XFS] [email protected]
xfs_bulkstat_one_dinode()never ...
7 days ago David Chinner [XFS]xfs_iflush_fork()never returns an
error.
7 days ago David Chinner [XFS] Catch unwritten extent conversion
errors.
7 days ago David Chinner [XFS]xfs_bdwrite()does not return errors.
....It appears that most of the error checking changes I made have been pushed. Note that there's an error in one fo the titles that the scripts have not caught (the reviewers email address!). Can you fix this commit up?
However the real problem is that there are several mods that have not been pushed:
xfs-linux-melb:xfs-kern:30836a xfs-linux-melb:xfs-kern:30838a xfs-linux-melb:xfs-kern:30845aThese are fixes to my original series, and without them you cannot mount an XFS filesystem at all. Can you please push these to the git tree ASAP?
Cheers,
Dave.
Quoted 3 lines · Lachlan McIlroy
I pushed all available changes, at the time I did the merge, into the master branch so all these changes must have been checked in after (or during) the last merge. I'll run another merge now.
Interesting - one of the bug fixes went in in the middle of the series, but it was missed while all the subsequent mods were picked up. Very strange....
Anyway, looks like it's all up to date now. Thanks.
Cheers,
Dave.
Signature · 3 lines
Dave Chinner Principal Engineer SGI Australian Software Group