Skip to contentSkip to conversation

x86: don't ever allocate PTEs from lowmem

PATCH In review Vegard Nossum 2 participants 2 messages Apr 21, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: don't ever allocate PTEs from lowmem

Hi,

This is needed for the kernel to boot properly without OOMing if PSE is not present or disabled for some reason. It is the fix that you proposed for the kmemcheck OOM-on-boot case. It would also be possible to check the PSE feature before deciding where to allocate from, but I don't think it really matters.

Looks ok?

(And yes, this DOES fix the OOM for me. :-D)

Vegard

Quoted 1 line

From a9ba2e2b1888fad824d3f73561460e2027b2a149 Mon Sep 17 00:00:00 2001

From: Vegard Nossum <[email protected]>
Date: Mon, 21 Apr 2008 20:41:44 +0200
Subject: [PATCH] x86: don't ever allocate PTEs from lowmem

The PSE feature can be non-present for other reasons than having CONFIG_DEBUG_PAGEALLOC=y and may OOM for those cases too. Therefore, always try to allocate PTEs from the normal bootmem pool before falling back to lowmem.

This is an update of:

commit 509a80c49c512ac88bd67b981145f925a306111b

Author: Ingo Molnar <[email protected]>
Date:   Wed Oct 17 18:04:34 2007 +0200

x86: fix CONFIG_PAGEALLOC related boot hangs/OOMs

---
 arch/x86/mm/init_32.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
arch/x86/mm/init_32.c +0 -2
index ee1091a..d3a411b 100644
@@ -91,9 +91,7 @@ static pte_t * __init one_page_table_init(pmd_t *pmd)
 	if (!(pmd_val(*pmd) & _PAGE_PRESENT)) {
 		pte_t *page_table = NULL;
 
-#ifdef CONFIG_DEBUG_PAGEALLOC
 		page_table = (pte_t *) alloc_bootmem_pages(PAGE_SIZE);
-#endif
 		if (!page_table) {
 			page_table =
 				(pte_t *)alloc_bootmem_low_pages(PAGE_SIZE);
Signature · 1 line
1.5.4.1
#1 lore raw
Quoted 9 lines · Vegard Nossum

Hi,

This is needed for the kernel to boot properly without OOMing if PSE is not present or disabled for some reason. It is the fix that you proposed for the kmemcheck OOM-on-boot case. It would also be possible to check the PSE feature before deciding where to allocate from, but I don't think it really matters.

Looks ok?

yes, looks good - thanks, applied.

Quoted 1 line

(And yes, this DOES fix the OOM for me. :-D)

great :)

Ingo