2.6.25-git7 - Kconfig Cleanup
Subsystems (10)
PATCH 1/1 2.6.25-git7 - Kconfig Cleanup
Fix misc small typos/grammar in Kconfigs for 2.6.25-git7.
Signed-off-by Matt LaPlante <[email protected]>
--
arch/blackfin/Kconfig +2 -2
@@ -772,7 +772,7 @@ memory they do not own. This comes at a performance penalty and is recommended only for debugging. -comment "Asynchonous Memory Configuration" +comment "Asynchronous Memory Configuration" menu "EBIU_AMGCTL Global Control" config C_AMCKEN
@@ -804,7 +804,7 @@ default n choice - prompt"Enable Asynchonous Memory Banks" + prompt"Enable Asynchronous Memory Banks" default C_AMBEN_ALL config C_AMBEN
arch/cris/arch-v32/Kconfig +2 -2
@@ -27,8 +27,8 @@ bool "Use one LED group" help Select this if you want one Ethernet LED group. This LED group - can be used for one or more Ethernet interfaces. However, it is - recomended that each Ethernet interface use a dedicated LED group. + can be used for one or more Ethernet interfaces, however it is + recommended that each Ethernet interface use a dedicated LED group. config ETRAX_NBR_LED_GRP_TWO bool "Use two LED groups"
arch/powerpc/Kconfig +1 -1
@@ -323,7 +323,7 @@ help Hypervisor-assisted dump is meant to be a kdump replacement offering robustness and speed not possible without system - hypervisor assistence. + hypervisor assistance. If unsure, say "N"
arch/powerpc/platforms/Kconfig +1 -1
@@ -317,7 +317,7 @@ config OF_RTC bool help - Uses information from the OF or flattened device tree to instatiate + Uses information from the OF or flattened device tree to instantiate platform devices for direct mapped RTC chips like the DS1742 or DS1743. source "arch/powerpc/sysdev/bestcomm/Kconfig"
arch/powerpc/sysdev/bestcomm/Kconfig +2 -2
@@ -9,8 +9,8 @@ select PPC_LIB_RHEAP help BestComm is the name of the communication coprocessor found - on the Freescale MPC5200 family of processor. It's usage is - optionnal for some drivers (like ATA), but required for + on the Freescale MPC5200 family of processor. Its usage is + optional for some drivers (like ATA), but required for others (like FEC). If you want to use drivers that require DMA operations,
arch/ppc/platforms/4xx/Kconfig +1 -1
@@ -117,7 +117,7 @@ # It's often necessary to know the specific 4xx processor type. -# Fortunately, it is impled (so far) from the board type, so we +# Fortunately, it is implied (so far) from the board type, so we # don't need to ask more redundant questions. config NP405H bool
arch/sh/Kconfig +2 -2
@@ -752,10 +752,10 @@ depends on GUSA && CPU_SH3 || (CPU_SH4 && !CPU_SH4A) help Enabling this option will allow the kernel to implement some - atomic operations using a software implemention of load-locked/ + atomic operations using a software implementation of load-locked/ store-conditional (LLSC). On machines which do not have hardware LLSC, this should be more efficient than the other alternative of - disabling insterrupts around the atomic sequence. + disabling interrupts around the atomic sequence. endmenu
drivers/ata/Kconfig +1 -1
@@ -87,7 +87,7 @@ For users with exclusively modern controllers like AHCI, Silicon Image 3124, or Marvell 6440, you may choose to - disable this uneeded SFF support. + disable this unneeded SFF support. If unsure, say Y.
drivers/gpio/Kconfig +3 -3
@@ -17,9 +17,9 @@ depends on DEBUG_KERNEL help Say Y here to add some extra checks and diagnostics to GPIO calls. - The checks help ensure that GPIOs have been properly initialized - before they are used and that sleeping calls aren not made from - nonsleeping contexts. They can make bitbanged serial protocols + These checks help ensure that GPIOs have been properly initialized + before they are used, and that sleeping calls are not made from + non-sleeping contexts. They can make bitbanged serial protocols slower. The diagnostics help catch the type of setup errors that are most common when setting up new platforms or boards.
drivers/hwmon/Kconfig +1 -1
@@ -295,7 +295,7 @@ Computers sensor chips. This is a new merged driver for FSC sensor chips which is intended - as a replacment for the fscpos, fscscy and fscher drivers and adds + as a replacement for the fscpos, fscscy, and fscher drivers, and adds support for several other FCS sensor chips. This driver can also be built as a module. If so, the module
drivers/input/Kconfig +1 -1
@@ -143,7 +143,7 @@ ---help--- Say Y here if you want suspend key events to trigger a user requested suspend through APM. This is useful on embedded - systems where such behviour is desired without userspace + systems where such behaviour is desired without userspace interaction. If unsure, say N. To compile this driver as a module, choose M here: the
drivers/media/dvb/frontends/Kconfig +2 -2
@@ -373,7 +373,7 @@ default m if DVB_FE_CUSTOMISE help A driver for the silicon baseband tuner DiB0070 from DiBcom. - This device is only used inside a SiP called togther with a + This device is only used inside a SiP called together with a demodulator for now. config DVB_TUNER_XC5000
@@ -382,7 +382,7 @@ default m if DVB_FE_CUSTOMISE help A driver for the silicon tuner XC5000 from Xceive. - This device is only used inside a SiP called togther with a + This device is only used inside a SiP called together with a demodulator for now. config DVB_TUNER_ITD1000
drivers/misc/Kconfig +5 -5
@@ -18,8 +18,8 @@ depends on AVR32 || ARCH_AT91 help This option enables device driver support for the PWM channels - on certain Atmel prcoessors. Pulse Width Modulation is used for - purposes including software controlled power-efficent backlights + on certain Atmel processors. Pulse Width Modulation is used for + purposes including software controlled power-efficient backlights on LCD displays, motor control, and waveform generation. config ATMEL_TCLIB
@@ -310,11 +310,11 @@ If you are not sure, say Y here. config THINKPAD_ACPI_HOTKEY_POLL - bool "Suport NVRAM polling for hot keys" + bool "Support NVRAM polling for hot keys" depends on THINKPAD_ACPI default y ---help--- - Some thinkpad models benefit from NVRAM polling to detect a few of + Some ThinkPad models benefit from NVRAM polling to detect a few of the hot key press events. If you know your ThinkPad model does not need to do NVRAM polling to support any of the hot keys you use, unselecting this option will save about 1kB of memory.
@@ -333,7 +333,7 @@ tristate "Device driver for Atmel SSC peripheral" depends on AVR32 || ARCH_AT91 ---help--- - This option enables device driver support for Atmel Syncronized + This option enables device driver support for Atmel Synchronized Serial Communication peripheral (SSC). The SSC peripheral supports a wide variety of serial frame based
drivers/mmc/host/Kconfig +1 -1
@@ -123,7 +123,7 @@ select CRC7 select CRC_ITU_T help - Some systems accss MMC/SD cards using a SPI controller instead of + Some systems access MMC/SD cards using a SPI controller instead of using a "native" MMC/SD controller. This has a disadvantage of being relatively high overhead, but a compensating advantage of working on many systems without dedicated MMC/SD controllers.
fs/Kconfig +1 -1
@@ -1850,7 +1850,7 @@ select CRYPTO_CBC help Choose Y here to enable Secure RPC using the SPKM3 public key - GSS-API mechansim (RFC 2025). + GSS-API mechanism (RFC 2025). Secure RPC calls with SPKM3 require an auxiliary userspace daemon which may be found in the Linux nfs-utils package
init/Kconfig +2 -2
@@ -466,8 +466,8 @@ default n depends on NAMESPACES && EXPERIMENTAL help - Suport process id namespaces. This allows having multiple - process with the same pid as long as they are in different + Support process id namespaces. This allows having multiple + processes with the same pid as long as they are in different pid namespaces. This is a building block of containers. Unless you want to work with an experimental feature
Quoted 9 lines · On Fri, 25 Apr 2008 23:28:48 -0500 Matt LaPlante wrote:
Fix misc small typos/grammar in Kconfigs for 2.6.25-git7.
Signed-off-by Matt LaPlante <[email protected]>--
diff -ru a/arch/cris/arch-v32/Kconfig b/arch/cris/arch-v32/Kconfig
arch/cris/arch-v32/Kconfig line 30
Quoted 6 lines
arch/cris/arch-v32/Kconfig +1
-2@@ -27,8 +27,8 @@ bool "Use one LED group" help Select this if you want one Ethernet LED group. This LED group - can be used for one or more Ethernet interfaces. However, it is - recomended that each Ethernet interface use a dedicated LED group. + can be used for one or more Ethernet interfaces, however it is
That comma creates a run-on sentence. Period was better.
Other than that, looks good. Thanks.
arch/cris/arch-v32/Kconfig line 34
Quoted 4 lines
arch/cris/arch-v32/Kconfig +1
-0+ recommended that each Ethernet interface use a dedicated LED group. config ETRAX_NBR_LED_GRP_TWO bool "Use two LED groups"
---
~Randy
Quoted 7 lines · On Fri, 25 Apr 2008 21:50:37 -0700 Randy Dunlap <[email protected]> wrote:
Quoted 5 lines · On Fri, 25 Apr 2008 23:28:48 -0500 Matt LaPlante wrote:
Fix misc small typos/grammar in Kconfigs for 2.6.25-git7.
Signed-off-by Matt LaPlante <[email protected]>--
Quoted 12 lines
arch/cris/arch-v32/Kconfig line 30
Quoted 10 lines
diff -ru a/arch/cris/arch-v32/Kconfig b/arch/cris/arch-v32/Kconfig
arch/cris/arch-v32/Kconfig +1
-2@@ -27,8 +27,8 @@ bool "Use one LED group" help Select this if you want one Ethernet LED group. This LED group - can be used for one or more Ethernet interfaces. However, it is - recomended that each Ethernet interface use a dedicated LED group. + can be used for one or more Ethernet interfaces, however it isThat comma creates a run-on sentence. Period was better.
My problem is the second sentence starting with "however." Although it's not technically breaking any rules, writing style guides generally advise against beginning sentences with it... and on a more basic level, I really dislike the way it reads in this case.
May I suggest one of:
- This LED group can be used for one or more Ethernet interfaces, however it is recommended that each interface use a dedicated LED group.
- This LED group can be used for one or more Ethernet interfaces. It is still recommended that each interface use a dedicated LED group, however.
- This LED group can be used for one or more Ethernet interfaces. (But it is recommended that each interface use a dedicated LED group.)
Quoted 10 lines
Other than that, looks good. Thanks.
arch/cris/arch-v32/Kconfig line 34
Quoted 4 lines
arch/cris/arch-v32/Kconfig +1
-0+ recommended that each Ethernet interface use a dedicated LED group. config ETRAX_NBR_LED_GRP_TWO bool "Use two LED groups"---
~Randy
Signature · 3 lines
Matt LaPlante CCNP, CCDP, A+, Linux+, CQS [email protected]
Quoted 23 lines · On Sat, 26 Apr 2008 01:17:33 -0500 Matt LaPlante wrote:
Quoted 7 lines · On Fri, 25 Apr 2008 21:50:37 -0700 Randy Dunlap <[email protected]> wrote:
Quoted 5 lines · On Fri, 25 Apr 2008 23:28:48 -0500 Matt LaPlante wrote:
Fix misc small typos/grammar in Kconfigs for 2.6.25-git7.
Signed-off-by Matt LaPlante <[email protected]>--
Quoted 12 lines
arch/cris/arch-v32/Kconfig line 30
Quoted 10 lines
diff -ru a/arch/cris/arch-v32/Kconfig b/arch/cris/arch-v32/Kconfig
arch/cris/arch-v32/Kconfig +1
-2@@ -27,8 +27,8 @@ bool "Use one LED group" help Select this if you want one Ethernet LED group. This LED group - can be used for one or more Ethernet interfaces. However, it is - recomended that each Ethernet interface use a dedicated LED group. + can be used for one or more Ethernet interfaces, however it isThat comma creates a run-on sentence. Period was better.
Quoted 1 line
My problem is the second sentence starting with "however." Although it's not technically breaking any rules, writing style guides generally advise against beginning sentences with it... and on a more basic level, I really dislike the way it reads in this case.
I didn't have a problem with that.
Quoted 3 lines
May I suggest one of:
- This LED group can be used for one or more Ethernet interfaces, however it is recommended that each interface use a dedicated LED group.
Bad sentence grammar.
Quoted 1 line
- This LED group can be used for one or more Ethernet interfaces. It is still recommended that each interface use a dedicated LED group, however.
Inverting the order to put the "however" at the end doesn't help IMO.
Quoted 1 line
- This LED group can be used for one or more Ethernet interfaces. (But it is recommended that each interface use a dedicated LED group.)
- This LED group can be used for one or more Ethernet interfaces, but it is recommended that each interface use a dedicated LED group.
?
Quoted 7 lines
Quoted 7 lines
Other than that, looks good. Thanks.
arch/cris/arch-v32/Kconfig line 34
Quoted 4 lines
arch/cris/arch-v32/Kconfig +1
-0+ recommended that each Ethernet interface use a dedicated LED group. config ETRAX_NBR_LED_GRP_TWO bool "Use two LED groups"
---
~Randy
One change below, per request.
Quoted 5 lines · On Fri, 25 Apr 2008 23:28:48 -0500 Matt LaPlante <[email protected]>…
Fix misc small typos/grammar in Kconfigs for 2.6.25-git7.
Signed-off-by Matt LaPlante <[email protected]>--
arch/blackfin/Kconfig +2 -2
@@ -772,7 +772,7 @@ memory they do not own. This comes at a performance penalty and is recommended only for debugging. -comment "Asynchonous Memory Configuration" +comment "Asynchronous Memory Configuration" menu "EBIU_AMGCTL Global Control" config C_AMCKEN
@@ -804,7 +804,7 @@ default n choice - prompt"Enable Asynchonous Memory Banks" + prompt"Enable Asynchronous Memory Banks" default C_AMBEN_ALL config C_AMBEN
arch/cris/arch-v32/Kconfig +1 -1
@@ -28,7 +28,7 @@ help Select this if you want one Ethernet LED group. This LED group can be used for one or more Ethernet interfaces. However, it is - recomended that each Ethernet interface use a dedicated LED group. + recommended that each Ethernet interface use a dedicated LED group. config ETRAX_NBR_LED_GRP_TWO bool "Use two LED groups"
arch/powerpc/Kconfig +1 -1
@@ -323,7 +323,7 @@ help Hypervisor-assisted dump is meant to be a kdump replacement offering robustness and speed not possible without system - hypervisor assistence. + hypervisor assistance. If unsure, say "N"
arch/powerpc/platforms/Kconfig +1 -1
@@ -317,7 +317,7 @@ config OF_RTC bool help - Uses information from the OF or flattened device tree to instatiate + Uses information from the OF or flattened device tree to instantiate platform devices for direct mapped RTC chips like the DS1742 or DS1743. source "arch/powerpc/sysdev/bestcomm/Kconfig"
arch/powerpc/sysdev/bestcomm/Kconfig +2 -2
@@ -9,8 +9,8 @@ select PPC_LIB_RHEAP help BestComm is the name of the communication coprocessor found - on the Freescale MPC5200 family of processor. It's usage is - optionnal for some drivers (like ATA), but required for + on the Freescale MPC5200 family of processor. Its usage is + optional for some drivers (like ATA), but required for others (like FEC). If you want to use drivers that require DMA operations,
arch/ppc/platforms/4xx/Kconfig +1 -1
@@ -117,7 +117,7 @@ # It's often necessary to know the specific 4xx processor type. -# Fortunately, it is impled (so far) from the board type, so we +# Fortunately, it is implied (so far) from the board type, so we # don't need to ask more redundant questions. config NP405H bool
arch/sh/Kconfig +2 -2
@@ -752,10 +752,10 @@ depends on GUSA && CPU_SH3 || (CPU_SH4 && !CPU_SH4A) help Enabling this option will allow the kernel to implement some - atomic operations using a software implemention of load-locked/ + atomic operations using a software implementation of load-locked/ store-conditional (LLSC). On machines which do not have hardware LLSC, this should be more efficient than the other alternative of - disabling insterrupts around the atomic sequence. + disabling interrupts around the atomic sequence. endmenu
drivers/ata/Kconfig +1 -1
@@ -87,7 +87,7 @@ For users with exclusively modern controllers like AHCI, Silicon Image 3124, or Marvell 6440, you may choose to - disable this uneeded SFF support. + disable this unneeded SFF support. If unsure, say Y.
drivers/gpio/Kconfig +3 -3
@@ -17,9 +17,9 @@ depends on DEBUG_KERNEL help Say Y here to add some extra checks and diagnostics to GPIO calls. - The checks help ensure that GPIOs have been properly initialized - before they are used and that sleeping calls aren not made from - nonsleeping contexts. They can make bitbanged serial protocols + These checks help ensure that GPIOs have been properly initialized + before they are used, and that sleeping calls are not made from + non-sleeping contexts. They can make bitbanged serial protocols slower. The diagnostics help catch the type of setup errors that are most common when setting up new platforms or boards.
drivers/hwmon/Kconfig +1 -1
@@ -295,7 +295,7 @@ Computers sensor chips. This is a new merged driver for FSC sensor chips which is intended - as a replacment for the fscpos, fscscy and fscher drivers and adds + as a replacement for the fscpos, fscscy, and fscher drivers, and adds support for several other FCS sensor chips. This driver can also be built as a module. If so, the module
drivers/input/Kconfig +1 -1
@@ -143,7 +143,7 @@ ---help--- Say Y here if you want suspend key events to trigger a user requested suspend through APM. This is useful on embedded - systems where such behviour is desired without userspace + systems where such behaviour is desired without userspace interaction. If unsure, say N. To compile this driver as a module, choose M here: the
drivers/media/dvb/frontends/Kconfig +2 -2
@@ -373,7 +373,7 @@ default m if DVB_FE_CUSTOMISE help A driver for the silicon baseband tuner DiB0070 from DiBcom. - This device is only used inside a SiP called togther with a + This device is only used inside a SiP called together with a demodulator for now. config DVB_TUNER_XC5000
@@ -382,7 +382,7 @@ default m if DVB_FE_CUSTOMISE help A driver for the silicon tuner XC5000 from Xceive. - This device is only used inside a SiP called togther with a + This device is only used inside a SiP called together with a demodulator for now. config DVB_TUNER_ITD1000
drivers/misc/Kconfig +5 -5
@@ -18,8 +18,8 @@ depends on AVR32 || ARCH_AT91 help This option enables device driver support for the PWM channels - on certain Atmel prcoessors. Pulse Width Modulation is used for - purposes including software controlled power-efficent backlights + on certain Atmel processors. Pulse Width Modulation is used for + purposes including software controlled power-efficient backlights on LCD displays, motor control, and waveform generation. config ATMEL_TCLIB
@@ -310,11 +310,11 @@ If you are not sure, say Y here. config THINKPAD_ACPI_HOTKEY_POLL - bool "Suport NVRAM polling for hot keys" + bool "Support NVRAM polling for hot keys" depends on THINKPAD_ACPI default y ---help--- - Some thinkpad models benefit from NVRAM polling to detect a few of + Some ThinkPad models benefit from NVRAM polling to detect a few of the hot key press events. If you know your ThinkPad model does not need to do NVRAM polling to support any of the hot keys you use, unselecting this option will save about 1kB of memory.
@@ -333,7 +333,7 @@ tristate "Device driver for Atmel SSC peripheral" depends on AVR32 || ARCH_AT91 ---help--- - This option enables device driver support for Atmel Syncronized + This option enables device driver support for Atmel Synchronized Serial Communication peripheral (SSC). The SSC peripheral supports a wide variety of serial frame based
drivers/mmc/host/Kconfig +1 -1
@@ -123,7 +123,7 @@ select CRC7 select CRC_ITU_T help - Some systems accss MMC/SD cards using a SPI controller instead of + Some systems access MMC/SD cards using a SPI controller instead of using a "native" MMC/SD controller. This has a disadvantage of being relatively high overhead, but a compensating advantage of working on many systems without dedicated MMC/SD controllers.
fs/Kconfig +1 -1
@@ -1850,7 +1850,7 @@ select CRYPTO_CBC help Choose Y here to enable Secure RPC using the SPKM3 public key - GSS-API mechansim (RFC 2025). + GSS-API mechanism (RFC 2025). Secure RPC calls with SPKM3 require an auxiliary userspace daemon which may be found in the Linux nfs-utils package
init/Kconfig +2 -2
@@ -466,8 +466,8 @@ default n depends on NAMESPACES && EXPERIMENTAL help - Suport process id namespaces. This allows having multiple - process with the same pid as long as they are in different + Support process id namespaces. This allows having multiple + processes with the same pid as long as they are in different pid namespaces. This is a building block of containers. Unless you want to work with an experimental feature
Randy Dunlap
Acked-byQuoted 8 lines · Matt LaPlante
One change below, per request.
Quoted 3 lines · On Fri, 25 Apr 2008 23:28:48 -0500 Matt LaPlante <[email protected]>…
Fix misc small typos/grammar in Kconfigs for 2.6.25-git7.
Signed-off-by Matt LaPlante <[email protected]>
Acked-by Randy Dunlap <[email protected]>
Thanks, Matt.
Signature · 1 line
~Randy