i2c-sis5595: Minor cleanups in sis5595_access
PATCH 1/1 i2c-sis5595: Minor cleanups in sis5595_access
* Remove commented-out code.
* Use dev_warn instead of printk.
* Remove a legacy comment.
Signed-off-by Jean Delvare <[email protected]>
--- drivers/i2c/busses/i2c-sis5595.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-)
drivers/i2c/busses/i2c-sis5595.c +2 -10
@@ -316,14 +316,8 @@ static s32 sis5595_access(struct i2c_ada } size = (size ==I2C_SMBUS_PROC_CALL ) ?SIS5595_PROC_CALL :SIS5595_WORD_DATA ;break ; -/* -case I2C_SMBUS_BLOCK_DATA: -printk(KERN_WARNING "sis5595.o: Block data not yet implemented!\n"); -return -1; -break; -*/ default : -printk (KERN_WARNING "sis5595.o: Unsupported transaction %d\n" , size); +dev_warn (&adap->dev,"Unsupported transaction %d\n" , size);return -1 ; }
@@ -338,9 +332,7 @@ static s32 sis5595_access(struct i2c_adaswitch (size) { -case SIS5595_BYTE :/* Where is the result put? I assume here it is in -SMB_DATA but it might just as well be in the -SMB_CMD. No clue in the docs */ +case SIS5595_BYTE :case SIS5595_BYTE_DATA : data->byte =sis5595_read (SMB_BYTE );break ;
Signature · 6 lines
Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c