Skip to contentSkip to conversation

ftrace and debugfs weird interaction

DISCUSSION Mathieu Desnoyers 5 participants 6 messages Apr 26, 2008 – Apr 28, 2008

lore
Share & tools
lore
#0 lore raw

Hi,

When trying to figure out what was going on with the sched tracer "tracing_enabled" file (sched-devel.git tree), I fell on this strange behavior :

echo 1>tracing_enabled seems _not_ to send 1 to the tracing_ctrl_write callback. However, sending garbage, e.g. echo s> tracing_enabled, correctly sends the 's' character down the chain. echo 0>tracing_enabled sometimes results in the callback not even being called.

The debugfs file has been created with

        entry = debugfs_create_file("tracing_enabled", 0644, d_tracer,
                                    &global_trace, &tracing_ctrl_fops);
        if (!entry)
                pr_warning("Could not create debugfs 'tracing_enabled' entry\n");

I wonder what kind of weird debugfs interaction we might have here ?

Mathieu

Signature · 2 lines
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
#1 lore raw
Quoted 11 lines · Mathieu Desnoyers

Hi,

When trying to figure out what was going on with the sched tracer "tracing_enabled" file (sched-devel.git tree), I fell on this strange behavior :

echo 1>tracing_enabled seems _not_ to send 1 to the tracing_ctrl_write callback. However, sending garbage, e.g. echo s> tracing_enabled, correctly sends the 's' character down the chain. echo 0>tracing_enabled sometimes results in the callback not even being called.

Quoted 8 lines

The debugfs file has been created with

        entry = debugfs_create_file("tracing_enabled", 0644, d_tracer,
                                    &global_trace, &tracing_ctrl_fops);
        if (!entry)
                pr_warning("Could not create debugfs 'tracing_enabled' entry\n");

I wonder what kind of weird debugfs interaction we might have here ?

I don't know. Are you sure your _fops is not getting called at all?

How about using a "default" operation for such a simple file, like debugfs_create_bool() as that is all you care about for this kind of value?

That should save you some code at the very least :)

thanks,

greg k-h

#2 lore raw
In reply to Mathieu Desnoyers
Quoted 11 lines · Mathieu Desnoyers

Hi,

When trying to figure out what was going on with the sched tracer "tracing_enabled" file (sched-devel.git tree), I fell on this strange behavior :

echo 1>tracing_enabled seems _not_ to send 1 to the tracing_ctrl_write callback. However, sending garbage, e.g. echo s> tracing_enabled, correctly sends the 's' character down the chain. echo 0>tracing_enabled sometimes results in the callback not even being called.

Quoted 8 lines

The debugfs file has been created with

        entry = debugfs_create_file("tracing_enabled", 0644, d_tracer,
                                    &global_trace, &tracing_ctrl_fops);
        if (!entry)
                pr_warning("Could not create debugfs 'tracing_enabled' entry\n");

I wonder what kind of weird debugfs interaction we might have here ?

hm. Cc:-ed more ftrace developers.

Ingo

#3 lore raw
Quoted 10 lines · Ingo Molnar
Quoted 7 lines · Mathieu Desnoyers

Hi,

When trying to figure out what was going on with the sched tracer "tracing_enabled" file (sched-devel.git tree), I fell on this strange behavior :

echo 1>tracing_enabled seems _not_ to send 1 to the tracing_ctrl_write

It should actually send "1" and not 1 (and technically "1\n") ;-)

Quoted 3 lines
Quoted 3 lines

callback. However, sending garbage, e.g. echo s> tracing_enabled, correctly sends the 's' character down the chain. echo 0>tracing_enabled sometimes results in the callback not even being called.

I haven't seen this. Perhaps I'm confused about what you are seeing.

Quoted 9 lines
Quoted 9 lines

The debugfs file has been created with

        entry = debugfs_create_file("tracing_enabled", 0644, d_tracer,
                                    &global_trace, &tracing_ctrl_fops);
        if (!entry)
                pr_warning("Could not create debugfs 'tracing_enabled' entry\n");

I wonder what kind of weird debugfs interaction we might have here ?

This looks normal to me. Could you provide a bit more detail to what you are doing, what the results are, and what you expect the restults to be?

Quoted 2 lines

hm. Cc:-ed more ftrace developers.

Thanks,

-- Steve

#4 lore raw
In reply to Ingo Molnar
Quoted 9 lines · Mathieu Desnoyers
Quoted 8 lines

Hi,

When trying to figure out what was going on with the sched tracer "tracing_enabled" file (sched-devel.git tree), I fell on this strange behavior :

echo 1>tracing_enabled seems _not_ to send 1 to the tracing_ctrl_write

Wait a minute, are you literally running the command:
echo 1>tracing_enabled

If you are, you just echoed only a newline and directed stdout, stream 1, to the file. No? :-)

Could you try with a space:
echo 1 > tracing_enabled

Quoted 3 lines
Quoted 3 lines

callback. However, sending garbage, e.g. echo s> tracing_enabled, correctly sends the 's' character down the chain. echo 0>tracing_enabled sometimes results in the callback not even being called.

Stream 0 is stdin, so... not sure what this would do. Probably nothing, just like you experienced.

Thanks.

Signature · 2 lines
Pekka Paalanen
http://www.iki.fi/pq/
#5 lore raw
Quoted 19 lines · * Pekka Paalanen ([email protected]) wrote:
Quoted 9 lines · Mathieu Desnoyers
Quoted 8 lines

Hi,

When trying to figure out what was going on with the sched tracer "tracing_enabled" file (sched-devel.git tree), I fell on this strange behavior :

echo 1>tracing_enabled seems _not_ to send 1 to the tracing_ctrl_write

Wait a minute, are you literally running the command:
echo 1>tracing_enabled

If you are, you just echoed only a newline and directed stdout, stream 1, to the file. No? :-)

Could you try with a space:
echo 1 > tracing_enabled

Quoted 7 lines
Quoted 3 lines
Quoted 3 lines

callback. However, sending garbage, e.g. echo s> tracing_enabled, correctly sends the 's' character down the chain. echo 0>tracing_enabled sometimes results in the callback not even being called.

Stream 0 is stdin, so... not sure what this would do. Probably nothing, just like you experienced.

*duh*. Ok. That wasn't smart. You spotted the problem. Thanks a lot :)

Mathieu

Quoted 6 lines

Thanks.

Signature · 2 lines
Pekka Paalanen
http://www.iki.fi/pq/
Signature · 2 lines
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68