Skip to contentSkip to conversation

i2c/tps65010: Add missing intialization of client data

PATCH New Jean Delvare 1 participant 1 message Apr 27, 2008 I2C subsystem host drivers

lore
Share & tools
lore

Jean Delvare

author
#0 lore raw

PATCH 1/1 i2c/tps65010: Add missing intialization of client data

tps65010_remove() calls i2c_get_clientdata(client) but the client data is never set during initialization, so it gets a NULL pointer at best.

I guess it was never spotted because the tps65010 driver is typically not built modular so this function is discarded.

Signed-off-by Jean Delvare <[email protected]>
Cc David Brownell <[email protected]>
---
 drivers/i2c/chips/tps65010.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/i2c/chips/tps65010.c +2 -0
@@ -527,6 +527,7 @@ static int __exit tps65010_remove(struct
 	flush_scheduled_work();
 	debugfs_remove(tps->file);
 	kfree(tps);
+	i2c_set_clientdata(client, NULL);
 	the_tps = NULL;
 	return 0;
 }

@@ -616,6 +617,7 @@ static int tps65010_probe(struct i2c_cli
 		i2c_smbus_read_byte_data(client, TPS_DEFGPIO),
 		i2c_smbus_read_byte_data(client, TPS_MASK3));
 
+	i2c_set_clientdata(client, tps);
 	the_tps = tps;
 
 #if	defined(CONFIG_USB_GADGET) && !defined(CONFIG_USB_OTG)
Signature · 6 lines
Jean Delvare

_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c