Skip to contentSkip to conversation

pxa2xx_spi clock resume bugfix

PATCH In review David Brownell 2 participants 2 messages Apr 29, 2008 – Apr 30, 2008 1 message not in the archive SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pxa2xx_spi clock resume bugfix

From: Eric BENARD <[email protected]>

There is a typo in pxa2xx_spi.c, comment says "Enable the SSP clock", code says: clk_disable ... so after resume, the SSP is dead.

---
 drivers/spi/pxa2xx_spi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/pxa2xx_spi.c +1 -1
@@ -1567,7 +1567,7 @@ static int pxa2xx_spi_resume(struct plat
 	int status = 0;
 
 	/* Enable the SSP clock */
-	clk_disable(ssp->clk);
+	clk_enable(ssp->clk);
 
 	/* Start the queue running */
 	status = start_queue(drv_data);

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone

#2 lore raw
In reply to a message not in the archive
Quoted 13 lines · David Brownell

From: Eric BENARD <[email protected]>

There is a typo in pxa2xx_spi.c, comment says "Enable the SSP clock", code says: clk_disable ... so after resume, the SSP is dead.

---
 drivers/spi/pxa2xx_spi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/spi/pxa2xx_spi.c static int pxa2xx_spi_resume(struct plat · line 1573

Quoted 8 lines
drivers/spi/pxa2xx_spi.c +1 -1
@@ -1567,7 +1567,7 @@ static int pxa2xx_spi_resume(struct plat
 	int status = 0;
 
 	/* Enable the SSP clock */
-	clk_disable(ssp->clk);
+	clk_enable(ssp->clk);
 
 	/* Start the queue running */
 	status = start_queue(drv_data);

Quite right. The original pxa2xx_spi.c had this right, but the patch by Eric Miao, merged on 2008/1/26, introduced this error.

Signature · 14 lines
Ned Forrester                                       nforrester-/[email protected]
Oceanographic Systems Lab                                  508-289-2226
Applied Ocean Physics and Engineering Dept.
Woods Hole Oceanographic Institution          Woods Hole, MA 02543, USA
http://www.whoi.edu/sbl/liteSite.do?litesiteid=7212
http://www.whoi.edu/hpb/Site.do?id=1532
http://www.whoi.edu/page.do?pid=10079


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone