+ mm-add-a-basic-debugging-framework-for-memory-initialisation.patch added to -mm tree
Subsystems (2)
The patch titled
mm: add a basic debugging framework for memory initialisation
has been added to the -mm tree. Its filename is
mm-add-a-basic-debugging-framework-for-memory-initialisation.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: mm: add a basic debugging framework for memory initialisation
From: Mel Gorman <[email protected]>
Boot initialisation is very complex, with significant numbers of architecture-specific routines, hooks and code ordering. While significant amounts of the initialisation is architecture-independent, it trusts the data received from the architecture layer. This is a mistake, and has resulted in a number of difficult-to-diagnose bugs.
This patchset adds some validation and tracing to memory initialisation. It also introduces a few basic defensive measures. The validation code can be explicitly disabled for embedded systems.
This patch:
Add additional debugging and verification code for memory initialisation.
Once enabled, the verification checks are always run and when required additional debugging information may be outputted via a mminit_loglevel= command-line parameter.
The verification code is placed in a new file mm/mm_init.c. Ideally other mm initialisation code will be moved here over time.
---
Documentation/kernel-parameters.txt | 8 +++++++ lib/Kconfig.debug | 12 +++++++++++ mm/Makefile | 1 mm/internal.h | 27 ++++++++++++++++++++++++++ mm/mm_init.c | 18 +++++++++++++++++ mm/page_alloc.c | 16 +++++++++------ 6 files changed, 76 insertions(+), 6 deletions(-)
Documentation/kernel-parameters.txt renamed from Documentation/kernel-parameters.txt~mm-add-a-basic-debugging-framework-for-memory-initialisation +8 -0
@@ -1178,6 +1178,14 @@ and is between 256 and 4096 characters. mga= [HW,DRM] + mminit_loglevel= + [KNL] When CONFIG_DEBUG_MEMORY_INIT is set, this + parameter allows control of the logging verbosity for + the additional memory initialisation checks. A value + of 0 disables mminit logging and a level of 4 will + log everything. Information is printed at KERN_DEBUG + so loglevel=8 may also need to be specified. + mousedev.tap_time= [MOUSE] Maximum time between finger touching and leaving touchpad surface for touch to be considered
lib/Kconfig.debug renamed from lib/Kconfig.debug~mm-add-a-basic-debugging-framework-for-memory-initialisation +12 -0
@@ -448,6 +448,18 @@ config DEBUG_WRITECOUNT If unsure, say N. +config DEBUG_MEMORY_INIT + bool "Debug memory initialisation" if EMBEDDED + default !EMBEDDED + help + Enable this for additional checks during memory initialisation. + The sanity checks verify aspects of the VM such as the memory model + and other information provided by the architecture. Verbose + information will be printed at KERN_DEBUG loglevel depending + on the mminit_loglevel= command-line option. + + If unsure, say Y + config DEBUG_LIST bool "Debug linked list manipulation" depends on DEBUG_KERNEL
mm/Makefile renamed from mm/Makefile~mm-add-a-basic-debugging-framework-for-memory-initialisation +1 -0
@@ -33,4 +33,5 @@ obj-$(CONFIG_MIGRATION) += migrate.o obj-$(CONFIG_SMP) += allocpercpu.o obj-$(CONFIG_QUICKLIST) += quicklist.o obj-$(CONFIG_CGROUP_MEM_RES_CTLR) += memcontrol.o +obj-$(CONFIG_DEBUG_MEMORY_INIT) += mm_init.o
mm/internal.h renamed from mm/internal.h~mm-add-a-basic-debugging-framework-for-memory-initialisation +27 -0
@@ -59,4 +59,31 @@ static inline unsigned long page_order(s#define __paginginit __init#endif +/* Memory initialisation debug and verification */ +enum mminit_level { +MMINIT_WARNING , +MMINIT_VERIFY , +MMINIT_TRACE +}; + +#ifdef CONFIG_DEBUG_MEMORY_INIT + +extern int mminit_loglevel; + +#define mminit_dprintk(level, prefix, fmt, arg...) \ +do { \ + if (level < mminit_loglevel) { \ + printk(level <= MMINIT_WARNING ? KERN_WARNING : KERN_DEBUG \ + "mminit:: " prefix " " fmt, ##arg); \ + } \ +} while (0) + +#else + +static inline void mminit_dprintk (enum mminit_level level, +const char *prefix,const char *fmt, ...) +{ +} + +#endif /* CONFIG_DEBUG_MEMORY_INIT */ #endif
mm/mm_init.c renamed from mm/mm_init.c~mm-add-a-basic-debugging-framework-for-memory-initialisation +18 -0
@@ -0,0 +1,18 @@ +/* +* mm_init.c - Memory initialisation verification and debugging +* +* Copyright 2008 IBM Corporation, 2008 +* Author Mel Gorman <[email protected]> +* +*/ +#include <linux/kernel.h> +#include <linux/init.h> + +int __meminitdata mminit_loglevel; + +static __init int set_mminit_loglevel (char *str) +{ +get_option (&str, &mminit_loglevel); +return 0 ; +} +early_param ("mminit_loglevel" , set_mminit_loglevel);
mm/page_alloc.c renamed from mm/page_alloc.c~mm-add-a-basic-debugging-framework-for-memory-initialisation +10 -6
@@ -2985,7 +2985,8 @@ void __init sparse_memory_present_with_avoid __init push_node_boundaries (unsigned int nid,unsigned long start_pfn,unsigned long end_pfn) { -printk (KERN_DEBUG "Entering push_node_boundaries(%u, %lu, %lu)\n" , +mminit_dprintk (MMINIT_TRACE ,"zoneboundary" , +"Entering push_node_boundaries(%u, %lu, %lu)\n" , nid, start_pfn, end_pfn);/* Initialise the boundary for this node if necessary */
@@ -3003,7 +3004,8 @@ void __init push_node_boundaries(unsignestatic void __meminit account_node_boundary (unsigned int nid,unsigned long *start_pfn,unsigned long *end_pfn) { -printk (KERN_DEBUG "Entering account_node_boundary(%u, %lu, %lu)\n" , +mminit_dprintk (MMINIT_TRACE ,"zoneboundary" , +"Entering account_node_boundary(%u, %lu, %lu)\n" , nid, *start_pfn, *end_pfn);/* Return if boundary information has not been provided */
@@ -3377,8 +3379,8 @@ static void __paginginit free_area_init_ memmap_pages = (size *sizeof (struct page )) >>PAGE_SHIFT ;if (realsize >= memmap_pages) { realsize -= memmap_pages; -printk (KERN_DEBUG -" %s zone: %lu pages used for memmap\n" , +mminit_dprintk (MMINIT_TRACE ,"memmap_init" , +"%s zone: %lu pages used for memmap\n" , zone_names[j], memmap_pages); }else printk(KERN_WARNING
@@ -3388,7 +3390,8 @@ static void __paginginit free_area_init_/* Account for reserved pages */ if (j ==0 && realsize > dma_reserve) { realsize -= dma_reserve; -printk (KERN_DEBUG " %s zone: %lu pages reserved\n" , +mminit_dprintk (MMINIT_TRACE ,"memmap_init" , +"%s zone: %lu pages reserved\n" , zone_names[0 ], dma_reserve); }
@@ -3523,7 +3526,8 @@ void __init add_active_range(unsigned in {int i; -printk (KERN_DEBUG "Entering add_active_range(%d, %lu, %lu) " +mminit_dprintk (MMINIT_TRACE ,"memory_register" , +"Entering add_active_range(%d, %lu, %lu) " "%d entries of %d used\n" , nid, start_pfn, end_pfn, nr_nodemap_entries,MAX_ACTIVE_REGIONS );
_
Patches currently in -mm which might be from [email protected] are
origin.patch
mm-fix-usemap-initialization.patch mm-fix-misleading-__gfp_repeat-related-comments.patch page-allcoator-smarter-retry-of-costly-order-allocations.patch page-allocator-explicitly-retry-hugepage-allocations.patch memcgroup-move-memory-controller-allocations-to-their-own-slabs.patch proc-pagetypeinfo-fix-output-for-memoryless-nodes.patch mm-add-a-basic-debugging-framework-for-memory-initialisation.patch mm-verify-the-page-links-and-memory-model.patch mm-make-defensive-checks-around-pfn-values-registered-for-memory-usage.patch mm-print-out-the-zonelists-on-request-for-manual-verification.patch page-owner-tracking-leak-detector.patch add-debugging-aid-for-memory-initialisation-problems.patch
PATCH 1/1 Fix for memory initialisation debugging framework
On (29/04/08 14:26), [email protected] didst pronounce:
Quoted 6 lines
The patch titled
mm: add a basic debugging framework for memory initialisation
has been added to the -mm tree. Its filename is
mm-add-a-basic-debugging-framework-for-memory-initialisation.patch
This patch is a fix to mm-add-a-basic-debugging-framework-for-memory-initialisation.patch pointed out by an off-list reviewer. The intention of the code was to change the printk loglevel depending on the message level passed to mminit_dprintk(). What actually happens is that for MMINIT_WARNING and levels, only the loglevel is sent to printk() and not the message. This patch fixes the code to behave as intended.
It can be folded safely into mm-add-a-basic-debugging-framework-for-memory-initialisation.patch without causing collisions later in the set.
--- mm/internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/internal.h +2 -2
@@ -73,8 +73,8 @@ extern int mminit_loglevel; #define mminit_dprintk(level, prefix, fmt, arg...) \ do { \ if (level < mminit_loglevel) { \ - printk(level <= MMINIT_WARNING ? KERN_WARNING : KERN_DEBUG \ - "mminit:: " prefix " " fmt, ##arg); \ + printk(level <= MMINIT_WARNING ? KERN_WARNING : KERN_DEBUG); \ + printk(KERN_CONT "mminit::" prefix " " fmt, ##arg); \ } \ } while (0)