cleanup return values in drivers/misc/sgi-xp
PATCH 1/1 cleanup return values in drivers/misc/sgi-xp
Make XP return values more generic to XP and not so tied to XPC by changing enum xpc_retval to xp_retval, along with changing return value prefixes from xpc to xp. Also, cleanup a comment block that referenced some of these return values as well as the handling of BTE related return values.
Signed-off-by Dean Nelson <[email protected]>
Acked-by Robin Holt <[email protected]>
---
drivers/misc/sgi-xp/xp.h | 293 +++++++++++--------------------- drivers/misc/sgi-xp/xp_main.c | 38 ++-- drivers/misc/sgi-xp/xpc.h | 71 ++----- drivers/misc/sgi-xp/xpc_channel.c | 166 +++++++++--------- drivers/misc/sgi-xp/xpc_main.c | 44 ++-- drivers/misc/sgi-xp/xpc_partition.c | 64 +++--- drivers/misc/sgi-xp/xpnet.c | 18 - 7 files changed, 292 insertions(+), 402 deletions(-)
drivers/misc/sgi-xp/xp_main.c +19 -19
@@ -42,21 +42,21 @@ EXPORT_SYMBOL_GPL(xpc_registrations);/* * Initialize the XPC interface to indicate that XPC isn't loaded. */ -static enum xpc_retval +static enum xp_retval xpc_notloaded (void ) { -return xpcNotLoaded; +return xpNotLoaded; }struct xpc_interface xpc_interface = { (void (*)(int ))xpc_notloaded, (void (*)(int ))xpc_notloaded, - (enum xpc_retval (*)(partid_t ,int ,u32 ,void **))xpc_notloaded, - (enum xpc_retval (*)(partid_t ,int ,void *))xpc_notloaded, - (enum xpc_retval (*)(partid_t ,int ,void *,xpc_notify_func ,void *)) + (enum xp_retval (*)(partid_t ,int ,u32 ,void **))xpc_notloaded, + (enum xp_retval (*)(partid_t ,int ,void *))xpc_notloaded, + (enum xp_retval (*)(partid_t ,int ,void *,xpc_notify_func ,void *)) xpc_notloaded, (void (*)(partid_t ,int ,void *))xpc_notloaded, - (enum xpc_retval (*)(partid_t ,void *))xpc_notloaded + (enum xp_retval (*)(partid_t ,void *))xpc_notloaded };EXPORT_SYMBOL_GPL (xpc_interface);
@@ -66,12 +66,12 @@ EXPORT_SYMBOL_GPL(xpc_interface);void xpc_set_interface (void (*connect) (int ),void (*disconnect) (int ), -enum xpc_retval (*allocate) (partid_t ,int ,u32 ,void **), -enum xpc_retval (*send) (partid_t ,int ,void *), -enum xpc_retval (*send_notify) (partid_t ,int ,void *, +enum xp_retval (*allocate) (partid_t ,int ,u32 ,void **), +enum xp_retval (*send) (partid_t ,int ,void *), +enum xp_retval (*send_notify) (partid_t ,int ,void *,xpc_notify_func ,void *),void (*received) (partid_t ,int ,void *), -enum xpc_retval (*partid_to_nasids) (partid_t ,void *)) +enum xp_retval (*partid_to_nasids) (partid_t ,void *)) { xpc_interface.connect = connect; xpc_interface.disconnect = disconnect;
@@ -91,16 +91,16 @@ xpc_clear_interface(void) { xpc_interface.connect = (void (*)(int ))xpc_notloaded; xpc_interface.disconnect = (void (*)(int ))xpc_notloaded; - xpc_interface.allocate = (enum xpc_retval (*)(partid_t ,int ,u32 , + xpc_interface.allocate = (enum xp_retval (*)(partid_t ,int ,u32 ,void **))xpc_notloaded; - xpc_interface.send = (enum xpc_retval (*)(partid_t ,int ,void *)) + xpc_interface.send = (enum xp_retval (*)(partid_t ,int ,void *)) xpc_notloaded; - xpc_interface.send_notify = (enum xpc_retval (*)(partid_t ,int ,void *, + xpc_interface.send_notify = (enum xp_retval (*)(partid_t ,int ,void *,xpc_notify_func ,void *))xpc_notloaded; xpc_interface.received = (void (*)(partid_t ,int ,void *)) xpc_notloaded; - xpc_interface.partid_to_nasids = (enum xpc_retval (*)(partid_t ,void *)) + xpc_interface.partid_to_nasids = (enum xp_retval (*)(partid_t ,void *)) xpc_notloaded; }EXPORT_SYMBOL_GPL (xpc_clear_interface);
@@ -123,13 +123,13 @@ EXPORT_SYMBOL_GPL(xpc_clear_interface);* nentries - max #of XPC message entries a message queue can contain. * The actual number, which is determined when a connection * is established and may be less then requested, will be -* passed to the user via the xpcConnected callout. +* passed to the user via the xpConnected callout. * assigned_limit - max number of kthreads allowed to be processing * messages (per connection) at any given instant. * idle_limit - max number of kthreads allowed to be idle at any given * instant. */ -enum xpc_retval +enum xp_retval xpc_connect (int ch_number,xpc_channel_func func,void *key,u16 payload_size,u16 nentries,u32 assigned_limit,u32 idle_limit) {
@@ -143,12 +143,12 @@ xpc_connect(int ch_number, xpc_channel_f registration = &xpc_registrations[ch_number];if (mutex_lock_interruptible (®istration->mutex) !=0 ) -return xpcInterrupted; +return xpInterrupted;/* if XPC_CHANNEL_REGISTERED(ch_number) */ if (registration->func !=NULL ) {mutex_unlock (®istration->mutex); -return xpcAlreadyRegistered; +return xpAlreadyRegistered; }/* register the channel for connection */
@@ -163,7 +163,7 @@ xpc_connect(int ch_number, xpc_channel_f xpc_interface.connect (ch_number); -return xpcSuccess; +return xpSuccess; }EXPORT_SYMBOL_GPL (xpc_connect);
drivers/misc/sgi-xp/xpc.h +20 -51
134 lines not on this page · raw message
drivers/misc/sgi-xp/xpc_channel.c +83 -83
576 lines not on this page · raw message
drivers/misc/sgi-xp/xpc_main.c +22 -22
146 lines not on this page · raw message
drivers/misc/sgi-xp/xpc_partition.c +32 -32
222 lines not on this page · raw message
drivers/misc/sgi-xp/xp.h +107 -186
372 lines not on this page · raw message
drivers/misc/sgi-xp/xpnet.c +9 -9
@@ -282,7 +282,7 @@ xpnet_receive(partid_t partid, int chann* state or message reception on a connection. */ static void -xpnet_connection_activity (enum xpc_retval reason,partid_t partid,int channel, +xpnet_connection_activity (enum xp_retval reason,partid_t partid,int channel,void *data,void *key) {long bp;
@@ -291,13 +291,13 @@ xpnet_connection_activity(enum xpc_retvaDBUG_ON (channel !=XPC_NET_CHANNEL );switch (reason) { -case xpcMsgReceived:/* message received */ +case xpMsgReceived:/* message received */ DBUG_ON (data ==NULL );xpnet_receive (partid, channel, (struct xpnet_message *)data);break ; -case xpcConnected:/* connection completed to a partition */ +case xpConnected:/* connection completed to a partition */ spin_lock_bh (&xpnet_broadcast_lock); xpnet_broadcast_partitions |=1UL << (partid -1 ); bp = xpnet_broadcast_partitions;
@@ -330,7 +330,7 @@ xpnet_connection_activity(enum xpc_retvastatic int xpnet_dev_open (struct net_device *dev) { -enum xpc_retval ret; +enum xp_retval ret; dev_dbg(xpnet, "calling xpc_connect(%d, 0x%p, NULL, %ld, %ld, %ld, " "%ld)\n", XPC_NET_CHANNEL, xpnet_connection_activity,
@@ -340,7 +340,7 @@ xpnet_dev_open(struct net_device *dev) ret =xpc_connect (XPC_NET_CHANNEL , xpnet_connection_activity,NULL ,XPNET_MSG_SIZE ,XPNET_MSG_NENTRIES ,XPNET_MAX_KTHREADS ,XPNET_MAX_IDLE_KTHREADS ); -if (ret != xpcSuccess) { +if (ret != xpSuccess) {dev_err (xpnet,"ifconfig up of %s failed on XPC connect, " "ret=%d\n" , dev->name, ret);
@@ -407,7 +407,7 @@ xpnet_dev_get_stats(struct net_device *d* release the skb and then release our pending message structure. */ static void -xpnet_send_completed (enum xpc_retval reason,partid_t partid,int channel, +xpnet_send_completed (enum xp_retval reason,partid_t partid,int channel,void *__qm) {struct xpnet_pending_msg *queued_msg = (struct xpnet_pending_msg *)__qm;
@@ -439,7 +439,7 @@ static int xpnet_dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev) { struct xpnet_pending_msg *queued_msg; -enum xpc_retval ret; +enum xp_retval ret;struct xpnet_message *msg;u64 start_addr, end_addr;long dp;
@@ -528,7 +528,7 @@ xpnet_dev_hard_start_xmit(struct sk_buff ret =xpc_allocate (dest_partid,XPC_NET_CHANNEL ,XPC_NOWAIT , (void **)&msg); -if (unlikely (ret != xpcSuccess)) +if (unlikely (ret != xpSuccess))continue ; msg->embedded_bytes = embedded_bytes;
@@ -557,7 +557,7 @@ xpnet_dev_hard_start_xmit(struct sk_buff ret =xpc_send_notify (dest_partid,XPC_NET_CHANNEL , msg, xpnet_send_completed, queued_msg); -if (unlikely (ret != xpcSuccess)) { +if (unlikely (ret != xpSuccess)) {atomic_dec (&queued_msg->use_count);continue ; }