Linux 2.6.24.6
Subsystems (10)
We (the -stable team) are announcing the release of the 2.6.24.6 kernel.
If fixes a number of different bugs and some security issues so that all users of the 2.6.24 series of kernels are strongly encouraged to upgrade.
Note, barring some major security issue, this is probably going to be the last 2.6.24 kernel released. You all should move on to the 2.6.25 series by now.
I'll also be replying to this message with a copy of the patch between 2.6.24.5 and 2.6.24.6
The updated 2.6.24.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.24.y.git
and can be browsed at the normal kernel.org git web browser:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.24.y.git;a=summarythanks,
greg k-h
--------
Makefile | 2 +- arch/x86/kernel/io_apic_32.c | 1 + drivers/isdn/capi/capidrv.c | 9 +++++---- drivers/isdn/i4l/isdn_net.c | 1 + drivers/media/video/cx88/cx88-cards.c | 4 ++++ drivers/media/video/ivtv/ivtv-ioctl.c | 3 ++- drivers/net/tehuti.c | 15 +++++++++++++++ drivers/usb/gadget/ether.c | 1 + drivers/usb/serial/usb-serial.c | 2 ++ fs/dnotify.c | 11 +++++++++++ fs/jffs2/erase.c | 18 ++++++++---------- fs/splice.c | 2 +- include/net/tcp.h | 7 +++++-- 13 files changed, 57 insertions(+), 19 deletions(-)
Al Viro (1):
Fix dnotify/close race (CVE-2008-1375)
Alan Cox (1):
V4L: Fix VIDIOCGAP corruption in ivtv
David Woodhouse (1):
JFFS2: Fix free space leak with in-band cleanmarkers
Francois Romieu (1):
tehuti: check register size (CVE-2008-1675)
Greg Kroah-Hartman (2):
USB: remove broken usb-serial num_endpoints check Linux 2.6.24.6
Hugh Dickins (1):
splice: use mapping_gfp_mask
Jan Altenberg (1):
USB: gadget: queue usb USB_CDC_GET_ENCAPSULATED_RESPONSE message
Jeff Garzik (1):
tehuti: move ioctl perm check closer to function start (CVE-2008-1675)
John Heffner (1):
Increase the max_burst threshold from 3 to tp->reordering.
Karsten Keil (1):
fix oops on rmmod capidrv
PJ Waskiewicz (1):
x86: Fix 32-bit x86 MSI-X allocation leakage
Paul Bolle (1):
ISDN: Do not validate ISDN net device address prior to interface-up
Steven Toth (1):
V4L: cx88: enable radio GPIO correctly
Makefile +1 -1
@@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 24 -EXTRAVERSION = .5 +EXTRAVERSION = .6 NAME = Err Metey! A Heury Beelge-a Ret! # *DOCUMENTATION*
arch/x86/kernel/io_apic_32.c +1 -0
@@ -2478,6 +2478,7 @@ void destroy_irq(unsigned int irq)dynamic_irq_cleanup (irq);spin_lock_irqsave (&vector_lock, flags); +clear_bit (irq_vector[irq], used_vectors); irq_vector[irq] =0 ;spin_unlock_irqrestore (&vector_lock, flags); }
drivers/isdn/capi/capidrv.c +5 -4
@@ -2332,13 +2332,14 @@ static int __init capidrv_init(void) static void __exit capidrv_exit(void) { -char rev[10 ]; +char rev[32 ];char *p;if ((p =strchr (revision,':' )) !=0 ) { -strcpy (rev, p +1 ); - p =strchr (rev,'$' ); - *p =0 ; +strncpy (rev, p +1 ,sizeof (rev)); + rev[sizeof (rev)-1 ] =0 ; +if ((p =strchr (rev,'$' )) !=0 ) + *p =0 ; }else {strcpy (rev," ??? " ); }
drivers/isdn/i4l/isdn_net.c +1 -0
@@ -2010,6 +2010,7 @@ isdn_net_init(struct net_device *ndev) ndev->flags =IFF_NOARP |IFF_POINTOPOINT ; ndev->type =ARPHRD_ETHER ; ndev->addr_len =ETH_ALEN ; + ndev->validate_addr =NULL ;/* for clients with MPPP maybe higher values better */ ndev->tx_queue_len =30 ;
drivers/media/video/cx88/cx88-cards.c +4 -0
@@ -1349,6 +1349,10 @@ static const struct cx88_board cx88_boards[] = { }}, /* fixme: Add radio support */ .mpeg = CX88_MPEG_DVB | CX88_MPEG_BLACKBIRD, + .radio = { + .type = CX88_RADIO, + .gpio0 = 0xe780, + }, }, [CX88_BOARD_ADSTECH_PTV_390] = { .name = "ADS Tech Instant Video PCI",
drivers/media/video/ivtv/ivtv-ioctl.c +2 -1
@@ -727,7 +727,8 @@ int ivtv_v4l2_ioctls(struct ivtv *itv, struct file *filp, unsigned int cmd, voidmemset (vcap,0 ,sizeof (*vcap));strcpy (vcap->driver,IVTV_DRIVER_NAME );/* driver name */ -strcpy (vcap->card, itv->card_name);/* card type */ +strncpy (vcap->card, itv->card_name, +sizeof (vcap->card)-1 );/* card type */ strcpy (vcap->bus_info,pci_name (itv->dev));/* bus info... */ vcap->version =IVTV_DRIVER_VERSION ;/* version */ vcap->capabilities = itv->v4l2_cap;/* capabilities */
drivers/net/tehuti.c +15 -0
@@ -625,6 +625,12 @@ static void __init bdx_firmware_endianess(void) s_firmLoad[i] =CPU_CHIP_SWAP32 (s_firmLoad[i]); } +static int bdx_range_check (struct bdx_priv *priv,u32 offset) +{ +return (offset > (u32) (BDX_REGS_SIZE / priv->nic->port_num)) ? + -EINVAL :0 ; +} +static int bdx_ioctl_priv (struct net_device *ndev,struct ifreq *ifr,int cmd) {struct bdx_priv *priv = ndev->priv;
@@ -643,9 +649,15 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)DBG ("%d 0x%x 0x%x\n" , data[0 ], data[1 ], data[2 ]); } +if (!capable (CAP_NET_ADMIN )) +return -EPERM ; +switch (data[0 ]) {case BDX_OP_READ : + error =bdx_range_check (priv, data[1 ]); +if (error <0 ) +return error; data[2 ] =READ_REG (priv, data[1 ]);DBG ("read_reg(0x%x)=0x%x (dec %d)\n" , data[1 ], data[2 ], data[2 ]);
@@ -655,6 +667,9 @@ static int bdx_ioctl_priv(struct net_device *ndev, struct ifreq *ifr, int cmd)break ;case BDX_OP_WRITE : + error =bdx_range_check (priv, data[1 ]); +if (error <0 ) +return error;WRITE_REG (priv, data[1 ], data[2 ]);DBG ("write_reg(0x%x, 0x%x)\n" , data[1 ], data[2 ]);break ;
drivers/usb/gadget/ether.c +1 -0
@@ -1561,6 +1561,7 @@ done_set_intf:memcpy (req->buf, buf, n); req->complete = rndis_response_complete;rndis_free_response (dev->rndis_config, buf); + value = n; }/* else stalls ... spec says to avoid that */ }
drivers/usb/serial/usb-serial.c +2 -0
@@ -844,6 +844,7 @@ int usb_serial_probe(struct usb_interface *interface, serial->num_interrupt_in = num_interrupt_in; serial->num_interrupt_out = num_interrupt_out; +#if 0 /* check that the device meets the driver's requirements */ if ((type->num_interrupt_in !=NUM_DONT_CARE && type->num_interrupt_in != num_interrupt_in)
@@ -857,6 +858,7 @@ int usb_serial_probe(struct usb_interface *interface,kfree (serial);return -EIO ; } +#endif /* found all that we need */ dev_info(&interface->dev, "%s converter detected\n",
fs/dnotify.c +11 -0
@@ -20,6 +20,7 @@#include <linux/init.h> #include <linux/spinlock.h> #include <linux/slab.h> +#include <linux/file.h> int dir_notify_enable__read_mostly =1 ;
@@ -66,6 +67,7 @@ int fcntl_dirnotify(int fd, struct file *filp, unsigned long arg)struct dnotify_struct **prev;struct inode *inode;fl_owner_t id = current->files; +struct file *f;int error =0 ;if ((arg & ~DN_MULTISHOT ) ==0 ) {
@@ -92,6 +94,15 @@ int fcntl_dirnotify(int fd, struct file *filp, unsigned long arg) prev = &odn->dn_next; } +rcu_read_lock (); + f =fcheck (fd); +rcu_read_unlock (); +/* we'd lost the race with close(), sod off silently */ +/* note that inode->i_lock prevents reordering problems +* between accesses to descriptor table and ->i_dnotify */ +if (f != filp) + goto out_free; + error =__f_setown (filp,task_pid (current),PIDTYPE_PID ,0 );if (error) goto out_free;
fs/jffs2/erase.c +8 -10
@@ -419,9 +419,6 @@ static void jffs2_mark_erased_block(struct jffs2_sb_info *c, struct jffs2_erasebif (jffs2_write_nand_cleanmarker (c, jeb)) goto filebad; } - -/* Everything else got zeroed before the erase */ - jeb->free_size = c->sector_size; }else {struct kvec vecs[1 ];
@@ -449,18 +446,19 @@ static void jffs2_mark_erased_block(struct jffs2_sb_info *c, struct jffs2_eraseb goto filebad; } - -/* Everything else got zeroed before the erase */ - jeb->free_size = c->sector_size; -/* FIXME Special case for cleanmarker in empty block */ -jffs2_link_node_ref (c, jeb, jeb->offset |REF_NORMAL , c->cleanmarker_size,NULL ); } +/* Everything else got zeroed before the erase */ + jeb->free_size = c->sector_size;down (&c->erase_free_sem);spin_lock (&c->erase_completion_lock); + c->erasing_size -= c->sector_size; - c->free_size += jeb->free_size; - c->used_size += jeb->used_size; + c->free_size += c->sector_size; + +/* Account for cleanmarker now, if it's in-band */ +if (c->cleanmarker_size && !jffs2_cleanmarker_oob (c)) +jffs2_link_node_ref (c, jeb, jeb->offset |REF_NORMAL , c->cleanmarker_size,NULL );jffs2_dbg_acct_sanity_check_nolock (c,jeb);jffs2_dbg_acct_paranoia_check_nolock (c, jeb);
fs/splice.c +1 -1
@@ -314,7 +314,7 @@ __generic_file_splice_read(struct file *in, loff_t *ppos,break ; error =add_to_page_cache_lru (page, mapping, index, -GFP_KERNEL ); +mapping_gfp_mask (mapping));if (unlikely (error)) {page_cache_release (page);if (error == -EEXIST )
include/net/tcp.h +5 -2
@@ -775,11 +775,14 @@ extern void tcp_enter_cwr(struct sock *sk, const int set_ssthresh);extern __u32 tcp_init_cwnd (struct tcp_sock *tp,struct dst_entry *dst);/* Slow start with delack produces 3 packets of burst, so that -* it is safe "de facto". +* it is safe "de facto". This will be the default - same as +* the default reordering threshold - but if reordering increases, +* we must be able to allow cwnd to burst at least this much in order +* to not pull it back when holes are filled. */ static __inline____u32 tcp_max_burst (const struct tcp_sock *tp) { -return 3 ; +return tp->reordering; }/* RFC2861 Check whether we are limited by application or congestion window