rt2x00: build fix
x86.git testing found the following build failure on latest -git:
Building modules, stage 2.
MODPOST 332 modules
ERROR: "led_classdev_unregister" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
ERROR: "led_classdev_resume" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
ERROR: "led_classdev_register" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
ERROR: "led_classdev_suspend" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined! make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
config can be found at:
http://redhat.com/~mingo/misc/config-Sat_May__3_13_24_19_CEST_2008.bad
the patch here is just a quick workaround for now for my test-setup, it makes the leds features in this driver depend on NEW_LEDS. Have not checked how far away this is from the real fix. Hm, and i think think i sent another patch for a similar build failure a week ago already - did i miss some patch to try?
Ingo
--- drivers/net/wireless/rt2x00/Kconfig | 5 +++++ 1 file changed, 5 insertions(+)
drivers/net/wireless/rt2x00/Kconfig +5 -0
@@ -61,6 +61,7 @@ config RT2400PCI_RFKILL config RT2400PCI_LEDS bool "RT2400 leds support" depends on RT2400PCI + depends on NEW_LEDS select LEDS_CLASS select RT2X00_LIB_LEDS ---help---
@@ -88,6 +89,7 @@ config RT2500PCI_RFKILL config RT2500PCI_LEDS bool "RT2500 leds support" depends on RT2500PCI + depends on NEW_LEDS select LEDS_CLASS select RT2X00_LIB_LEDS ---help---
@@ -117,6 +119,7 @@ config RT61PCI_RFKILL config RT61PCI_LEDS bool "RT61 leds support" depends on RT61PCI + depends on NEW_LEDS select LEDS_CLASS select RT2X00_LIB_LEDS ---help---
@@ -134,6 +137,7 @@ config RT2500USB config RT2500USB_LEDS bool "RT2500 leds support" depends on RT2500USB + depends on NEW_LEDS select LEDS_CLASS select RT2X00_LIB_LEDS ---help---
@@ -153,6 +157,7 @@ config RT73USB config RT73USB_LEDS bool "RT73 leds support" depends on RT73USB + depends on NEW_LEDS select LEDS_CLASS select RT2X00_LIB_LEDS ---help---
Quoted 14 lines · Ingo Molnar
x86.git testing found the following build failure on latest -git:
Building modules, stage 2.
MODPOST 332 modules
ERROR: "led_classdev_unregister" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
ERROR: "led_classdev_resume" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
ERROR: "led_classdev_register" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
ERROR: "led_classdev_suspend" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined! make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2config can be found at:
Quoted 7 lines
http://redhat.com/~mingo/misc/config-Sat_May__3_13_24_19_CEST_2008.bad
the patch here is just a quick workaround for now for my test-setup, it makes the leds features in this driver depend on
NEW_LEDS. Have not checked how far away this is from the real fix. Hm, and i think think i sent another patch for a similar build failure a week ago already - did i miss some patch to try?
Well there seems to be a big dependency mess with the LED class handlers, selecting the required options fail due to dependencies in the LED class handler, but depending on the options fail because of "compiled in" vs "compiled as module" problems...
Quoted 51 lines
Ingo
--- drivers/net/wireless/rt2x00/Kconfig | 5 +++++ 1 file changed, 5 insertions(+)Index: linux/drivers/net/wireless/rt2x00/Kconfig
===================================================================drivers/net/wireless/rt2x00/Kconfig +5
-0@@ -61,6 +61,7 @@ config RT2400PCI_RFKILL config RT2400PCI_LEDS bool "RT2400 leds support" depends on RT2400PCI + depends on NEW_LEDS select LEDS_CLASS select RT2X00_LIB_LEDS ---help---@@ -88,6 +89,7 @@ config RT2500PCI_RFKILL config RT2500PCI_LEDS bool "RT2500 leds support" depends on RT2500PCI + depends on NEW_LEDS select LEDS_CLASS select RT2X00_LIB_LEDS ---help---@@ -117,6 +119,7 @@ config RT61PCI_RFKILL config RT61PCI_LEDS bool "RT61 leds support" depends on RT61PCI + depends on NEW_LEDS select LEDS_CLASS select RT2X00_LIB_LEDS ---help---@@ -134,6 +137,7 @@ config RT2500USB config RT2500USB_LEDS bool "RT2500 leds support" depends on RT2500USB + depends on NEW_LEDS select LEDS_CLASS select RT2X00_LIB_LEDS ---help---@@ -153,6 +157,7 @@ config RT73USB config RT73USB_LEDS bool "RT73 leds support" depends on RT73USB + depends on NEW_LEDS select LEDS_CLASS select RT2X00_LIB_LEDS ---help---
Quoted 14 lines · Ingo Molnar
x86.git testing found the following build failure on latest -git:
Building modules, stage 2.
MODPOST 332 modules
ERROR: "led_classdev_unregister" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
ERROR: "led_classdev_resume" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
ERROR: "led_classdev_register" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
ERROR: "led_classdev_suspend" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined! make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2config can be found at:
Quoted 7 lines
http://redhat.com/~mingo/misc/config-Sat_May__3_13_24_19_CEST_2008.bad
the patch here is just a quick workaround for now for my test-setup, it makes the leds features in this driver depend on
NEW_LEDS. Have not checked how far away this is from the real fix. Hm, and i think think i sent another patch for a similar build failure a week ago already - did i miss some patch to try?
You missed Roman's patch two days ago, that was in response to a similar report you sent, and that will also fix this issue.
Quoted 2 lines
Ingo
...
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed