Skip to contentSkip to conversation

MMC: Fix omap compile by replacing dev_name with dma_dev_name

PATCH Applied Tony Lindgren 2 participants 2 messages May 6, 2008 – May 14, 2008

Subsystems (2)
MMC, SD and SDIO OMAP MMC support
lore
Share & tools
lore

Tony Lindgren

author
#0 lore raw

PATCH 1/1 MMC: Fix omap compile by replacing dev_name with dma_dev_name

Hi Pierre,

Here's a fix to make omap.c compile again because of a name conflict introduced by 3efcdd76c4906236f9043c8b34837818177b291d.

Regards,

Tony

Quoted 1 line

From 3efcdd76c4906236f9043c8b34837818177b291d Mon Sep 17 00:00:00 2001

From: Tony Lindgren <[email protected]>
Date: Tue, 6 May 2008 16:06:06 -0700
Subject: [PATCH] MMC: Fix omap compile by replacing dev_name with dma_dev_name

This patch fixes error:

drivers/mmc/host/omap.c: In function 'mmc_omap_get_dma_channel':
drivers/mmc/host/omap.c:1038: error: called object 'dev_name' is not a function

Commit 06916639e2fed9ee475efef2747a1b7429f8fe76 adds a function called dev_name. This will cause a name conflict as dev_dbg calls dev_name(((host->mmc)->parent)).

This same issue should not affect other drivers as they don't seem to use dev_name with dev_dbg.

Thanks to Paul Walmsley <[email protected]> for figuring this one out.

Cc Paul Walmsley <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
drivers/mmc/host/omap.c +6 -6
index 14759e9..549517c 100644
@@ -1003,7 +1003,7 @@ static void mmc_omap_dma_cb(int lch, u16 ch_status, void *data)
 
 static int mmc_omap_get_dma_channel(struct mmc_omap_host *host, struct mmc_data *data)
 {
-	const char *dev_name;
+	const char *dma_dev_name;
 	int sync_dev, dma_ch, is_read, r;
 
 	is_read = !(data->flags & MMC_DATA_WRITE);

@@ -1018,21 +1018,21 @@ static int mmc_omap_get_dma_channel(struct mmc_omap_host *host, struct mmc_data
 	if (is_read) {
 		if (host->id == 1) {
 			sync_dev = OMAP_DMA_MMC_RX;
-			dev_name = "MMC1 read";
+			dma_dev_name = "MMC1 read";
 		} else {
 			sync_dev = OMAP_DMA_MMC2_RX;
-			dev_name = "MMC2 read";
+			dma_dev_name = "MMC2 read";
 		}
 	} else {
 		if (host->id == 1) {
 			sync_dev = OMAP_DMA_MMC_TX;
-			dev_name = "MMC1 write";
+			dma_dev_name = "MMC1 write";
 		} else {
 			sync_dev = OMAP_DMA_MMC2_TX;
-			dev_name = "MMC2 write";
+			dma_dev_name = "MMC2 write";
 		}
 	}
-	r = omap_request_dma(sync_dev, dev_name, mmc_omap_dma_cb,
+	r = omap_request_dma(sync_dev, dma_dev_name, mmc_omap_dma_cb,
 			     host, &dma_ch);
 	if (r != 0) {
 		dev_dbg(mmc_dev(host->mmc), "omap_request_dma() failed with %d\n", r);
Applied
#1 lore raw
Quoted 8 lines · On Tue, 6 May 2008 16:36:47 -0700 Tony Lindgren <[email protected]> wrote:

Hi Pierre,

Here's a fix to make omap.c compile again because of a name conflict introduced by 3efcdd76c4906236f9043c8b34837818177b291d.

Regards,

Tony

applied, thanks

Signature · 4 lines
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org