Skip to contentSkip to conversation

PATCH] Replace a printk + WARN_ON() to a WARN()

PATCH Arjan van de Ven 1 participant 1 message May 20, 2008 IRQ

lore
Share & tools
lore
#0 lore raw

From: Arjan van de Ven <[email protected]>
Subject: [PATCH] Replace a printk + WARN_ON() to a WARN()

Replace a printk+WARN_ON() by a WARN(); this increases the chance of the string making it into the bugreport (eg it goes inside the ---[ cute here ]--- section)

---
 kernel/irq/manage.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
kernel/irq/manage.c +1 -3
index 46d6611..e296f67 100644
@@ -224,9 +224,7 @@ int set_irq_wake(unsigned int irq, unsigned int on)
 			set_wake = NULL;
 	} else {
 		if (desc->wake_depth == 0) {
-			printk(KERN_WARNING "Unbalanced IRQ %d "
-					"wake disable\n", irq);
-			WARN_ON(1);
+			WARN(1, "Unbalanced IRQ %d wake disable\n", irq);
 		} else if (--desc->wake_depth == 0)
 			desc->status &= ~IRQ_WAKEUP;
 		else
Signature · 1 line
1.5.4.5