Skip to contentSkip to conversation

debug printk infrastructure -compile fixes

PATCH In review Jason Baron 2 participants 2 messages May 22, 2008 – May 27, 2008

Subsystems (2)
Networking netfilter
lore
Share & tools
lore

Jason Baron

author
#0 lore raw

PATCH 3/8 debug printk infrastructure -compile fixes

Signed-off-by Jason Baron <[email protected]>
---
 net/netfilter/nf_conntrack_pptp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/netfilter/nf_conntrack_pptp.c +1 -1
index 97e54b0..7fea304 100644
@@ -65,7 +65,7 @@ void
 			     struct nf_conntrack_expect *exp) __read_mostly;
 EXPORT_SYMBOL_GPL(nf_nat_pptp_hook_expectfn);
 
-#ifdef DEBUG
+#if defined(DEBUG) || defined(CONFIG_DYNAMIC_PRINTK_DEBUG)
 /* PptpControlMessageType names */
 const char *const pptp_msg_name[] = {
 	"UNKNOWN_MESSAGE",
Signature · 1 line
1.5.4.5
#1 lore raw
Quoted 11 lines · On Thu, 22 May 2008 17:16:39 -0400 Jason Baron <[email protected]> wrote:
Signed-off-by Jason Baron <[email protected]>
---
 net/netfilter/nf_conntrack_pptp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/netfilter/nf_conntrack_pptp.c +0 -0
index 97e54b0..7fea304 100644

net/netfilter/nf_conntrack_pptp.c void · line 71

Quoted 8 lines
net/netfilter/nf_conntrack_pptp.c +1 -1
@@ -65,7 +65,7 @@ void
 			     struct nf_conntrack_expect *exp) __read_mostly;
 EXPORT_SYMBOL_GPL(nf_nat_pptp_hook_expectfn);
 
-#ifdef DEBUG
+#if defined(DEBUG) || defined(CONFIG_DYNAMIC_PRINTK_DEBUG)
 /* PptpControlMessageType names */
 const char *const pptp_msg_name[] = {
 	"UNKNOWN_MESSAGE",

Does this imply that the patch series will break bisectability? If so, this fix should be merged into whichever patch introduces the build breakage.