i2c: Add support for virtual I2C adapters
PATCH 1/1 i2c: Add support for virtual I2C adapters
Hello,
I'd like to know why the patches at:
http://lists.linuxcoding.com/kernel/2006-q1/msg32516.html
have never been applied to the main kernel tree.
I'd like to use them and maybe I can update them to the latest kernel version for submission. :)
Ciao,
Rodolfo
Signature · 4 lines
GNU/Linux Solutions e-mail: giometti-AVVDYK/kqiJWk0Htik3J/[email protected] Linux Device Driver [email protected] Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
Quoted 10 lines · Rodolfo Giometti
Hello,
I'd like to know why the patches at:
http://lists.linuxcoding.com/kernel/2006-q1/msg32516.htmlhave never been applied to the main kernel tree.
I'd like to use them and maybe I can update them to the latest kernel version for submission. :)
Personally, a quick check over shows that I think there are not bad, and would have a review of it myself (although this is probably not totally under my portion of maintainership).
Have you tried contacting the original authour and seeing if it can be resubmitted?
Signature · 8 lines
Ben ([email protected], http://www.fluff.org/) 'a smiley only costs 4 bytes' _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
Hi Rodolfo,
Quoted 5 lines · Rodolfo Giometti
I'd like to know why the patches at:
http://lists.linuxcoding.com/kernel/2006-q1/msg32516.htmlhave never been applied to the main kernel tree.
There are two main reasons:
1* Nobody reviewed the patches in question. I don't even remember seeing test reports about these patches, but this could as well be my defective memory. A patch affecting i2c-core definitely needs good review and testing before it can go upstream.
2* When this patch was sent, the i2c subsystem was still using the legacy model where device drivers have to probe for and instantiate their devices themselves. This model is fundamentally incompatible with a generic for of I2C multiplexing support. So I didn't pay too much attention to attempts to support multiplexing of i2c adapters because I suspected it would be ugly at best. Now that we have new-style i2c device/driver binding which follows the device driver model, it's probably the right time to think about multiplexing support again.
Another reason, I guess, is that I do not have any system with a multiplexed I2C bus myself, so I can't test the code and I also lack personal motivation to push this forward.
There are still some cleanups needed in i2c-core, most notably with respect to duplication and locking, and ideally I'd like to see it done before we add multiplexing support, but admittedly there is no roadmap so I can't make this a mandatory requirement.
Quoted 2 lines
I'd like to use them and maybe I can update them to the latest kernel version for submission. :)
You are welcome to update and resubmit the patch, however I suspect that what is needed is more than that. The code was written with the legacy model in mind, while we want to support primarily (and maybe even exclusively) the new-style binding model.
Signature · 6 lines
Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
Quoted 9 lines · Ben Dooks
Quoted 8 lines · Rodolfo Giometti
Hello,
I'd like to know why the patches at:
http://lists.linuxcoding.com/kernel/2006-q1/msg32516.htmlhave never been applied to the main kernel tree.
Quoted 7 lines
Quoted 2 lines
I'd like to use them and maybe I can update them to the latest kernel version for submission. :)
Personally, a quick check over shows that I think there are not bad, and would have a review of it myself (although this is probably not totally under my portion of maintainership).
I've already done it and I'm testing it just right now. :)
If you wish I can submit a pre-patch.
Quoted 2 lines
Have you tried contacting the original authour and seeing if it can be resubmitted?
Yes, several days ago, but I got no answers. :'(
Ciao,
Rodolfo
Signature · 4 lines
GNU/Linux Solutions e-mail: giometti-AVVDYK/kqiJWk0Htik3J/[email protected] Linux Device Driver [email protected] Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c