Skip to contentSkip to conversation

electra_cf: Add MODULE_DEVICE_TABLE()

PATCH In review Olof Johansson 2 participants 3 messages May 29, 2008 – May 30, 2008 Pcmcia

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 electra_cf: Add MODULE_DEVICE_TABLE()

electra_cf: Add MODULE_DEVICE_TABLE()

Add a module device table to electra_cf so that modules can be auto-probed/loaded.

[will be included in git pull request later today]

drivers/pcmcia/electra_cf.c +1 -0
index 0a6cea1..52d0aa8 100644
@@ -352,6 +352,7 @@ static struct of_device_id electra_cf_match[] = {
 	},
 	{},
 };
+MODULE_DEVICE_TABLE(of, electra_cf_match);
 
 static struct of_platform_driver electra_cf_driver = {
 	.name	   = (char *)driver_name,
#1 lore raw

Hi Olof,

Quoted 7 lines · On Thu, 29 May 2008 15:05:44 -0500 Olof Johansson <[email protected]> wrote:

electra_cf: Add MODULE_DEVICE_TABLE()

Add a module device table to electra_cf so that modules can be auto-probed/loaded.

[will be included in git pull request later today]

No Signed-off-by?

drivers/pcmcia/electra_cf.c static struct of_device_id electra_cf_match[] = {

Quoted 5 lines
drivers/pcmcia/electra_cf.c +0 -0
index 0a6cea1..52d0aa8 100644
@@ -352,6 +352,7 @@ static struct of_device_id electra_cf_match[] = {

While you are here, want to make that const?

Signature · 3 lines
Cheers,
Stephen Rothwell                    [email protected]
http://www.canb.auug.org.au/~sfr/
#2 lore raw

Hi,

Quoted 10 lines · Stephen Rothwell
Quoted 7 lines · On Thu, 29 May 2008 15:05:44 -0500 Olof Johansson <[email protected]> wrote:

electra_cf: Add MODULE_DEVICE_TABLE()

Add a module device table to electra_cf so that modules can be auto-probed/loaded.

[will be included in git pull request later today]

No Signed-off-by?

It's signed off in my git tree, I normally remove the s-o-b on the postings to avoid having to rebase if Paul picks it up by mistake from patchwork instead. Kumar usually does that as well.

Quoted 7 lines

drivers/pcmcia/electra_cf.c static struct of_device_id electra_cf_match[] = {

Quoted 5 lines
drivers/pcmcia/electra_cf.c +0 -0
index 0a6cea1..52d0aa8 100644
@@ -352,6 +352,7 @@ static struct of_device_id electra_cf_match[] = {

While you are here, want to make that const?

I'll do that for .27, thanks for pointing it out.

-Olof