Skip to contentSkip to conversation

signals: do_signal_stop: kill the SIGNAL_UNKILLABLE check

PATCH In review Oleg Nesterov 2 participants 2 messages May 31, 2008 – Jun 3, 2008

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 signals: do_signal_stop: kill the SIGNAL_UNKILLABLE check

fae5fa44f1fd079ffbed8e0add929dd7bbd1347f changed do_signal_stop() to check SIGNAL_UNKILLABLE, this wasn't needed. If signal_group_exit() == F, the signal sent to SIGNAL_UNKILLABLE task must be already filtered out by the caller, get_signal_to_deliver(). And if signal_group_exit() == T we are not going to stop.

kernel/signal.c renamed from kernel/signal.c~2_DSS_KILL_UNKILLABLE_CHECK +1 -2
@@ -1649,8 +1649,7 @@ static int do_signal_stop(int signr)
 	} else {
 		struct task_struct *t;
 
-		if (unlikely((sig->flags & (SIGNAL_STOP_DEQUEUED | SIGNAL_UNKILLABLE))
-					 != SIGNAL_STOP_DEQUEUED) ||
+		if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) ||
 		    unlikely(signal_group_exit(sig)))
 			return 0;
 		/*