RFC [PATCH] x86: make generic arch support NUMAQ
so it could fallback to normal numa.
also decouple genericarch numa with acpi.
arch/x86/Kconfig +6 -6
@@ -310,12 +310,12 @@ config X86_VISWS and vice versa. See <file:Documentation/sgi-visws.txt> for details. config X86_GENERICARCH - bool "Generic architecture (Summit, bigsmp, ES7000, default)" + bool "Generic architecture (NUMAQ, Summit, bigsmp, ES7000, default)" depends on X86_32 help - This option compiles in the Summit, bigsmp, ES7000, default subarchitectures. - It is intended for a generic binary kernel. - If you want a NUMA kernel, select ACPI. We need SRAT for NUMA. + This option compiles in the NUMAQ, Summit, bigsmp, ES7000, default + subarchitectures. It is intended for a generic binary kernel. + You need enable NUMA, otherwise NUMAQ is skipped. config X86_ES7000 bool "Support for Unisys ES7000 IA32 series"
@@ -911,9 +911,9 @@ config X86_PAE config NUMA bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)" depends on SMP - depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI) && EXPERIMENTAL) + depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || X86_SUMMIT && ACPI) && EXPERIMENTAL) default n if X86_PC - default y if (X86_NUMAQ || X86_SUMMIT) + default y if (X86_NUMAQ || X86_SUMMIT || X86_GENERICARCH) help Enable NUMA (Non Uniform Memory Access) support. The kernel will try to allocate memory used by a CPU on the
arch/x86/boot/compressed/misc.c +1 -1
@@ -217,7 +217,7 @@ static char *vidmem;static int vidport;static int lines, cols; -#ifdef CONFIG_X86_NUMAQ +#if defined(CONFIG_X86_NUMAQ ) || defined(CONFIG_X86_GENERICARCH )void *xquad_portio;#endif
arch/x86/kernel/Makefile +9 -1
@@ -67,7 +67,15 @@ obj-$(CONFIG_DYNAMIC_FTRACE) += ftrace.o obj-$(CONFIG_KEXEC) += machine_kexec_$(BITS).o obj-$(CONFIG_KEXEC) += relocate_kernel_$(BITS).o crash.o obj-$(CONFIG_CRASH_DUMP) += crash_dump_$(BITS).o -obj-$(CONFIG_X86_NUMAQ) += numaq_32.o + +ifeq ($(CONFIG_X86_NUMAQ), y) +obj-y += numaq_32.o +else +ifeq ($(CONFIG_X86_GENERICARCH), y) +obj-$(CONFIG_NUMA) += numaq_32.o +endif +endif + obj-$(CONFIG_X86_SUMMIT_NUMA) += summit_32.o obj-y += vsmp_64.o obj-$(CONFIG_KPROBES) += kprobes.o
arch/x86/kernel/io_apic_32.c +5 -4
@@ -1715,7 +1715,6 @@ void disable_IO_APIC(void)* by Matt Domsch <[email protected]> Tue Dec 21 12:25:05 CST 1999 */ -#ifndef CONFIG_X86_NUMAQ static void __init setup_ioapic_ids_from_mpc (void ) {union IO_APIC_reg_00 reg_00;
@@ -1725,6 +1724,11 @@ static void __init setup_ioapic_ids_from_mpc(void)unsigned char old_id;unsigned long flags; +#if defined(CONFIG_X86_NUMAQ ) || defined(CONFIG_X86_GENERICARCH ) +if (found_numaq) +return ; +#endif +/* * Don't check I/O APIC IDs for xAPIC systems. They have * no meaning without the serial APIC bus.
@@ -1821,9 +1825,6 @@ static void __init setup_ioapic_ids_from_mpc(void)apic_printk (APIC_VERBOSE ," ok.\n" ); } } -#else -static void __init setup_ioapic_ids_from_mpc (void ) { } -#endif int no_timer_check__initdata ;
arch/x86/kernel/mpparse.c +66 -8
131 lines not on this page · raw message
arch/x86/kernel/nmi.c +0 -2
@@ -94,7 +94,6 @@ static inline unsigned int get_timer_irqs(int cpu)#endif } -#ifdef CONFIG_X86_64 /* Run after command line and cpu_init init, but before all other checks */ void nmi_watchdog_default (void ) {
@@ -102,7 +101,6 @@ void nmi_watchdog_default(void)return ; nmi_watchdog =NMI_NONE ; } -#endif #ifdef CONFIG_SMP /*
arch/x86/kernel/numaq_32.c +0 -12
@@ -36,8 +36,6 @@#define MB_TO_PAGES (addr) ((addr) << (20 - PAGE_SHIFT)) -int found_numaq; -/* * Function: smp_dump_qct() *
@@ -105,13 +103,3 @@ static int __init numaq_tsc_disable(void) }arch_initcall (numaq_tsc_disable); -#ifdef CONFIG_ACPI -/* -* Dummy implementation: -*/ -struct pci_bus *__devinit -pci_acpi_scan_root (struct acpi_device *device,int domain,int busnum) -{ -return NULL ; -} -#endif
arch/x86/mach-generic/Makefile +1 -0
@@ -5,4 +5,5 @@ EXTRA_CFLAGS := -Iarch/x86/kernel obj-y := probe.o summit.o bigsmp.o es7000.o default.o +obj-$(CONFIG_NUMA) += numaq.o obj-y += ../../x86/mach-es7000/
arch/x86/mach-generic/probe.c +6 -0
@@ -16,6 +16,9 @@#include <asm/apicdef.h> #include <asm/genapic.h> +#ifdef CONFIG_NUMA +extern struct genapic apic_numaq; +#endif extern struct genapic apic_summit;extern struct genapic apic_bigsmp;extern struct genapic apic_es7000;
@@ -24,6 +27,9 @@ extern struct genapic apic_default;struct genapic *genapic = &apic_default;static struct genapic *apic_probe[]__initdata = { +#ifdef CONFIG_NUMA + &apic_numaq, +#endif &apic_summit, &apic_bigsmp, &apic_es7000,
arch/x86/pci/Makefile_32 +7 -1
@@ -16,7 +16,13 @@ pci-y += legacy.o irq.o # Careful: VISWS and NUMAQ overrule the pci-y above. The colons are # therefor correct. This needs a proper fix by distangling the code. pci-$(CONFIG_X86_VISWS) := visws.o fixup.o -pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o + +ifeq ($(CONFIG_X86_NUMAQ), y) +pci-y := numa.o irq.o +endif +ifeq ($(CONFIG_X86_GENERICARCH), y) +pci-y += numa.o +endif # Necessary for NUMAQ as well pci-$(CONFIG_NUMA) += mp_bus_to_node.o
arch/x86/pci/numa.c +4 -24
@@ -11,38 +11,18 @@#define XQUAD_PORTIO_BASE 0xfe400000#define XQUAD_PORTIO_QUAD 0x40000/* 256k per quad. */ -int mp_bus_id_to_node[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_node[MAX_MP_BUSSES ];#define BUS2QUAD (global) (mp_bus_id_to_node[global]) -int mp_bus_id_to_local[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_local[MAX_MP_BUSSES ];#define BUS2LOCAL (global) (mp_bus_id_to_local[global]) -void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - mp_bus_id_to_node[m->mpc_busid] = quad; - mp_bus_id_to_local[m->mpc_busid] = local; -printk (KERN_INFO "Bus #%d is %s (node %d)\n" , - m->mpc_busid, name, quad); -} - -int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ]; +extern int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ];#define QUADLOCAL2BUS (quad,local) (quad_local_to_mp_bus_id[quad][local]) -void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - quad_local_to_mp_bus_id[quad][local] = m->mpc_busid; -}/* Where the IO area was mapped on multiquad, always 0 otherwise */ void *xquad_portio; -#ifdef CONFIG_X86_NUMAQ +#if defined(CONFIG_X86_NUMAQ ) || defined(CONFIG_X86_GENERICARCH )EXPORT_SYMBOL (xquad_portio);#endif
include/asm-x86/mach-generic/mach_apic.h +1 -0
@@ -27,6 +27,7 @@#define enable_apic_mode (genapic->enable_apic_mode)#define phys_pkg_id (genapic->phys_pkg_id) +extern int found_numaq;extern void generic_bigsmp_probe (void );#endif /* __ASM_MACH_APIC_H */
include/asm-x86/mach-generic/mach_mpparse.h +0 -1
@@ -1,7 +1,6 @@#ifndef _MACH_MPPARSE_H#define _MACH_MPPARSE_H 1 -int mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid);int acpi_madt_oem_check (char *oem_id,char *oem_table_id);#endif
include/asm-x86/mach-numaq/mach_apic.h +8 -31
@@ -20,8 +20,14 @@ static inline cpumask_t target_cpus(void)#define INT_DELIVERY_MODE dest_LowestPrio#define INT_DEST_MODE 0/* physical delivery on LOCAL quad */ -#define check_apicid_used (bitmap, apicid) physid_isset(apicid, bitmap) -#define check_apicid_present (bit) physid_isset(bit, phys_cpu_present_map) +static inline unsigned long check_apicid_used (physid_mask_t bitmap,int apicid) +{ +return physid_isset (apicid, bitmap); +} +static inline unsigned long check_apicid_present (int bit) +{ +return physid_isset (bit, phys_cpu_present_map); +}#define apicid_cluster (apicid) (apicid & 0xF0)static inline int apic_id_registered (void )
@@ -77,11 +83,6 @@ static inline int cpu_present_to_apicid(int mps_cpu)return BAD_APICID ; } -static inline int generate_logical_apicid (int quad,int phys_apicid) -{ -return (quad <<4 ) + (phys_apicid ? phys_apicid <<1 :1 ); -} -static inline int apicid_to_node (int logical_apicid) {return logical_apicid >>4 ;
@@ -95,30 +96,6 @@ static inline physid_mask_t apicid_to_cpu_present(int logical_apicid)return physid_mask_of_physid (cpu +4 *node); } -struct mpc_config_translation { -unsigned char mpc_type; -unsigned char trans_len; -unsigned char trans_type; -unsigned char trans_quad; -unsigned char trans_global; -unsigned char trans_local; -unsigned short trans_reserved; -}; - -static inline int mpc_apic_id (struct mpc_config_processor *m, -struct mpc_config_translation *translation_record) -{ -int quad = translation_record->trans_quad; -int logical_apicid =generate_logical_apicid (quad, m->mpc_apicid); - -printk ("Processor #%d %u:%u APIC version %d (quad %d, apic %d)\n" , - m->mpc_apicid, - (m->mpc_cpufeature &CPU_FAMILY_MASK ) >>8 , - (m->mpc_cpufeature &CPU_MODEL_MASK ) >>4 , - m->mpc_apicver, quad, logical_apicid); -return logical_apicid; -} -extern void *xquad_portio;static inline void setup_portio_remap (void )
include/asm-x86/mach-numaq/mach_mpparse.h +0 -5
@@ -1,11 +1,6 @@#ifndef __ASM_MACH_MPPARSE_H#define __ASM_MACH_MPPARSE_H -extern void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation); -extern void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation); -/* Hook from generic ACPI tables.c */ static inline void acpi_madt_oem_check (char *oem_id,char *oem_table_id) {
include/asm-x86/mmzone_32.h +7 -9
@@ -12,9 +12,10 @@extern struct pglist_data *node_data[];#define NODE_DATA (nid) (node_data[nid]) -#ifdef CONFIG_X86_NUMAQ +#if defined(CONFIG_X86_NUMAQ ) || defined(CONFIG_X86_GENERICARCH )#include <asm/numaq.h> -#elif defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ +#endif +#if defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ #include <asm/srat.h> #endif
@@ -26,10 +27,12 @@ extern int get_memcfg_numa_flat(void);*/ static inline void get_memcfg_numa (void ) { -#ifdef CONFIG_X86_NUMAQ + +#if defined(CONFIG_X86_NUMAQ ) || defined(CONFIG_X86_GENERICARCH )if (get_memcfg_numaq ())return ; -#elif defined(CONFIG_ACPI_SRAT ) +#endif +#if defined(CONFIG_ACPI_SRAT )if (get_memcfg_from_srat ())return ;#endif
@@ -42,7 +45,6 @@ extern int early_pfn_to_nid(unsigned long pfn);#else /* !CONFIG_NUMA */ #define get_memcfg_numa get_memcfg_numa_flat -#define get_zholes_size (n) (0)#endif /* CONFIG_NUMA */
@@ -83,9 +85,6 @@ static inline int pfn_to_nid(unsigned long pfn) __pgdat->node_start_pfn + __pgdat->node_spanned_pages; \ }) -#ifdef CONFIG_X86_NUMAQ /* we have contiguous memory on NUMA-Q */ -#define pfn_valid (pfn) ((pfn) < num_physpages) -#else static inline int pfn_valid (int pfn) {int nid =pfn_to_nid (pfn);
@@ -94,7 +93,6 @@ static inline int pfn_valid(int pfn)return (pfn <node_end_pfn (nid)); return 0; } -#endif /* CONFIG_X86_NUMAQ */ #endif /* CONFIG_DISCONTIGMEM */
include/asm-x86/numaq.h +2 -6
@@ -26,7 +26,7 @@#ifndef NUMAQ_H #define NUMAQ_H -#ifdef CONFIG_X86_NUMAQ +#if defined(CONFIG_X86_NUMAQ ) || defined(CONFIG_X86_GENERICARCH )extern int found_numaq;extern int get_memcfg_numaq (void );
@@ -157,10 +157,6 @@ struct sys_cfg_data {struct eachquadmem eq[MAX_NUMNODES ];/* indexed by quad id */ }; -static inline unsigned long *get_zholes_size (int nid) -{ -return NULL ; -} -#endif /* CONFIG_X86_NUMAQ */ +#endif /* CONFIG_X86_NUMAQ || CONFIG_X86_GENERICARCH */ #endif /* NUMAQ_H */
include/asm-x86/srat.h +0 -1
@@ -32,6 +32,5 @@#endif extern int get_memcfg_from_srat (void ); -extern unsigned long *get_zholes_size (int );#endif /* _ASM_SRAT_H_ */
arch/x86/mach-generic/numaq.c new file +35 -0
@@ -0,0 +1,35 @@ +/* +* APIC driver for the IBM NUMAQ chipset. +*/ +#define APIC_DEFINITION 1 +#include <linux/threads.h> +#include <linux/cpumask.h> +#include <asm/smp.h> +#include <asm/mpspec.h> +#include <asm/genapic.h> +#include <asm/fixmap.h> +#include <asm/apicdef.h> +#include <linux/kernel.h> +#include <linux/string.h> +#include <linux/smp.h> +#include <linux/init.h> +#include <asm/mach-numaq/mach_apic.h> +#include <asm/mach-numaq/mach_apicdef.h> +#include <asm/mach-numaq/mach_ipi.h> +#include <asm/mach-numaq/mach_mpparse.h> +#include <asm/mach-numaq/mach_wakecpu.h> +#include <asm/numaq.h> + +static int mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid) +{ +return 0 ; +} + +static int probe_numaq (void ) +{ +/* already know from get_memcfg_numaq() */ +return found_numaq; +} + +struct genapic apic_numaq =APIC_INIT ("NUMAQ" , probe_numaq);
Hi Yinghai Lu.
Some random comments after skimming through the diff.
In general I like the simplification moving numaq. But there is too much ifdef going on - and it can be done better.
Part of this may belong in a followup patch - other parts should be addressed in this patch.
Quoted 1 line
+#if
defined(CONFIG_X86_NUMAQ)||defined(CONFIG_X86_GENERICARCH)
I counted several places where you test for the above. Introducing a CONFIG_X86_NUMAQ_OR_GENERIC would simplify stuff.
arch/x86/kernel/Makefile obj-$(CONFIG_DYNAMIC_FTRACE) += ftrace.o · line 77
Quoted 9 lines
arch/x86/kernel/Makefile +8
-1-obj-$(CONFIG_X86_NUMAQ) += numaq_32.o + +ifeq ($(CONFIG_X86_NUMAQ), y) +obj-y += numaq_32.o +else +ifeq ($(CONFIG_X86_GENERICARCH), y) +obj-$(CONFIG_NUMA) += numaq_32.o +endif +endif
Can we move these dependencies to Kconfig? It should looks roughtly like this in the Makefile:
obj-$(CONFIG_X86_NUMAQ) += numaq_32.o
obj-$(CONFIG_X86_NUMA_OR_GENERIC) += numaq_32.o
arch/x86/kernel/io_apic_32.c static void __init setup_ioapic_ids_from_mpc(void) · line 1730
Quoted 12 lines
arch/x86/kernel/io_apic_32.c +4
-1-#ifndef CONFIG_X86_NUMAQ static void __init setup_ioapic_ids_from_mpc (void ) {union IO_APIC_reg_00 reg_00;@@ -1725,6 +1724,11 @@ static void __init setup_ioapic_ids_from_mpc(void)unsigned char old_id;unsigned long flags; +#if defined(CONFIG_X86_NUMAQ ) || defined(CONFIG_X86_GENERICARCH ) +if (found_numaq) +return ; +#endif
This ifdef should be found in a .h file defining a simple inline. Then you could just do:
if (found_numaq()) return;
arch/x86/kernel/mpparse.c static int __init mpf_checksum(unsigned char *mp, int len) · line 95
Quoted 4 lines
arch/x86/kernel/mpparse.c +4
-0+ +int mp_bus_id_to_node[MAX_MP_BUSSES ]; + +int mp_bus_id_to_local[MAX_MP_BUSSES ];
static? and introduce helper functions with proper prototypes in a .h file?
arch/x86/mach-generic/probe.c line 21
Quoted 8 lines
arch/x86/mach-generic/probe.c +4
-0+++ b/arch/x86/mach-generic/probe.c@@ -16,6 +16,9 @@#include <asm/apicdef.h> #include <asm/genapic.h> +#ifdef CONFIG_NUMA +extern struct genapic apic_numaq; +#endif
No reason to use ifdef araound a extern.
Quoted 6 lines
arch/x86/pci/Makefile_32 +0
-0@@ -16,7 +16,13 @@ pci-y += legacy.o irq.o # Careful: VISWS and NUMAQ overrule the pci-y above. The colons are
arch/x86/pci/Makefile_32 pci-y += legacy.o irq.o · line 25
Quoted 10 lines
arch/x86/pci/Makefile_32 +7
-1# therefor correct. This needs a proper fix by distangling the code. pci-$(CONFIG_X86_VISWS) := visws.o fixup.o -pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o + +ifeq ($(CONFIG_X86_NUMAQ), y) +pci-y := numa.o irq.o +endif +ifeq ($(CONFIG_X86_GENERICARCH), y) +pci-y += numa.o +endif
Use:
pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o
pci-$(CONFIG_X86_GENERICARCH) += numa.o
Quoted 5 lines
arch/x86/pci/numa.c +0
-0
arch/x86/pci/numa.c line 18
Quoted 10 lines
arch/x86/pci/numa.c +2
-2@@ -11,38 +11,18 @@#define XQUAD_PORTIO_BASE 0xfe400000#define XQUAD_PORTIO_QUAD 0x40000/* 256k per quad. */ -int mp_bus_id_to_node[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_node[MAX_MP_BUSSES ];#define BUS2QUAD (global) (mp_bus_id_to_node[global]) -int mp_bus_id_to_local[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_local[MAX_MP_BUSSES ];#define BUS2LOCAL (global) (mp_bus_id_to_local[global])
Move extern to .h file and consider introducing a helper function.
Quoted 4 lines
include/asm-x86/mmzone_32.h +0
-0@@ -12,9 +12,10 @@extern struct pglist_data *node_data[];
include/asm-x86/mmzone_32.h line 20
Quoted 10 lines
include/asm-x86/mmzone_32.h +3
-2#define NODE_DATA (nid) (node_data[nid]) -#ifdef CONFIG_X86_NUMAQ +#if defined(CONFIG_X86_NUMAQ ) || defined(CONFIG_X86_GENERICARCH )#include <asm/numaq.h> -#elif defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ +#endif +#if defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ #include <asm/srat.h> #endif
Move ifdef to .h files.
If at all needed.
include/asm-x86/mmzone_32.h extern int get_memcfg_numa_flat(void); · line 38
Quoted 4 lines
include/asm-x86/mmzone_32.h +1
-0+#if defined(CONFIG_ACPI_SRAT )if (get_memcfg_from_srat ())return ;#endif
Create a dummy inline in a .h file for this function so we can drop the ifdef here.
Sam
Quoted 4 lines · Sam Ravnborg
Quoted 1 line
+#if
defined(CONFIG_X86_NUMAQ)||defined(CONFIG_X86_GENERICARCH)I counted several places where you test for the above. Introducing a
CONFIG_X86_NUMAQ_OR_GENERICwould simplify stuff.
Yinghai, please get rid of the NUMAQ build option altogether and eliminate the subarch.
We should keep a compatibility CONFIG_X86_NUMAQ that selects X86_GENERICARCH, so that 'make oldconfig' on a NUMAQ config does the right thing - but it's not a subarch anymore nor anything user-configurable.
All that together would be a very nice simplification.
Ingo
Quoted 127 lines · Sam Ravnborg
Hi Yinghai Lu.
Some random comments after skimming through the diff.
In general I like the simplification moving numaq. But there is too much ifdef going on - and it can be done better.
Part of this may belong in a followup patch - other parts should be addressed in this patch.Quoted 1 line
+#if
defined(CONFIG_X86_NUMAQ)||defined(CONFIG_X86_GENERICARCH)I counted several places where you test for the above. Introducing a
CONFIG_X86_NUMAQ_OR_GENERICwould simplify stuff.arch/x86/kernel/Makefile obj-$(CONFIG_DYNAMIC_FTRACE) += ftrace.o · line 77
Quoted 9 lines
arch/x86/kernel/Makefile +8
-1-obj-$(CONFIG_X86_NUMAQ) += numaq_32.o + +ifeq ($(CONFIG_X86_NUMAQ), y) +obj-y += numaq_32.o +else +ifeq ($(CONFIG_X86_GENERICARCH), y) +obj-$(CONFIG_NUMA) += numaq_32.o +endif +endifCan we move these dependencies to
Kconfig? It should looks roughtly like this in theMakefile:obj-$(CONFIG_X86_NUMAQ) += numaq_32.o
obj-$(CONFIG_X86_NUMA_OR_GENERIC) += numaq_32.oarch/x86/kernel/io_apic_32.c static void __init setup_ioapic_ids_from_mpc(void) · line 1730
Quoted 12 lines
arch/x86/kernel/io_apic_32.c +4
-1-#ifndef CONFIG_X86_NUMAQ static void __init setup_ioapic_ids_from_mpc (void ) {union IO_APIC_reg_00 reg_00;@@ -1725,6 +1724,11 @@ static void __init setup_ioapic_ids_from_mpc(void)unsigned char old_id;unsigned long flags; +#if defined(CONFIG_X86_NUMAQ ) || defined(CONFIG_X86_GENERICARCH ) +if (found_numaq) +return ; +#endif This ifdef should be found in a .h file defining a simple inline. Then you could just do:
if (found_numaq()) return;arch/x86/kernel/mpparse.c static int __init mpf_checksum(unsigned char *mp, int len) · line 95
Quoted 4 lines
arch/x86/kernel/mpparse.c +4
-0+ +int mp_bus_id_to_node[MAX_MP_BUSSES ]; + +int mp_bus_id_to_local[MAX_MP_BUSSES ];static? and introduce helper functions with proper prototypes in a .h file?
arch/x86/mach-generic/probe.c line 21
Quoted 8 lines
arch/x86/mach-generic/probe.c +4
-0+++ b/arch/x86/mach-generic/probe.c@@ -16,6 +16,9 @@#include <asm/apicdef.h> #include <asm/genapic.h> +#ifdef CONFIG_NUMA +extern struct genapic apic_numaq; +#endif No reason to use ifdef araound a extern.
Quoted 6 lines
arch/x86/pci/Makefile_32 +0
-0@@ -16,7 +16,13 @@ pci-y += legacy.o irq.o # Careful: VISWS and NUMAQ overrule the pci-y above. The colons arearch/x86/pci/Makefile_32 pci-y += legacy.o irq.o · line 25
Quoted 10 lines
arch/x86/pci/Makefile_32 +7
-1# therefor correct. This needs a proper fix by distangling the code. pci-$(CONFIG_X86_VISWS) := visws.o fixup.o -pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o + +ifeq ($(CONFIG_X86_NUMAQ), y) +pci-y := numa.o irq.o +endif +ifeq ($(CONFIG_X86_GENERICARCH), y) +pci-y += numa.o +endifUse:
pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o
pci-$(CONFIG_X86_GENERICARCH) += numa.oQuoted 5 lines
arch/x86/pci/numa.c +0
-0arch/x86/pci/numa.c line 18
Quoted 10 lines
arch/x86/pci/numa.c +2
-2@@ -11,38 +11,18 @@#define XQUAD_PORTIO_BASE 0xfe400000#define XQUAD_PORTIO_QUAD 0x40000/* 256k per quad. */ -int mp_bus_id_to_node[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_node[MAX_MP_BUSSES ];#define BUS2QUAD (global) (mp_bus_id_to_node[global]) -int mp_bus_id_to_local[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_local[MAX_MP_BUSSES ];#define BUS2LOCAL (global) (mp_bus_id_to_local[global])Move extern to .h file and consider introducing a helper function.
Quoted 4 lines
include/asm-x86/mmzone_32.h +0
-0@@ -12,9 +12,10 @@extern struct pglist_data *node_data[];include/asm-x86/mmzone_32.h line 20
Quoted 10 lines
include/asm-x86/mmzone_32.h +3
-2#define NODE_DATA (nid) (node_data[nid]) -#ifdef CONFIG_X86_NUMAQ +#if defined(CONFIG_X86_NUMAQ ) || defined(CONFIG_X86_GENERICARCH )#include <asm/numaq.h> -#elif defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ +#endif +#if defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ #include <asm/srat.h> #endif Move ifdef to .h files.
If at all needed.
Quoted 8 lines
include/asm-x86/mmzone_32.h extern int get_memcfg_numa_flat(void); · line 38
Quoted 4 lines
include/asm-x86/mmzone_32.h +1
-0+#if defined(CONFIG_ACPI_SRAT )if (get_memcfg_from_srat ())return ;#endif Create a dummy inline in a .h file for this function so we can drop the ifdef here.
Thanks, will check it.
YH
Quoted 8 lines · Ingo Molnar
Quoted 4 lines · Sam Ravnborg
Quoted 1 line
+#if
defined(CONFIG_X86_NUMAQ)||defined(CONFIG_X86_GENERICARCH)I counted several places where you test for the above. Introducing a
CONFIG_X86_NUMAQ_OR_GENERICwould simplify stuff.
Quoted 7 lines
Yinghai, please get rid of the NUMAQ build option altogether and eliminate the subarch.
We should keep a compatibility
CONFIG_X86_NUMAQthat selectsX86_GENERICARCH, so that 'make oldconfig' on a NUMAQ config does the right thing - but it's not a subarch anymore nor anything user-configurable.
how about the Summit, and ES7000? You still have the two entries for them.
Anyway, will remove entry in the list and make CONFIG_X86_NUMAQ select X86_GENERICARCH
and make the those ifdef only use X86_GENERICARCH...
YH
PATCH 1/1 x86: make generic arch support NUMAQ v2
In reply to Yinghai Luso it could fallback to normal numa.
NUMAQ depends on GENERICARCH
also decouple genericarch numa with acpi.
arch/x86/Kconfig +17 -17
@@ -264,17 +264,6 @@ config X86_VOYAGER If you do not specifically know you have a Voyager based machine, say N here, otherwise the kernel you build will not be bootable. -config X86_NUMAQ - bool "NUMAQ (IBM/Sequent)" - depends on SMP && X86_32 && PCI - select NUMA - help - This option is used for getting Linux to run on a (IBM/Sequent) NUMA - multiquad box. This changes the way that processors are bootstrapped, - and uses Clustered Logical APIC addressing mode instead of Flat Logical. - You will need a new lynxer.elf file to flash your firmware with - send - email to <[email protected]>. - config X86_SUMMIT bool "Summit/EXA (IBM x440)" depends on X86_32 && SMP
@@ -307,12 +296,12 @@ config X86_VISWS and vice versa. See <file:Documentation/sgi-visws.txt> for details. config X86_GENERICARCH - bool "Generic architecture (Summit, bigsmp, ES7000, default)" + bool "Generic architecture (NUMAQ, Summit, bigsmp, ES7000, default)" depends on X86_32 help - This option compiles in the Summit, bigsmp, ES7000, default subarchitectures. - It is intended for a generic binary kernel. - If you want a NUMA kernel, select ACPI. We need SRAT for NUMA. + This option compiles in the NUMAQ, Summit, bigsmp, ES7000, default + subarchitectures. It is intended for a generic binary kernel. + You need enable NUMA, otherwise NUMAQ is skipped. config X86_ES7000 bool "Support for Unisys ES7000 IA32 series"
@@ -348,6 +337,17 @@ config X86_VSMP endchoice +config X86_NUMAQ + bool "NUMAQ (IBM/Sequent)" + depends on SMP && X86_32 && PCI && X86_GENERICARCH + select NUMA + help + This option is used for getting Linux to run on a NUMAQ (IBM/Sequent) + NUMA multiquad box. This changes the way that processors are + bootstrapped, and uses Clustered Logical APIC addressing mode instead + of Flat Logical. You will need a new lynxer.elf file to flash your + firmware with - send email to <[email protected]>. + config SCHED_NO_NO_OMIT_FRAME_POINTER def_bool y prompt "Single-depth WCHAN output"
@@ -908,9 +908,9 @@ config X86_PAE config NUMA bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)" depends on SMP - depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI) && EXPERIMENTAL) + depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || X86_SUMMIT && ACPI) && EXPERIMENTAL) default n if X86_PC - default y if (X86_NUMAQ || X86_SUMMIT) + default y if (X86_NUMAQ || X86_SUMMIT || X86_GENERICARCH) help Enable NUMA (Non Uniform Memory Access) support. The kernel will try to allocate memory used by a CPU on the
arch/x86/kernel/io_apic_32.c +5 -4
@@ -1715,7 +1715,6 @@ void disable_IO_APIC(void)* by Matt Domsch <[email protected]> Tue Dec 21 12:25:05 CST 1999 */ -#ifndef CONFIG_X86_NUMAQ static void __init setup_ioapic_ids_from_mpc (void ) {union IO_APIC_reg_00 reg_00;
@@ -1725,6 +1724,11 @@ static void __init setup_ioapic_ids_fromunsigned char old_id;unsigned long flags; +#ifdef CONFIG_X86_NUMAQ +if (found_numaq) +return ; +#endif +/* * Don't check I/O APIC IDs for xAPIC systems. They have * no meaning without the serial APIC bus.
@@ -1821,9 +1825,6 @@ static void __init setup_ioapic_ids_fromapic_printk (APIC_VERBOSE ," ok.\n" ); } } -#else -static void __init setup_ioapic_ids_from_mpc (void ) { } -#endif int no_timer_check__initdata ;
arch/x86/kernel/mpparse.c +73 -3
112 lines not on this page · raw message
arch/x86/kernel/numaq_32.c +0 -12
@@ -36,8 +36,6 @@#define MB_TO_PAGES (addr) ((addr) << (20 - PAGE_SHIFT)) -int found_numaq; -/* * Function: smp_dump_qct() *
@@ -105,13 +103,3 @@ static int __init numaq_tsc_disable(void }arch_initcall (numaq_tsc_disable); -#ifdef CONFIG_ACPI -/* -* Dummy implementation: -*/ -struct pci_bus *__devinit -pci_acpi_scan_root (struct acpi_device *device,int domain,int busnum) -{ -return NULL ; -} -#endif
arch/x86/mach-generic/Makefile +4 -3
@@ -2,7 +2,8 @@ # Makefile for the generic architecture # -EXTRA_CFLAGS := -Iarch/x86/kernel +EXTRA_CFLAGS := -Iarch/x86/kernel -obj-y := probe.o summit.o bigsmp.o es7000.o default.o -obj-y += ../../x86/mach-es7000/ +obj-y := probe.o summit.o bigsmp.o es7000.o default.o +obj-$(CONFIG_X86_NUMAQ) += numaq.o +obj-y += ../../x86/mach-es7000/
arch/x86/mach-generic/probe.c +6 -1
@@ -16,6 +16,7 @@#include <asm/apicdef.h> #include <asm/genapic.h> +extern struct genapic apic_numaq;extern struct genapic apic_summit;extern struct genapic apic_bigsmp;extern struct genapic apic_es7000;
@@ -24,6 +25,9 @@ extern struct genapic apic_default;struct genapic *genapic = &apic_default;static struct genapic *apic_probe[]__initdata = { +#ifdef CONFIG_X86_NUMAQ + &apic_numaq, +#endif &apic_summit, &apic_bigsmp, &apic_es7000,
@@ -88,7 +92,8 @@ void __init generic_apic_probe(void)/* These functions can switch the APIC even after the initial ->probe() */ -int __init mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid) +int __init mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid) {int i;for (i =0 ; apic_probe[i]; ++i) {
arch/x86/pci/Makefile_32 +3 -2
@@ -13,10 +13,11 @@ pci-y := fixup.o pci-$(CONFIG_ACPI) += acpi.o pci-y += legacy.o irq.o -# Careful: VISWS and NUMAQ overrule the pci-y above. The colons are +# Careful: VISWS overrule the pci-y above. The colons are # therefor correct. This needs a proper fix by distangling the code. pci-$(CONFIG_X86_VISWS) := visws.o fixup.o -pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o + +pci-$(CONFIG_X86_NUMAQ) += numa.o # Necessary for NUMAQ as well pci-$(CONFIG_NUMA) += mp_bus_to_node.o
arch/x86/pci/numa.c +1 -25
@@ -6,45 +6,21 @@#include <linux/init.h> #include <linux/nodemask.h> #include <mach_apic.h> +#include <asm/mpspec.h> #include "pci.h" #define XQUAD_PORTIO_BASE 0xfe400000#define XQUAD_PORTIO_QUAD 0x40000/* 256k per quad. */ -int mp_bus_id_to_node[MAX_MP_BUSSES ];#define BUS2QUAD (global) (mp_bus_id_to_node[global]) -int mp_bus_id_to_local[MAX_MP_BUSSES ];#define BUS2LOCAL (global) (mp_bus_id_to_local[global]) -void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - mp_bus_id_to_node[m->mpc_busid] = quad; - mp_bus_id_to_local[m->mpc_busid] = local; -printk (KERN_INFO "Bus #%d is %s (node %d)\n" , - m->mpc_busid, name, quad); -} - -int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ];#define QUADLOCAL2BUS (quad,local) (quad_local_to_mp_bus_id[quad][local]) -void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - quad_local_to_mp_bus_id[quad][local] = m->mpc_busid; -}/* Where the IO area was mapped on multiquad, always 0 otherwise */ void *xquad_portio; -#ifdef CONFIG_X86_NUMAQ EXPORT_SYMBOL (xquad_portio); -#endif #define XQUAD_PORT_ADDR (port, quad) (xquad_portio + (XQUAD_PORTIO_QUAD*quad) + port)
include/asm-x86/mach-generic/mach_mpparse.h +5 -2
@@ -1,7 +1,10 @@#ifndef _MACH_MPPARSE_H#define _MACH_MPPARSE_H 1 -int mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid); -int acpi_madt_oem_check (char *oem_id,char *oem_table_id); + +extern int mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid); + +extern int acpi_madt_oem_check (char *oem_id,char *oem_table_id);#endif
include/asm-x86/mach-numaq/mach_apic.h +8 -31
@@ -20,8 +20,14 @@ static inline cpumask_t target_cpus(void#define INT_DELIVERY_MODE dest_LowestPrio#define INT_DEST_MODE 0/* physical delivery on LOCAL quad */ -#define check_apicid_used (bitmap, apicid) physid_isset(apicid, bitmap) -#define check_apicid_present (bit) physid_isset(bit, phys_cpu_present_map) +static inline unsigned long check_apicid_used (physid_mask_t bitmap,int apicid) +{ +return physid_isset (apicid, bitmap); +} +static inline unsigned long check_apicid_present (int bit) +{ +return physid_isset (bit, phys_cpu_present_map); +}#define apicid_cluster (apicid) (apicid & 0xF0)static inline int apic_id_registered (void )
@@ -77,11 +83,6 @@ static inline int cpu_present_to_apicid(return BAD_APICID ; } -static inline int generate_logical_apicid (int quad,int phys_apicid) -{ -return (quad <<4 ) + (phys_apicid ? phys_apicid <<1 :1 ); -} -static inline int apicid_to_node (int logical_apicid) {return logical_apicid >>4 ;
@@ -95,30 +96,6 @@ static inline physid_mask_t apicid_to_cpreturn physid_mask_of_physid (cpu +4 *node); } -struct mpc_config_translation { -unsigned char mpc_type; -unsigned char trans_len; -unsigned char trans_type; -unsigned char trans_quad; -unsigned char trans_global; -unsigned char trans_local; -unsigned short trans_reserved; -}; - -static inline int mpc_apic_id (struct mpc_config_processor *m, -struct mpc_config_translation *translation_record) -{ -int quad = translation_record->trans_quad; -int logical_apicid =generate_logical_apicid (quad, m->mpc_apicid); - -printk ("Processor #%d %u:%u APIC version %d (quad %d, apic %d)\n" , - m->mpc_apicid, - (m->mpc_cpufeature &CPU_FAMILY_MASK ) >>8 , - (m->mpc_cpufeature &CPU_MODEL_MASK ) >>4 , - m->mpc_apicver, quad, logical_apicid); -return logical_apicid; -} -extern void *xquad_portio;static inline void setup_portio_remap (void )
include/asm-x86/mach-numaq/mach_mpparse.h +2 -9
@@ -1,14 +1,7 @@#ifndef __ASM_MACH_MPPARSE_H#define __ASM_MACH_MPPARSE_H -extern void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation); -extern void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation); - -/* Hook from generic ACPI tables.c */ -static inline void acpi_madt_oem_check (char *oem_id,char *oem_table_id) -{ -} +extern void numaq_mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid);#endif /* __ASM_MACH_MPPARSE_H */
include/asm-x86/mmzone_32.h +4 -14
@@ -12,11 +12,9 @@extern struct pglist_data *node_data[];#define NODE_DATA (nid) (node_data[nid]) -#ifdef CONFIG_X86_NUMAQ -#include <asm/numaq.h> -#elif defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ -#include <asm/srat.h> -#endif +#include <asm/numaq.h> +/* summit or generic arch */ +#include <asm/srat.h> extern int get_memcfg_numa_flat (void );/*
@@ -26,14 +24,11 @@ extern int get_memcfg_numa_flat(void);*/ static inline void get_memcfg_numa (void ) { -#ifdef CONFIG_X86_NUMAQ +if (get_memcfg_numaq ())return ; -#elif defined(CONFIG_ACPI_SRAT )if (get_memcfg_from_srat ())return ; -#endif -get_memcfg_numa_flat (); }
@@ -42,7 +37,6 @@ extern int early_pfn_to_nid(unsigned lon#else /* !CONFIG_NUMA */ #define get_memcfg_numa get_memcfg_numa_flat -#define get_zholes_size (n) (0)#endif /* CONFIG_NUMA */
@@ -83,9 +77,6 @@ static inline int pfn_to_nid(unsigned lo __pgdat->node_start_pfn + __pgdat->node_spanned_pages; \ }) -#ifdef CONFIG_X86_NUMAQ /* we have contiguous memory on NUMA-Q */ -#define pfn_valid (pfn) ((pfn) < num_physpages) -#else static inline int pfn_valid (int pfn) {int nid =pfn_to_nid (pfn);
@@ -94,7 +85,6 @@ static inline int pfn_valid(int pfn)return (pfn <node_end_pfn (nid)); return 0; } -#endif /* CONFIG_X86_NUMAQ */ #endif /* CONFIG_DISCONTIGMEM */
include/asm-x86/numaq.h +3 -2
@@ -157,9 +157,10 @@ struct sys_cfg_data {struct eachquadmem eq[MAX_NUMNODES ];/* indexed by quad id */ }; -static inline unsigned long *get_zholes_size (int nid) +#else +static inline int get_memcfg_numaq (void ) { -return NULL ; +return 0 ; }#endif /* CONFIG_X86_NUMAQ */ #endif /* NUMAQ_H */
include/asm-x86/srat.h +7 -5
@@ -27,11 +27,13 @@#ifndef _ASM_SRAT_H_#define _ASM_SRAT_H_ -#ifndef CONFIG_ACPI_SRAT -#error CONFIG_ACPI_SRAT not defined, and srat.h header has been included -#endif - +#ifdef CONFIG_ACPI_SRAT extern int get_memcfg_from_srat (void ); -extern unsigned long *get_zholes_size (int ); +#else +static inline int get_memcfg_from_srat (void ) +{ +return 0 ; +} +#endif #endif /* _ASM_SRAT_H_ */
arch/x86/mach-generic/numaq.c new file +41 -0
41 lines not on this page · raw message
arch/x86/kernel/apic_32.c +1 -1
@@ -1528,7 +1528,7 @@ void __cpuinit generic_processor_info(in* if (CPU_HOTPLUG_ENABLED || num_processors > 8) * - Ashok Raj <[email protected]> */ -if (num_processors >8 ) { +if (apicid >8 ) {switch (boot_cpu_data.x86_vendor) {case X86_VENDOR_INTEL :if (!APIC_XAPIC (version)) {
arch/x86/mach-generic/bigsmp.c +1 -1
@@ -48,7 +48,7 @@ static const struct dmi_system_id bigsmpstatic int probe_bigsmp (void ) {if (def_to_bigsmp) - dmi_bigsmp =1 ; + dmi_bigsmp =1 ;else dmi_check_system (bigsmp_dmi_table);return dmi_bigsmp;
drivers/acpi/Kconfig +0 -1
@@ -4,7 +4,6 @@ menuconfig ACPI bool "ACPI (Advanced Configuration and Power Interface) Support" - depends on !X86_NUMAQ depends on !X86_VISWS depends on !IA64_HP_SIM depends on IA64 || X86
include/asm-x86/mpspec.h +6 -0
@@ -13,6 +13,12 @@ extern int apic_version[MAX_APICS];extern u8 apicid_2_node[];extern int pic_mode; +#ifdef CONFIG_X86_NUMAQ +extern int mp_bus_id_to_node[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_local[MAX_MP_BUSSES ]; +extern int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ]; +#endif +#define MAX_APICID 256#else
arch/x86/kernel/summit_32.c +2 -0
@@ -36,7 +36,9 @@ static struct rio_table_hdr *rio_table_hstatic struct scal_detail *scal_devs[MAX_NUMNODES ]__initdata ;static struct rio_detail *rio_devs[MAX_NUMNODES *4 ]__initdata ; +#ifndef CONFIG_X86_NUMAQ static int mp_bus_id_to_node[MAX_MP_BUSSES ]__initdata ; +#endif static int __init setup_pci_node_map_for_wpeg (int wpeg_num,int last_bus) {
Re: [PATCH] x86: make generic arch support NUMAQ v2
Quoted 68 lines · Yinghai Lu
so it could fallback to normal numa.
NUMAQ depends on GENERICARCH
also decouple genericarch numa with acpi.
Signed-off-by Yinghai Lu <[email protected]>Index: linux-2.6/arch/x86/Kconfig
===================================================================arch/x86/Kconfig +15
-15@@ -264,17 +264,6 @@ config X86_VOYAGER If you do not specifically know you have a Voyager based machine, say N here, otherwise the kernel you build will not be bootable. -config X86_NUMAQ - bool "NUMAQ (IBM/Sequent)" - depends on SMP && X86_32 && PCI - select NUMA - help - This option is used for getting Linux to run on a (IBM/Sequent) NUMA - multiquad box. This changes the way that processors are bootstrapped, - and uses Clustered Logical APIC addressing mode instead of Flat Logical. - You will need a new lynxer.elf file to flash your firmware with - send - email to <[email protected]>. - config X86_SUMMIT bool "Summit/EXA (IBM x440)" depends on X86_32 && SMP@@ -307,12 +296,12 @@ config X86_VISWS and vice versa. See <file:Documentation/sgi-visws.txt> for details. config X86_GENERICARCH - bool "Generic architecture (Summit, bigsmp, ES7000, default)" + bool "Generic architecture (NUMAQ, Summit, bigsmp, ES7000, default)" depends on X86_32 help - This option compiles in the Summit, bigsmp, ES7000, default subarchitectures. - It is intended for a generic binary kernel. - If you want a NUMA kernel, select ACPI. We need SRAT for NUMA. + This option compiles in the NUMAQ, Summit, bigsmp, ES7000, default + subarchitectures. It is intended for a generic binary kernel. + You need enable NUMA, otherwise NUMAQ is skipped. config X86_ES7000 bool "Support for Unisys ES7000 IA32 series"@@ -348,6 +337,17 @@ config X86_VSMP endchoice +config X86_NUMAQ + bool "NUMAQ (IBM/Sequent)" + depends on SMP && X86_32 && PCI && X86_GENERICARCH + select NUMA + help + This option is used for getting Linux to run on a NUMAQ (IBM/Sequent) + NUMA multiquad box. This changes the way that processors are + bootstrapped, and uses Clustered Logical APIC addressing mode instead + of Flat Logical. You will need a new lynxer.elf file to flash your + firmware with - send email to <[email protected]>. + config SCHED_NO_NO_OMIT_FRAME_POINTER def_bool y prompt "Single-depth WCHAN output"@@ -908,9 +908,9 @@ config X86_PAE config NUMA
arch/x86/Kconfig config X86_PAE · line 916
Quoted 10 lines
arch/x86/Kconfig +2
-2bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)" depends on SMP - depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI) && EXPERIMENTAL) + depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || X86_SUMMIT && ACPI) && EXPERIMENTAL) default n if X86_PC - default y if (X86_NUMAQ || X86_SUMMIT) + default y if (X86_NUMAQ || X86_SUMMIT || X86_GENERICARCH) help Enable NUMA (Non Uniform Memory Access) support. The kernel will try to allocate memory used by a CPU on the
Sam,
now NUMAQ depends on GENERICARCH.
and Ingo want to make oldconfig to migration NUMAQ....to select GENERICARCH...
but if i add select X86_GENERICARCH, make oldconfig will get
Quoted 1 line
make ARCH=i386 oldconfig
scripts/kconfig/conf -o arch/x86/Kconfig arch/x86/Kconfig:299:error: found recursive dependency:X86_GENERICARCH -> X86_NUMAQ -> X86_GENERICARCH -> <choice> make[1]: *** [oldconfig] Error 1
make: *** [oldconfig] Error 2
YH
Re: [PATCH] x86: make generic arch support NUMAQ v2
Quoted 82 lines · Yinghai Lu
Quoted 68 lines · Yinghai Lu
so it could fallback to normal numa.
NUMAQ depends on GENERICARCH
also decouple genericarch numa with acpi.
Signed-off-by Yinghai Lu <[email protected]>Index: linux-2.6/arch/x86/Kconfig
===================================================================arch/x86/Kconfig +15
-15@@ -264,17 +264,6 @@ config X86_VOYAGER If you do not specifically know you have a Voyager based machine, say N here, otherwise the kernel you build will not be bootable. -config X86_NUMAQ - bool "NUMAQ (IBM/Sequent)" - depends on SMP && X86_32 && PCI - select NUMA - help - This option is used for getting Linux to run on a (IBM/Sequent) NUMA - multiquad box. This changes the way that processors are bootstrapped, - and uses Clustered Logical APIC addressing mode instead of Flat Logical. - You will need a new lynxer.elf file to flash your firmware with - send - email to <[email protected]>. - config X86_SUMMIT bool "Summit/EXA (IBM x440)" depends on X86_32 && SMP@@ -307,12 +296,12 @@ config X86_VISWS and vice versa. See <file:Documentation/sgi-visws.txt> for details. config X86_GENERICARCH - bool "Generic architecture (Summit, bigsmp, ES7000, default)" + bool "Generic architecture (NUMAQ, Summit, bigsmp, ES7000, default)" depends on X86_32 help - This option compiles in the Summit, bigsmp, ES7000, default subarchitectures. - It is intended for a generic binary kernel. - If you want a NUMA kernel, select ACPI. We need SRAT for NUMA. + This option compiles in the NUMAQ, Summit, bigsmp, ES7000, default + subarchitectures. It is intended for a generic binary kernel. + You need enable NUMA, otherwise NUMAQ is skipped. config X86_ES7000 bool "Support for Unisys ES7000 IA32 series"@@ -348,6 +337,17 @@ config X86_VSMP endchoice +config X86_NUMAQ + bool "NUMAQ (IBM/Sequent)" + depends on SMP && X86_32 && PCI && X86_GENERICARCH + select NUMA + help + This option is used for getting Linux to run on a NUMAQ (IBM/Sequent) + NUMA multiquad box. This changes the way that processors are + bootstrapped, and uses Clustered Logical APIC addressing mode instead + of Flat Logical. You will need a new lynxer.elf file to flash your + firmware with - send email to <[email protected]>. + config SCHED_NO_NO_OMIT_FRAME_POINTER def_bool y prompt "Single-depth WCHAN output"@@ -908,9 +908,9 @@ config X86_PAE config NUMAarch/x86/Kconfig config X86_PAE · line 916
Quoted 10 lines
arch/x86/Kconfig +2
-2bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)" depends on SMP - depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI) && EXPERIMENTAL) + depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || X86_SUMMIT && ACPI) && EXPERIMENTAL) default n if X86_PC - default y if (X86_NUMAQ || X86_SUMMIT) + default y if (X86_NUMAQ || X86_SUMMIT || X86_GENERICARCH) help Enable NUMA (Non Uniform Memory Access) support. The kernel will try to allocate memory used by a CPU on theSam,
Quoted 5 lines
now NUMAQ depends on GENERICARCH.
and Ingo want to make oldconfig to migration NUMAQ....to select GENERICARCH...
but if i add select
X86_GENERICARCH, make oldconfig will get
It is my understanding that special support for NUMAQ should die, so the only remaning usage of CONFIG_NUMAQ is if set to select GENERICARCH. In other words that you should not use CONFIG_NUMAQ anywhere in the code but solely rely on GENERICARCH and then do runtime detection of the other things.
That has been my understanding of the discussions about eliminating the subarch support - but obviosuly Ingo & Co are the ones with better knowledge in this area.
My point is that NUMAQ should not be a visible option at all in *config and solely be present to select GENERICARCH is set to Y in a defconfig file.
So you would have something like:
config NUMAQ
defbool n
config GENERICARCH
default NUMAQ
I am though not sure if this works as expected when NUMAQ is not visible but it should be trivial to test.
Sam
Re: [PATCH] x86: make generic arch support NUMAQ v2
Quoted 87 lines · Sam Ravnborg
Quoted 86 lines · Yinghai Lu
Quoted 68 lines · Yinghai Lu
so it could fallback to normal numa.
NUMAQ depends on GENERICARCH
also decouple genericarch numa with acpi.
Signed-off-by Yinghai Lu <[email protected]>Index: linux-2.6/arch/x86/Kconfig
===================================================================arch/x86/Kconfig +15
-15@@ -264,17 +264,6 @@ config X86_VOYAGER If you do not specifically know you have a Voyager based machine, say N here, otherwise the kernel you build will not be bootable. -config X86_NUMAQ - bool "NUMAQ (IBM/Sequent)" - depends on SMP && X86_32 && PCI - select NUMA - help - This option is used for getting Linux to run on a (IBM/Sequent) NUMA - multiquad box. This changes the way that processors are bootstrapped, - and uses Clustered Logical APIC addressing mode instead of Flat Logical. - You will need a new lynxer.elf file to flash your firmware with - send - email to <[email protected]>. - config X86_SUMMIT bool "Summit/EXA (IBM x440)" depends on X86_32 && SMP@@ -307,12 +296,12 @@ config X86_VISWS and vice versa. See <file:Documentation/sgi-visws.txt> for details. config X86_GENERICARCH - bool "Generic architecture (Summit, bigsmp, ES7000, default)" + bool "Generic architecture (NUMAQ, Summit, bigsmp, ES7000, default)" depends on X86_32 help - This option compiles in the Summit, bigsmp, ES7000, default subarchitectures. - It is intended for a generic binary kernel. - If you want a NUMA kernel, select ACPI. We need SRAT for NUMA. + This option compiles in the NUMAQ, Summit, bigsmp, ES7000, default + subarchitectures. It is intended for a generic binary kernel. + You need enable NUMA, otherwise NUMAQ is skipped. config X86_ES7000 bool "Support for Unisys ES7000 IA32 series"@@ -348,6 +337,17 @@ config X86_VSMP endchoice +config X86_NUMAQ + bool "NUMAQ (IBM/Sequent)" + depends on SMP && X86_32 && PCI && X86_GENERICARCH + select NUMA + help + This option is used for getting Linux to run on a NUMAQ (IBM/Sequent) + NUMA multiquad box. This changes the way that processors are + bootstrapped, and uses Clustered Logical APIC addressing mode instead + of Flat Logical. You will need a new lynxer.elf file to flash your + firmware with - send email to <[email protected]>. + config SCHED_NO_NO_OMIT_FRAME_POINTER def_bool y prompt "Single-depth WCHAN output"@@ -908,9 +908,9 @@ config X86_PAE config NUMAarch/x86/Kconfig config X86_PAE · line 916
Quoted 10 lines
arch/x86/Kconfig +2
-2bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)" depends on SMP - depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI) && EXPERIMENTAL) + depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || X86_SUMMIT && ACPI) && EXPERIMENTAL) default n if X86_PC - default y if (X86_NUMAQ || X86_SUMMIT) + default y if (X86_NUMAQ || X86_SUMMIT || X86_GENERICARCH) help Enable NUMA (Non Uniform Memory Access) support. The kernel will try to allocate memory used by a CPU on theSam,
now NUMAQ depends on GENERICARCH.
and Ingo want to make oldconfig to migration NUMAQ....to select GENERICARCH...
Quoted 7 lines
Quoted 1 line
but if i add select
X86_GENERICARCH, make oldconfig will getIt is my understanding that special support for NUMAQ should die, so the only remaning usage of
CONFIG_NUMAQis if set to select GENERICARCH. In other words that you should not useCONFIG_NUMAQanywhere in the code but solely rely on GENERICARCH and then do runtime detection of the other things.
in case someone don't want to build that special numaq code in.
I think we should make ES7000, Summit depend to GENERICARCH too.
YH
Re: [PATCH] x86: make generic arch support NUMAQ v2
Quoted 9 lines · Yinghai Lu
Quoted 5 lines
It is my understanding that special support for NUMAQ should die, so the only remaning usage of
CONFIG_NUMAQis if set to select GENERICARCH. In other words that you should not useCONFIG_NUMAQanywhere in the code but solely rely on GENERICARCH and then do runtime detection of the other things.in case someone don't want to build that special numaq code in.
I think we should make ES7000, Summit depend to GENERICARCH too.
correct. If someone wants more restricted support, pure CONFIG_X86_PC should do that fine.
also, even GENERICARCH should have as little Kconfig implications as possible. I.e. before your cleanups the subarch code was used to implement something very non-PC, and it was done build-time - which is a PITA in terms of testing and in terms of general complexity. We want to remove those complications and eventually we want to remove the subarch code altogether. (without narrowing hw support of course)
Ingo
Re: [PATCH] x86: make generic arch support NUMAQ v2
Quoted 16 lines · Ingo Molnar
Quoted 9 lines · Yinghai Lu
Quoted 5 lines
It is my understanding that special support for NUMAQ should die, so the only remaning usage of
CONFIG_NUMAQis if set to select GENERICARCH. In other words that you should not useCONFIG_NUMAQanywhere in the code but solely rely on GENERICARCH and then do runtime detection of the other things.in case someone don't want to build that special numaq code in.
I think we should make ES7000, Summit depend to GENERICARCH too.
correct. If someone wants more restricted support, pure
CONFIG_X86_PCshould do that fine.
Quoted 6 lines
also, even GENERICARCH should have as little
Kconfigimplications as possible. I.e. before your cleanups the subarch code was used to implement something very non-PC, and it was done build-time - which is a PITA in terms of testing and in terms of general complexity. We want to remove those complications and eventually we want to remove the subarch code altogether. (without narrowing hw support of course)
current
static struct genapic *apic_probe[] __initdata = { #ifdef CONFIG_X86_NUMAQ
&apic_numaq,
#endif
&apic_summit,
&apic_bigsmp,
&apic_es7000,
&apic_default, /* must be last */ NULL,
};
the apic_default is the 86_PC.
so could make GENERICARCH default to yes.
and have
static struct genapic *apic_probe[] __initdata = { #ifdef CONFIG_X86_NUMAQ
&apic_numaq,
#endif
#ifdef CONFIG_X86_SUMMIT
&apic_summit,
#endif
#ifdef CONFIG_X86_BIGSMP
&apic_bigsmp,
#endif
#ifdef CONFIG_X86_ES7000
&apic_es7000,Eendif
&apic_default, /* must be last */
NULL,
};
also may expand probe a little bit...to cover other different.
YH
PATCH 1/1 x86: make generic arch support NUMAQ v3
In reply to Yinghai Luso it could fallback to normal numa. NUMAQ depends on GENERICARCH
also decouple genericarch numa with acpi. also make it fallback to bigsmp if apicid > 8.
v3: return early if not found_numaq in pci_numa_init
remove xquad_portio in misc.c
arch/x86/Kconfig +17 -17
@@ -264,17 +264,6 @@ config X86_VOYAGER If you do not specifically know you have a Voyager based machine, say N here, otherwise the kernel you build will not be bootable. -config X86_NUMAQ - bool "NUMAQ (IBM/Sequent)" - depends on SMP && X86_32 && PCI - select NUMA - help - This option is used for getting Linux to run on a (IBM/Sequent) NUMA - multiquad box. This changes the way that processors are bootstrapped, - and uses Clustered Logical APIC addressing mode instead of Flat Logical. - You will need a new lynxer.elf file to flash your firmware with - send - email to <[email protected]>. - config X86_SUMMIT bool "Summit/EXA (IBM x440)" depends on X86_32 && SMP
@@ -307,12 +296,12 @@ config X86_VISWS and vice versa. See <file:Documentation/sgi-visws.txt> for details. config X86_GENERICARCH - bool "Generic architecture (Summit, bigsmp, ES7000, default)" + bool "Generic architecture (NUMAQ, Summit, bigsmp, ES7000, default)" depends on X86_32 help - This option compiles in the Summit, bigsmp, ES7000, default subarchitectures. - It is intended for a generic binary kernel. - If you want a NUMA kernel, select ACPI. We need SRAT for NUMA. + This option compiles in the NUMAQ, Summit, bigsmp, ES7000, default + subarchitectures. It is intended for a generic binary kernel. + You need enable NUMA, otherwise NUMAQ is skipped. config X86_ES7000 bool "Support for Unisys ES7000 IA32 series"
@@ -348,6 +337,17 @@ config X86_VSMP endchoice +config X86_NUMAQ + bool "NUMAQ (IBM/Sequent)" + depends on SMP && X86_32 && PCI && X86_GENERICARCH + select NUMA + help + This option is used for getting Linux to run on a NUMAQ (IBM/Sequent) + NUMA multiquad box. This changes the way that processors are + bootstrapped, and uses Clustered Logical APIC addressing mode instead + of Flat Logical. You will need a new lynxer.elf file to flash your + firmware with - send email to <[email protected]>. + config SCHED_NO_NO_OMIT_FRAME_POINTER def_bool y prompt "Single-depth WCHAN output"
@@ -908,9 +908,9 @@ config X86_PAE config NUMA bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)" depends on SMP - depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI) && EXPERIMENTAL) + depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || X86_SUMMIT && ACPI) && EXPERIMENTAL) default n if X86_PC - default y if (X86_NUMAQ || X86_SUMMIT) + default y if (X86_NUMAQ || X86_SUMMIT || X86_GENERICARCH) help Enable NUMA (Non Uniform Memory Access) support. The kernel will try to allocate memory used by a CPU on the
arch/x86/kernel/io_apic_32.c +5 -4
@@ -1715,7 +1715,6 @@ void disable_IO_APIC(void)* by Matt Domsch <[email protected]> Tue Dec 21 12:25:05 CST 1999 */ -#ifndef CONFIG_X86_NUMAQ static void __init setup_ioapic_ids_from_mpc (void ) {union IO_APIC_reg_00 reg_00;
@@ -1725,6 +1724,11 @@ static void __init setup_ioapic_ids_fromunsigned char old_id;unsigned long flags; +#ifdef CONFIG_X86_NUMAQ +if (found_numaq) +return ; +#endif +/* * Don't check I/O APIC IDs for xAPIC systems. They have * no meaning without the serial APIC bus.
@@ -1821,9 +1825,6 @@ static void __init setup_ioapic_ids_fromapic_printk (APIC_VERBOSE ," ok.\n" ); } } -#else -static void __init setup_ioapic_ids_from_mpc (void ) { } -#endif int no_timer_check__initdata ;
arch/x86/kernel/mpparse.c +73 -3
112 lines not on this page · raw message
arch/x86/kernel/numaq_32.c +0 -12
@@ -36,8 +36,6 @@#define MB_TO_PAGES (addr) ((addr) << (20 - PAGE_SHIFT)) -int found_numaq; -/* * Function: smp_dump_qct() *
@@ -105,13 +103,3 @@ static int __init numaq_tsc_disable(void }arch_initcall (numaq_tsc_disable); -#ifdef CONFIG_ACPI -/* -* Dummy implementation: -*/ -struct pci_bus *__devinit -pci_acpi_scan_root (struct acpi_device *device,int domain,int busnum) -{ -return NULL ; -} -#endif
arch/x86/mach-generic/Makefile +4 -3
@@ -2,7 +2,8 @@ # Makefile for the generic architecture # -EXTRA_CFLAGS := -Iarch/x86/kernel +EXTRA_CFLAGS := -Iarch/x86/kernel -obj-y := probe.o summit.o bigsmp.o es7000.o default.o -obj-y += ../../x86/mach-es7000/ +obj-y := probe.o summit.o bigsmp.o es7000.o default.o +obj-$(CONFIG_X86_NUMAQ) += numaq.o +obj-y += ../../x86/mach-es7000/
arch/x86/mach-generic/probe.c +6 -1
@@ -16,6 +16,7 @@#include <asm/apicdef.h> #include <asm/genapic.h> +extern struct genapic apic_numaq;extern struct genapic apic_summit;extern struct genapic apic_bigsmp;extern struct genapic apic_es7000;
@@ -24,6 +25,9 @@ extern struct genapic apic_default;struct genapic *genapic = &apic_default;static struct genapic *apic_probe[]__initdata = { +#ifdef CONFIG_X86_NUMAQ + &apic_numaq, +#endif &apic_summit, &apic_bigsmp, &apic_es7000,
@@ -88,7 +92,8 @@ void __init generic_apic_probe(void)/* These functions can switch the APIC even after the initial ->probe() */ -int __init mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid) +int __init mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid) {int i;for (i =0 ; apic_probe[i]; ++i) {
arch/x86/pci/Makefile_32 +3 -2
@@ -13,10 +13,11 @@ pci-y := fixup.o pci-$(CONFIG_ACPI) += acpi.o pci-y += legacy.o irq.o -# Careful: VISWS and NUMAQ overrule the pci-y above. The colons are +# Careful: VISWS overrule the pci-y above. The colons are # therefor correct. This needs a proper fix by distangling the code. pci-$(CONFIG_X86_VISWS) := visws.o fixup.o -pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o + +pci-$(CONFIG_X86_NUMAQ) += numa.o # Necessary for NUMAQ as well pci-$(CONFIG_NUMA) += mp_bus_to_node.o
arch/x86/pci/numa.c +4 -25
@@ -6,45 +6,21 @@#include <linux/init.h> #include <linux/nodemask.h> #include <mach_apic.h> +#include <asm/mpspec.h> #include "pci.h" #define XQUAD_PORTIO_BASE 0xfe400000#define XQUAD_PORTIO_QUAD 0x40000/* 256k per quad. */ -int mp_bus_id_to_node[MAX_MP_BUSSES ];#define BUS2QUAD (global) (mp_bus_id_to_node[global]) -int mp_bus_id_to_local[MAX_MP_BUSSES ];#define BUS2LOCAL (global) (mp_bus_id_to_local[global]) -void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - mp_bus_id_to_node[m->mpc_busid] = quad; - mp_bus_id_to_local[m->mpc_busid] = local; -printk (KERN_INFO "Bus #%d is %s (node %d)\n" , - m->mpc_busid, name, quad); -} - -int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ];#define QUADLOCAL2BUS (quad,local) (quad_local_to_mp_bus_id[quad][local]) -void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - quad_local_to_mp_bus_id[quad][local] = m->mpc_busid; -}/* Where the IO area was mapped on multiquad, always 0 otherwise */ void *xquad_portio; -#ifdef CONFIG_X86_NUMAQ EXPORT_SYMBOL (xquad_portio); -#endif #define XQUAD_PORT_ADDR (port, quad) (xquad_portio + (XQUAD_PORTIO_QUAD*quad) + port)
@@ -179,6 +155,9 @@ static int __init pci_numa_init(void) {int quad; +if (!found_numaq) +return 0 ; + raw_pci_ops = &pci_direct_conf1_mq;if (pcibios_scanned++)
include/asm-x86/mach-generic/mach_mpparse.h +5 -2
@@ -1,7 +1,10 @@#ifndef _MACH_MPPARSE_H#define _MACH_MPPARSE_H 1 -int mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid); -int acpi_madt_oem_check (char *oem_id,char *oem_table_id); + +extern int mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid); + +extern int acpi_madt_oem_check (char *oem_id,char *oem_table_id);#endif
include/asm-x86/mach-numaq/mach_apic.h +8 -31
@@ -20,8 +20,14 @@ static inline cpumask_t target_cpus(void#define INT_DELIVERY_MODE dest_LowestPrio#define INT_DEST_MODE 0/* physical delivery on LOCAL quad */ -#define check_apicid_used (bitmap, apicid) physid_isset(apicid, bitmap) -#define check_apicid_present (bit) physid_isset(bit, phys_cpu_present_map) +static inline unsigned long check_apicid_used (physid_mask_t bitmap,int apicid) +{ +return physid_isset (apicid, bitmap); +} +static inline unsigned long check_apicid_present (int bit) +{ +return physid_isset (bit, phys_cpu_present_map); +}#define apicid_cluster (apicid) (apicid & 0xF0)static inline int apic_id_registered (void )
@@ -77,11 +83,6 @@ static inline int cpu_present_to_apicid(return BAD_APICID ; } -static inline int generate_logical_apicid (int quad,int phys_apicid) -{ -return (quad <<4 ) + (phys_apicid ? phys_apicid <<1 :1 ); -} -static inline int apicid_to_node (int logical_apicid) {return logical_apicid >>4 ;
@@ -95,30 +96,6 @@ static inline physid_mask_t apicid_to_cpreturn physid_mask_of_physid (cpu +4 *node); } -struct mpc_config_translation { -unsigned char mpc_type; -unsigned char trans_len; -unsigned char trans_type; -unsigned char trans_quad; -unsigned char trans_global; -unsigned char trans_local; -unsigned short trans_reserved; -}; - -static inline int mpc_apic_id (struct mpc_config_processor *m, -struct mpc_config_translation *translation_record) -{ -int quad = translation_record->trans_quad; -int logical_apicid =generate_logical_apicid (quad, m->mpc_apicid); - -printk ("Processor #%d %u:%u APIC version %d (quad %d, apic %d)\n" , - m->mpc_apicid, - (m->mpc_cpufeature &CPU_FAMILY_MASK ) >>8 , - (m->mpc_cpufeature &CPU_MODEL_MASK ) >>4 , - m->mpc_apicver, quad, logical_apicid); -return logical_apicid; -} -extern void *xquad_portio;static inline void setup_portio_remap (void )
include/asm-x86/mach-numaq/mach_mpparse.h +2 -9
@@ -1,14 +1,7 @@#ifndef __ASM_MACH_MPPARSE_H#define __ASM_MACH_MPPARSE_H -extern void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation); -extern void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation); - -/* Hook from generic ACPI tables.c */ -static inline void acpi_madt_oem_check (char *oem_id,char *oem_table_id) -{ -} +extern void numaq_mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid);#endif /* __ASM_MACH_MPPARSE_H */
include/asm-x86/mmzone_32.h +4 -14
@@ -12,11 +12,9 @@extern struct pglist_data *node_data[];#define NODE_DATA (nid) (node_data[nid]) -#ifdef CONFIG_X86_NUMAQ -#include <asm/numaq.h> -#elif defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ -#include <asm/srat.h> -#endif +#include <asm/numaq.h> +/* summit or generic arch */ +#include <asm/srat.h> extern int get_memcfg_numa_flat (void );/*
@@ -26,14 +24,11 @@ extern int get_memcfg_numa_flat(void);*/ static inline void get_memcfg_numa (void ) { -#ifdef CONFIG_X86_NUMAQ +if (get_memcfg_numaq ())return ; -#elif defined(CONFIG_ACPI_SRAT )if (get_memcfg_from_srat ())return ; -#endif -get_memcfg_numa_flat (); }
@@ -42,7 +37,6 @@ extern int early_pfn_to_nid(unsigned lon#else /* !CONFIG_NUMA */ #define get_memcfg_numa get_memcfg_numa_flat -#define get_zholes_size (n) (0)#endif /* CONFIG_NUMA */
@@ -83,9 +77,6 @@ static inline int pfn_to_nid(unsigned lo __pgdat->node_start_pfn + __pgdat->node_spanned_pages; \ }) -#ifdef CONFIG_X86_NUMAQ /* we have contiguous memory on NUMA-Q */ -#define pfn_valid (pfn) ((pfn) < num_physpages) -#else static inline int pfn_valid (int pfn) {int nid =pfn_to_nid (pfn);
@@ -94,7 +85,6 @@ static inline int pfn_valid(int pfn)return (pfn <node_end_pfn (nid)); return 0; } -#endif /* CONFIG_X86_NUMAQ */ #endif /* CONFIG_DISCONTIGMEM */
include/asm-x86/numaq.h +3 -2
@@ -157,9 +157,10 @@ struct sys_cfg_data {struct eachquadmem eq[MAX_NUMNODES ];/* indexed by quad id */ }; -static inline unsigned long *get_zholes_size (int nid) +#else +static inline int get_memcfg_numaq (void ) { -return NULL ; +return 0 ; }#endif /* CONFIG_X86_NUMAQ */ #endif /* NUMAQ_H */
include/asm-x86/srat.h +7 -5
@@ -27,11 +27,13 @@#ifndef _ASM_SRAT_H_#define _ASM_SRAT_H_ -#ifndef CONFIG_ACPI_SRAT -#error CONFIG_ACPI_SRAT not defined, and srat.h header has been included -#endif - +#ifdef CONFIG_ACPI_SRAT extern int get_memcfg_from_srat (void ); -extern unsigned long *get_zholes_size (int ); +#else +static inline int get_memcfg_from_srat (void ) +{ +return 0 ; +} +#endif #endif /* _ASM_SRAT_H_ */
arch/x86/mach-generic/numaq.c new file +41 -0
41 lines not on this page · raw message
arch/x86/kernel/apic_32.c +1 -1
@@ -1528,7 +1528,7 @@ void __cpuinit generic_processor_info(in* if (CPU_HOTPLUG_ENABLED || num_processors > 8) * - Ashok Raj <[email protected]> */ -if (num_processors >8 ) { +if (apicid >8 ) {switch (boot_cpu_data.x86_vendor) {case X86_VENDOR_INTEL :if (!APIC_XAPIC (version)) {
arch/x86/mach-generic/bigsmp.c +1 -1
@@ -48,7 +48,7 @@ static const struct dmi_system_id bigsmpstatic int probe_bigsmp (void ) {if (def_to_bigsmp) - dmi_bigsmp =1 ; + dmi_bigsmp =1 ;else dmi_check_system (bigsmp_dmi_table);return dmi_bigsmp;
drivers/acpi/Kconfig +0 -1
@@ -4,7 +4,6 @@ menuconfig ACPI bool "ACPI (Advanced Configuration and Power Interface) Support" - depends on !X86_NUMAQ depends on !X86_VISWS depends on !IA64_HP_SIM depends on IA64 || X86
include/asm-x86/mpspec.h +6 -0
@@ -13,6 +13,12 @@ extern int apic_version[MAX_APICS];extern u8 apicid_2_node[];extern int pic_mode; +#ifdef CONFIG_X86_NUMAQ +extern int mp_bus_id_to_node[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_local[MAX_MP_BUSSES ]; +extern int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ]; +#endif +#define MAX_APICID 256#else
arch/x86/kernel/summit_32.c +2 -0
@@ -36,7 +36,9 @@ static struct rio_table_hdr *rio_table_hstatic struct scal_detail *scal_devs[MAX_NUMNODES ]__initdata ;static struct rio_detail *rio_devs[MAX_NUMNODES *4 ]__initdata ; +#ifndef CONFIG_X86_NUMAQ static int mp_bus_id_to_node[MAX_MP_BUSSES ]__initdata ; +#endif static int __init setup_pci_node_map_for_wpeg (int wpeg_num,int last_bus) {
arch/x86/boot/compressed/misc.c +0 -4
@@ -217,10 +217,6 @@ static char *vidmem;static int vidport;static int lines, cols; -#ifdef CONFIG_X86_NUMAQ -void *xquad_portio; -#endif -#include "../../../../lib/inflate.c" static void *malloc (int size)
PATCH 1/1 x86: make generic arch support NUMAQ v4
so it could fallback to normal numa. NUMAQ depends on GENERICARCH
also decouple genericarch numa with acpi. also make it fallback to bigsmp if apicid > 8.
v3: return early if not found_numaq in pci_numa_init
remove xquad_portio in misc.c
v4: make summit, bigsmp and es7000 depend on GENERICARCH too
arch/x86/Kconfig +36 -38
@@ -264,36 +264,6 @@ config X86_VOYAGER If you do not specifically know you have a Voyager based machine, say N here, otherwise the kernel you build will not be bootable. -config X86_NUMAQ - bool "NUMAQ (IBM/Sequent)" - depends on SMP && X86_32 && PCI - select NUMA - help - This option is used for getting Linux to run on a (IBM/Sequent) NUMA - multiquad box. This changes the way that processors are bootstrapped, - and uses Clustered Logical APIC addressing mode instead of Flat Logical. - You will need a new lynxer.elf file to flash your firmware with - send - email to <[email protected]>. - -config X86_SUMMIT - bool "Summit/EXA (IBM x440)" - depends on X86_32 && SMP - help - This option is needed for IBM systems that use the Summit/EXA chipset. - In particular, it is needed for the x440. - - If you don't have one of these computers, you should say N here. - If you want to build a NUMA kernel, you must select ACPI. - -config X86_BIGSMP - bool "Support for other sub-arch SMP systems with more than 8 CPUs" - depends on X86_32 && SMP - help - This option is needed for the systems that have more than 8 CPUs - and if the system is not of any sub-arch type above. - - If you don't have such a system, you should say N here. - config X86_VISWS bool "SGI 320/540 (Visual Workstation)" depends on X86_32 && !PCI
@@ -307,12 +277,33 @@ config X86_VISWS and vice versa. See <file:Documentation/sgi-visws.txt> for details. config X86_GENERICARCH - bool "Generic architecture (Summit, bigsmp, ES7000, default)" + bool "Generic architecture" depends on X86_32 help - This option compiles in the Summit, bigsmp, ES7000, default subarchitectures. - It is intended for a generic binary kernel. - If you want a NUMA kernel, select ACPI. We need SRAT for NUMA. + This option compiles in the NUMAQ, Summit, bigsmp, ES7000, default + subarchitectures. It is intended for a generic binary kernel. + if you select them all, kernel will probe it one by one. and will + fallback to default. + +if X86_GENERICARCH + +config X86_NUMAQ + bool "NUMAQ (IBM/Sequent)" + depends on SMP && X86_32 && PCI + select NUMA + help + This option is used for getting Linux to run on a NUMAQ (IBM/Sequent) + NUMA multiquad box. This changes the way that processors are + bootstrapped, and uses Clustered Logical APIC addressing mode instead + of Flat Logical. You will need a new lynxer.elf file to flash your + firmware with - send email to <[email protected]>. + +config X86_SUMMIT + bool "Summit/EXA (IBM x440)" + depends on X86_32 && SMP + help + This option is needed for IBM systems that use the Summit/EXA chipset. + In particular, it is needed for the x440. config X86_ES7000 bool "Support for Unisys ES7000 IA32 series"
@@ -320,8 +311,15 @@ config X86_ES7000 help Support for Unisys ES7000 systems. Say 'Y' here if this kernel is supposed to run on an IA32-based Unisys ES7000 system. - Only choose this option if you have such a system, otherwise you - should say N here. + +config X86_BIGSMP + bool "Support for big SMP systems with more than 8 CPUs" + depends on X86_32 && SMP + help + This option is needed for the systems that have more than 8 CPUs + and if the system is not of any sub-arch type above. + +endif config X86_RDC321X bool "RDC R-321x SoC"
@@ -908,9 +906,9 @@ config X86_PAE config NUMA bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)" depends on SMP - depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI) && EXPERIMENTAL) + depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || X86_SUMMIT && ACPI) && EXPERIMENTAL) default n if X86_PC - default y if (X86_NUMAQ || X86_SUMMIT) + default y if (X86_NUMAQ || X86_SUMMIT || X86_GENERICARCH) help Enable NUMA (Non Uniform Memory Access) support. The kernel will try to allocate memory used by a CPU on the
arch/x86/kernel/io_apic_32.c +5 -4
@@ -1715,7 +1715,6 @@ void disable_IO_APIC(void)* by Matt Domsch <[email protected]> Tue Dec 21 12:25:05 CST 1999 */ -#ifndef CONFIG_X86_NUMAQ static void __init setup_ioapic_ids_from_mpc (void ) {union IO_APIC_reg_00 reg_00;
@@ -1725,6 +1724,11 @@ static void __init setup_ioapic_ids_fromunsigned char old_id;unsigned long flags; +#ifdef CONFIG_X86_NUMAQ +if (found_numaq) +return ; +#endif +/* * Don't check I/O APIC IDs for xAPIC systems. They have * no meaning without the serial APIC bus.
@@ -1821,9 +1825,6 @@ static void __init setup_ioapic_ids_fromapic_printk (APIC_VERBOSE ," ok.\n" ); } } -#else -static void __init setup_ioapic_ids_from_mpc (void ) { } -#endif int no_timer_check__initdata ;
arch/x86/kernel/mpparse.c +73 -3
112 lines not on this page · raw message
arch/x86/kernel/numaq_32.c +0 -12
@@ -36,8 +36,6 @@#define MB_TO_PAGES (addr) ((addr) << (20 - PAGE_SHIFT)) -int found_numaq; -/* * Function: smp_dump_qct() *
@@ -105,13 +103,3 @@ static int __init numaq_tsc_disable(void }arch_initcall (numaq_tsc_disable); -#ifdef CONFIG_ACPI -/* -* Dummy implementation: -*/ -struct pci_bus *__devinit -pci_acpi_scan_root (struct acpi_device *device,int domain,int busnum) -{ -return NULL ; -} -#endif
arch/x86/mach-generic/Makefile +7 -3
@@ -2,7 +2,11 @@ # Makefile for the generic architecture # -EXTRA_CFLAGS := -Iarch/x86/kernel +EXTRA_CFLAGS := -Iarch/x86/kernel -obj-y := probe.o summit.o bigsmp.o es7000.o default.o -obj-y += ../../x86/mach-es7000/ +obj-y := probe.o default.o +obj-$(CONFIG_X86_NUMAQ) += numaq.o +obj-$(CONFIG_X86_SUMMIT) += summit.o +obj-$(CONFIG_X86_BIGSMP) += bigsmp.o +obj-$(CONFIG_X86_ES7000) += es7000.o +obj-$(CONFIG_X86_ES7000) += ../../x86/mach-es7000/
arch/x86/mach-generic/probe.c +14 -1
@@ -16,6 +16,7 @@#include <asm/apicdef.h> #include <asm/genapic.h> +extern struct genapic apic_numaq;extern struct genapic apic_summit;extern struct genapic apic_bigsmp;extern struct genapic apic_es7000;
@@ -24,9 +25,18 @@ extern struct genapic apic_default;struct genapic *genapic = &apic_default;static struct genapic *apic_probe[]__initdata = { +#ifdef CONFIG_X86_NUMAQ + &apic_numaq, +#endif +#ifdef CONFIG_X86_SUMMIT &apic_summit, +#endif +#ifdef CONFIG_X86_BIGSMP &apic_bigsmp, +#endif +#ifdef CONFIG_X86_ES7000 &apic_es7000, +#endif &apic_default,/* must be last */ NULL , };
@@ -54,6 +64,7 @@ early_param("apic", parse_apic);void __init generic_bigsmp_probe (void ) { +#if CONFIG_X86_BIGSMP /* * This routine is used to switch to bigsmp mode when * - There is no apic= option specified by the user
@@ -67,6 +78,7 @@ void __init generic_bigsmp_probe(void)printk (KERN_INFO "Overriding APIC driver with %s\n" , genapic->name); } +#endif }void __init generic_apic_probe (void )
@@ -88,7 +100,8 @@ void __init generic_apic_probe(void)/* These functions can switch the APIC even after the initial ->probe() */ -int __init mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid) +int __init mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid) {int i;for (i =0 ; apic_probe[i]; ++i) {
arch/x86/pci/Makefile_32 +3 -2
@@ -13,10 +13,11 @@ pci-y := fixup.o pci-$(CONFIG_ACPI) += acpi.o pci-y += legacy.o irq.o -# Careful: VISWS and NUMAQ overrule the pci-y above. The colons are +# Careful: VISWS overrule the pci-y above. The colons are # therefor correct. This needs a proper fix by distangling the code. pci-$(CONFIG_X86_VISWS) := visws.o fixup.o -pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o + +pci-$(CONFIG_X86_NUMAQ) += numa.o # Necessary for NUMAQ as well pci-$(CONFIG_NUMA) += mp_bus_to_node.o
arch/x86/pci/numa.c +4 -25
@@ -6,45 +6,21 @@#include <linux/init.h> #include <linux/nodemask.h> #include <mach_apic.h> +#include <asm/mpspec.h> #include "pci.h" #define XQUAD_PORTIO_BASE 0xfe400000#define XQUAD_PORTIO_QUAD 0x40000/* 256k per quad. */ -int mp_bus_id_to_node[MAX_MP_BUSSES ];#define BUS2QUAD (global) (mp_bus_id_to_node[global]) -int mp_bus_id_to_local[MAX_MP_BUSSES ];#define BUS2LOCAL (global) (mp_bus_id_to_local[global]) -void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - mp_bus_id_to_node[m->mpc_busid] = quad; - mp_bus_id_to_local[m->mpc_busid] = local; -printk (KERN_INFO "Bus #%d is %s (node %d)\n" , - m->mpc_busid, name, quad); -} - -int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ];#define QUADLOCAL2BUS (quad,local) (quad_local_to_mp_bus_id[quad][local]) -void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - quad_local_to_mp_bus_id[quad][local] = m->mpc_busid; -}/* Where the IO area was mapped on multiquad, always 0 otherwise */ void *xquad_portio; -#ifdef CONFIG_X86_NUMAQ EXPORT_SYMBOL (xquad_portio); -#endif #define XQUAD_PORT_ADDR (port, quad) (xquad_portio + (XQUAD_PORTIO_QUAD*quad) + port)
@@ -179,6 +155,9 @@ static int __init pci_numa_init(void) {int quad; +if (!found_numaq) +return 0 ; + raw_pci_ops = &pci_direct_conf1_mq;if (pcibios_scanned++)
include/asm-x86/mach-generic/mach_mpparse.h +5 -2
@@ -1,7 +1,10 @@#ifndef _MACH_MPPARSE_H#define _MACH_MPPARSE_H 1 -int mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid); -int acpi_madt_oem_check (char *oem_id,char *oem_table_id); + +extern int mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid); + +extern int acpi_madt_oem_check (char *oem_id,char *oem_table_id);#endif
include/asm-x86/mach-numaq/mach_apic.h +8 -31
@@ -20,8 +20,14 @@ static inline cpumask_t target_cpus(void#define INT_DELIVERY_MODE dest_LowestPrio#define INT_DEST_MODE 0/* physical delivery on LOCAL quad */ -#define check_apicid_used (bitmap, apicid) physid_isset(apicid, bitmap) -#define check_apicid_present (bit) physid_isset(bit, phys_cpu_present_map) +static inline unsigned long check_apicid_used (physid_mask_t bitmap,int apicid) +{ +return physid_isset (apicid, bitmap); +} +static inline unsigned long check_apicid_present (int bit) +{ +return physid_isset (bit, phys_cpu_present_map); +}#define apicid_cluster (apicid) (apicid & 0xF0)static inline int apic_id_registered (void )
@@ -77,11 +83,6 @@ static inline int cpu_present_to_apicid(return BAD_APICID ; } -static inline int generate_logical_apicid (int quad,int phys_apicid) -{ -return (quad <<4 ) + (phys_apicid ? phys_apicid <<1 :1 ); -} -static inline int apicid_to_node (int logical_apicid) {return logical_apicid >>4 ;
@@ -95,30 +96,6 @@ static inline physid_mask_t apicid_to_cpreturn physid_mask_of_physid (cpu +4 *node); } -struct mpc_config_translation { -unsigned char mpc_type; -unsigned char trans_len; -unsigned char trans_type; -unsigned char trans_quad; -unsigned char trans_global; -unsigned char trans_local; -unsigned short trans_reserved; -}; - -static inline int mpc_apic_id (struct mpc_config_processor *m, -struct mpc_config_translation *translation_record) -{ -int quad = translation_record->trans_quad; -int logical_apicid =generate_logical_apicid (quad, m->mpc_apicid); - -printk ("Processor #%d %u:%u APIC version %d (quad %d, apic %d)\n" , - m->mpc_apicid, - (m->mpc_cpufeature &CPU_FAMILY_MASK ) >>8 , - (m->mpc_cpufeature &CPU_MODEL_MASK ) >>4 , - m->mpc_apicver, quad, logical_apicid); -return logical_apicid; -} -extern void *xquad_portio;static inline void setup_portio_remap (void )
include/asm-x86/mach-numaq/mach_mpparse.h +2 -9
@@ -1,14 +1,7 @@#ifndef __ASM_MACH_MPPARSE_H#define __ASM_MACH_MPPARSE_H -extern void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation); -extern void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation); - -/* Hook from generic ACPI tables.c */ -static inline void acpi_madt_oem_check (char *oem_id,char *oem_table_id) -{ -} +extern void numaq_mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid);#endif /* __ASM_MACH_MPPARSE_H */
include/asm-x86/mmzone_32.h +4 -14
@@ -12,11 +12,9 @@extern struct pglist_data *node_data[];#define NODE_DATA (nid) (node_data[nid]) -#ifdef CONFIG_X86_NUMAQ -#include <asm/numaq.h> -#elif defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ -#include <asm/srat.h> -#endif +#include <asm/numaq.h> +/* summit or generic arch */ +#include <asm/srat.h> extern int get_memcfg_numa_flat (void );/*
@@ -26,14 +24,11 @@ extern int get_memcfg_numa_flat(void);*/ static inline void get_memcfg_numa (void ) { -#ifdef CONFIG_X86_NUMAQ +if (get_memcfg_numaq ())return ; -#elif defined(CONFIG_ACPI_SRAT )if (get_memcfg_from_srat ())return ; -#endif -get_memcfg_numa_flat (); }
@@ -42,7 +37,6 @@ extern int early_pfn_to_nid(unsigned lon#else /* !CONFIG_NUMA */ #define get_memcfg_numa get_memcfg_numa_flat -#define get_zholes_size (n) (0)#endif /* CONFIG_NUMA */
@@ -83,9 +77,6 @@ static inline int pfn_to_nid(unsigned lo __pgdat->node_start_pfn + __pgdat->node_spanned_pages; \ }) -#ifdef CONFIG_X86_NUMAQ /* we have contiguous memory on NUMA-Q */ -#define pfn_valid (pfn) ((pfn) < num_physpages) -#else static inline int pfn_valid (int pfn) {int nid =pfn_to_nid (pfn);
@@ -94,7 +85,6 @@ static inline int pfn_valid(int pfn)return (pfn <node_end_pfn (nid)); return 0; } -#endif /* CONFIG_X86_NUMAQ */ #endif /* CONFIG_DISCONTIGMEM */
include/asm-x86/numaq.h +3 -2
@@ -157,9 +157,10 @@ struct sys_cfg_data {struct eachquadmem eq[MAX_NUMNODES ];/* indexed by quad id */ }; -static inline unsigned long *get_zholes_size (int nid) +#else +static inline int get_memcfg_numaq (void ) { -return NULL ; +return 0 ; }#endif /* CONFIG_X86_NUMAQ */ #endif /* NUMAQ_H */
include/asm-x86/srat.h +7 -5
@@ -27,11 +27,13 @@#ifndef _ASM_SRAT_H_#define _ASM_SRAT_H_ -#ifndef CONFIG_ACPI_SRAT -#error CONFIG_ACPI_SRAT not defined, and srat.h header has been included -#endif - +#ifdef CONFIG_ACPI_SRAT extern int get_memcfg_from_srat (void ); -extern unsigned long *get_zholes_size (int ); +#else +static inline int get_memcfg_from_srat (void ) +{ +return 0 ; +} +#endif #endif /* _ASM_SRAT_H_ */
arch/x86/mach-generic/numaq.c new file +41 -0
41 lines not on this page · raw message
arch/x86/kernel/apic_32.c +1 -1
@@ -1531,7 +1531,7 @@ void __cpuinit generic_processor_info(in* if (CPU_HOTPLUG_ENABLED || num_processors > 8) * - Ashok Raj <[email protected]> */ -if (num_processors >8 ) { +if (apicid >8 ) {switch (boot_cpu_data.x86_vendor) {case X86_VENDOR_INTEL :if (!APIC_XAPIC (version)) {
arch/x86/mach-generic/bigsmp.c +1 -3
@@ -23,10 +23,8 @@ static int dmi_bigsmp; /* can be set bystatic int hp_ht_bigsmp (const struct dmi_system_id *d) { -#ifdef CONFIG_X86_GENERICARCH printk (KERN_NOTICE "%s detected: force use of apic=bigsmp\n" , d->ident); dmi_bigsmp =1 ; -#endif return 0 ; }
@@ -48,7 +46,7 @@ static const struct dmi_system_id bigsmpstatic int probe_bigsmp (void ) {if (def_to_bigsmp) - dmi_bigsmp =1 ; + dmi_bigsmp =1 ;else dmi_check_system (bigsmp_dmi_table);return dmi_bigsmp;
drivers/acpi/Kconfig +0 -1
@@ -4,7 +4,6 @@ menuconfig ACPI bool "ACPI (Advanced Configuration and Power Interface) Support" - depends on !X86_NUMAQ depends on !X86_VISWS depends on !IA64_HP_SIM depends on IA64 || X86
include/asm-x86/mpspec.h +6 -0
@@ -13,6 +13,12 @@ extern int apic_version[MAX_APICS];extern u8 apicid_2_node[];extern int pic_mode; +#ifdef CONFIG_X86_NUMAQ +extern int mp_bus_id_to_node[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_local[MAX_MP_BUSSES ]; +extern int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ]; +#endif +#define MAX_APICID 256#else
arch/x86/kernel/summit_32.c +2 -0
@@ -36,7 +36,9 @@ static struct rio_table_hdr *rio_table_hstatic struct scal_detail *scal_devs[MAX_NUMNODES ]__initdata ;static struct rio_detail *rio_devs[MAX_NUMNODES *4 ]__initdata ; +#ifndef CONFIG_X86_NUMAQ static int mp_bus_id_to_node[MAX_MP_BUSSES ]__initdata ; +#endif static int __init setup_pci_node_map_for_wpeg (int wpeg_num,int last_bus) {
arch/x86/boot/compressed/misc.c +0 -4
@@ -217,10 +217,6 @@ static char *vidmem;static int vidport;static int lines, cols; -#ifdef CONFIG_X86_NUMAQ -void *xquad_portio; -#endif -#include "../../../../lib/inflate.c" static void *malloc (int size)
arch/x86/Makefile +0 -18
@@ -117,29 +117,11 @@ mcore-$(CONFIG_X86_VOYAGER) := arch/x86/ mflags-$(CONFIG_X86_VISWS) := -Iinclude/asm-x86/mach-visws mcore-$(CONFIG_X86_VISWS) := arch/x86/mach-visws/ -# NUMAQ subarch support -mflags-$(CONFIG_X86_NUMAQ) := -Iinclude/asm-x86/mach-numaq -mcore-$(CONFIG_X86_NUMAQ) := arch/x86/mach-default/ - -# BIGSMP subarch support -mflags-$(CONFIG_X86_BIGSMP) := -Iinclude/asm-x86/mach-bigsmp -mcore-$(CONFIG_X86_BIGSMP) := arch/x86/mach-default/ - -#Summit subarch support -mflags-$(CONFIG_X86_SUMMIT) := -Iinclude/asm-x86/mach-summit -mcore-$(CONFIG_X86_SUMMIT) := arch/x86/mach-default/ - # generic subarchitecture mflags-$(CONFIG_X86_GENERICARCH):= -Iinclude/asm-x86/mach-generic fcore-$(CONFIG_X86_GENERICARCH) += arch/x86/mach-generic/ mcore-$(CONFIG_X86_GENERICARCH) := arch/x86/mach-default/ - -# ES7000 subarch support -mflags-$(CONFIG_X86_ES7000) := -Iinclude/asm-x86/mach-es7000 -fcore-$(CONFIG_X86_ES7000) := arch/x86/mach-es7000/ -mcore-$(CONFIG_X86_ES7000) := arch/x86/mach-default/ - # RDC R-321x subarch support mflags-$(CONFIG_X86_RDC321X) := -Iinclude/asm-x86/mach-rdc321x mcore-$(CONFIG_X86_RDC321X) := arch/x86/mach-default/
arch/x86/kernel/acpi/boot.c +2 -2
@@ -858,7 +858,7 @@ static int __init acpi_parse_madt_lapic_#ifdef CONFIG_X86_IO_APIC #define MP_ISA_BUS 0 -#if defined(CONFIG_X86_ES7000 ) || defined(CONFIG_X86_GENERICARCH ) +#ifdef CONFIG_X86_ES7000 extern int es7000_plat;#endif
@@ -1007,7 +1007,7 @@ void __init mp_config_acpi_legacy_irqs(vset_bit (MP_ISA_BUS , mp_bus_not_pci);Dprintk ("Bus #%d is ISA\n" ,MP_ISA_BUS ); -#if defined(CONFIG_X86_ES7000 ) || defined(CONFIG_X86_GENERICARCH ) +#ifdef CONFIG_X86_ES7000 /* * Older generations of ES7000 have no legacy identity mappings */
arch/x86/mach-es7000/Makefile +0 -1
@@ -3,4 +3,3 @@ # obj-$(CONFIG_X86_ES7000) := es7000plat.o -obj-$(CONFIG_X86_GENERICARCH) := es7000plat.o
arch/x86/mach-es7000/es7000plat.c +0 -47
53 lines not on this page · raw message
PATCH 1/1 x86: introduce max_physical_apicid for bigsmp switching
one multi-sockets system with 3 or 4 ioapics, when 4 dualcore cpus or 2 quadcore cpus installed, need to switch to bigsmp or physflat. because cpu apic id is [4,11] instead of [0,7], and we need to check max apic id instead of cpu numbers.
also add check for 32 bit when acpi is not compiled in or acpi=off
arch/x86/kernel/apic_32.c +4 -1
@@ -1520,6 +1520,9 @@ void __cpuinit generic_processor_info(in*/ cpu =0 ; +if (apicid > max_physical_apicid) + max_physical_apicid = apicid; +/* * Would be preferable to switch to bigsmp when CONFIG_HOTPLUG_CPU=y * but we need to work other dependencies like SMP_SUSPEND etc
@@ -1527,7 +1530,7 @@ void __cpuinit generic_processor_info(in* if (CPU_HOTPLUG_ENABLED || num_processors > 8) * - Ashok Raj <[email protected]> */ -if (num_processors >8 ) { +if (max_physical_apicid >=8 ) {switch (boot_cpu_data.x86_vendor) {case X86_VENDOR_INTEL :if (!APIC_XAPIC (version)) {
arch/x86/kernel/apic_64.c +3 -0
@@ -1092,6 +1092,9 @@ void __cpuinit generic_processor_info(in*/ cpu =0 ; } +if (apicid > max_physical_apicid) + max_physical_apicid = apicid; +/* are we being called early in kernel startup? */ if (early_per_cpu_ptr (x86_cpu_to_apicid)) {u16 *cpu_to_apicid =early_per_cpu_ptr (x86_cpu_to_apicid);
arch/x86/kernel/genapic_64.c +1 -1
@@ -51,7 +51,7 @@ void __init setup_apic_routing(void) else#endif -if (num_possible_cpus () <=8 ) +if (max_physical_apicid <8 ) genapic = &apic_flat;else genapic = &apic_physflat;
arch/x86/kernel/mpparse.c +5 -0
@@ -473,6 +473,11 @@ static int __init smp_read_mpc(struct mp ++mpc_record;#endif } + +#ifdef CONFIG_X86_GENERICARCH +generic_bigsmp_probe (); +#endif +setup_apic_routing ();if (!num_processors)printk (KERN_ERR "MPTABLE: no processors registered!\n" );
arch/x86/kernel/setup.c +1 -0
@@ -17,6 +17,7 @@ unsigned int num_processors;unsigned disabled_cpus__cpuinitdata ;/* Processor that is doing the boot up */ unsigned int boot_cpu_physical_apicid =-1U ; +unsigned int max_physical_apicid;EXPORT_SYMBOL (boot_cpu_physical_apicid);/* Bitmask of physically existing CPUs */
arch/x86/kernel/setup_32.c +5 -6
@@ -838,18 +838,17 @@ void __init setup_arch(char **cmdline_p)#ifdef CONFIG_ACPI acpi_boot_init (); - +#endif +#if defined(CONFIG_X86_MPPARSE ) || defined(CONFIG_X86_VISWS ) +if (smp_found_config) +get_smp_config (); +#endif #if defined(CONFIG_SMP ) && defined(CONFIG_X86_PC )if (def_to_bigsmp)printk (KERN_WARNING "More than 8 CPUs detected and " "CONFIG_X86_PC cannot handle it.\nUse " "CONFIG_X86_GENERICARCH or CONFIG_X86_BIGSMP.\n" );#endif -#endif -#if defined(CONFIG_X86_MPPARSE ) || defined(CONFIG_X86_VISWS ) -if (smp_found_config) -get_smp_config (); -#endif e820_setup_gap ();e820_mark_nosave_regions (max_low_pfn);
arch/x86/mach-generic/bigsmp.c +1 -1
@@ -48,7 +48,7 @@ static const struct dmi_system_id bigsmpstatic int probe_bigsmp (void ) {if (def_to_bigsmp) - dmi_bigsmp =1 ; + dmi_bigsmp =1 ;else dmi_check_system (bigsmp_dmi_table);return dmi_bigsmp;
include/asm-x86/mpspec.h +1 -0
@@ -33,6 +33,7 @@ extern int mp_bus_id_to_type[MAX_MP_BUSS extern DECLARE_BITMAP(mp_bus_not_pci, MAX_MP_BUSSES);extern unsigned int boot_cpu_physical_apicid; +extern unsigned int max_physical_apicid;extern int smp_found_config;extern int mpc_default_type;extern unsigned long mp_lapic_addr;
PATCH 1/1 x86: make generic arch support NUMAQ v5
In reply to Yinghai Luso it could fallback to normal numa.
NUMAQ depends on GENERICARCH
also decouple genericarch numa with acpi.
also make it fallback to bigsmp if apicid > 8.
v3: return early if not found_numaq in pci_numa_init
remove xquad_portio in misc.c
v4: make summit, bigsmp and es7000 depend on GENERICARCH too
v5: seperate apicid check for bigsmp to another patch
[PATCH] x86: introduce max_physical_apicid for bigsmp switching
arch/x86/Kconfig +36 -38
@@ -264,36 +264,6 @@ config X86_VOYAGER If you do not specifically know you have a Voyager based machine, say N here, otherwise the kernel you build will not be bootable. -config X86_NUMAQ - bool "NUMAQ (IBM/Sequent)" - depends on SMP && X86_32 && PCI - select NUMA - help - This option is used for getting Linux to run on a (IBM/Sequent) NUMA - multiquad box. This changes the way that processors are bootstrapped, - and uses Clustered Logical APIC addressing mode instead of Flat Logical. - You will need a new lynxer.elf file to flash your firmware with - send - email to <[email protected]>. - -config X86_SUMMIT - bool "Summit/EXA (IBM x440)" - depends on X86_32 && SMP - help - This option is needed for IBM systems that use the Summit/EXA chipset. - In particular, it is needed for the x440. - - If you don't have one of these computers, you should say N here. - If you want to build a NUMA kernel, you must select ACPI. - -config X86_BIGSMP - bool "Support for other sub-arch SMP systems with more than 8 CPUs" - depends on X86_32 && SMP - help - This option is needed for the systems that have more than 8 CPUs - and if the system is not of any sub-arch type above. - - If you don't have such a system, you should say N here. - config X86_VISWS bool "SGI 320/540 (Visual Workstation)" depends on X86_32 && !PCI
@@ -307,12 +277,33 @@ config X86_VISWS and vice versa. See <file:Documentation/sgi-visws.txt> for details. config X86_GENERICARCH - bool "Generic architecture (Summit, bigsmp, ES7000, default)" + bool "Generic architecture" depends on X86_32 help - This option compiles in the Summit, bigsmp, ES7000, default subarchitectures. - It is intended for a generic binary kernel. - If you want a NUMA kernel, select ACPI. We need SRAT for NUMA. + This option compiles in the NUMAQ, Summit, bigsmp, ES7000, default + subarchitectures. It is intended for a generic binary kernel. + if you select them all, kernel will probe it one by one. and will + fallback to default. + +if X86_GENERICARCH + +config X86_NUMAQ + bool "NUMAQ (IBM/Sequent)" + depends on SMP && X86_32 && PCI + select NUMA + help + This option is used for getting Linux to run on a NUMAQ (IBM/Sequent) + NUMA multiquad box. This changes the way that processors are + bootstrapped, and uses Clustered Logical APIC addressing mode instead + of Flat Logical. You will need a new lynxer.elf file to flash your + firmware with - send email to <[email protected]>. + +config X86_SUMMIT + bool "Summit/EXA (IBM x440)" + depends on X86_32 && SMP + help + This option is needed for IBM systems that use the Summit/EXA chipset. + In particular, it is needed for the x440. config X86_ES7000 bool "Support for Unisys ES7000 IA32 series"
@@ -320,8 +311,15 @@ config X86_ES7000 help Support for Unisys ES7000 systems. Say 'Y' here if this kernel is supposed to run on an IA32-based Unisys ES7000 system. - Only choose this option if you have such a system, otherwise you - should say N here. + +config X86_BIGSMP + bool "Support for big SMP systems with more than 8 CPUs" + depends on X86_32 && SMP + help + This option is needed for the systems that have more than 8 CPUs + and if the system is not of any sub-arch type above. + +endif config X86_RDC321X bool "RDC R-321x SoC"
@@ -908,9 +906,9 @@ config X86_PAE config NUMA bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)" depends on SMP - depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI) && EXPERIMENTAL) + depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || X86_SUMMIT && ACPI) && EXPERIMENTAL) default n if X86_PC - default y if (X86_NUMAQ || X86_SUMMIT) + default y if (X86_NUMAQ || X86_SUMMIT || X86_GENERICARCH) help Enable NUMA (Non Uniform Memory Access) support. The kernel will try to allocate memory used by a CPU on the
arch/x86/kernel/io_apic_32.c +5 -4
@@ -1715,7 +1715,6 @@ void disable_IO_APIC(void)* by Matt Domsch <[email protected]> Tue Dec 21 12:25:05 CST 1999 */ -#ifndef CONFIG_X86_NUMAQ static void __init setup_ioapic_ids_from_mpc (void ) {union IO_APIC_reg_00 reg_00;
@@ -1725,6 +1724,11 @@ static void __init setup_ioapic_ids_fromunsigned char old_id;unsigned long flags; +#ifdef CONFIG_X86_NUMAQ +if (found_numaq) +return ; +#endif +/* * Don't check I/O APIC IDs for xAPIC systems. They have * no meaning without the serial APIC bus.
@@ -1821,9 +1825,6 @@ static void __init setup_ioapic_ids_fromapic_printk (APIC_VERBOSE ," ok.\n" ); } } -#else -static void __init setup_ioapic_ids_from_mpc (void ) { } -#endif int no_timer_check__initdata ;
arch/x86/kernel/mpparse.c +70 -3
103 lines not on this page · raw message
arch/x86/kernel/numaq_32.c +0 -12
@@ -36,8 +36,6 @@#define MB_TO_PAGES (addr) ((addr) << (20 - PAGE_SHIFT)) -int found_numaq; -/* * Function: smp_dump_qct() *
@@ -105,13 +103,3 @@ static int __init numaq_tsc_disable(void }arch_initcall (numaq_tsc_disable); -#ifdef CONFIG_ACPI -/* -* Dummy implementation: -*/ -struct pci_bus *__devinit -pci_acpi_scan_root (struct acpi_device *device,int domain,int busnum) -{ -return NULL ; -} -#endif
arch/x86/mach-generic/Makefile +7 -3
@@ -2,7 +2,11 @@ # Makefile for the generic architecture # -EXTRA_CFLAGS := -Iarch/x86/kernel +EXTRA_CFLAGS := -Iarch/x86/kernel -obj-y := probe.o summit.o bigsmp.o es7000.o default.o -obj-y += ../../x86/mach-es7000/ +obj-y := probe.o default.o +obj-$(CONFIG_X86_NUMAQ) += numaq.o +obj-$(CONFIG_X86_SUMMIT) += summit.o +obj-$(CONFIG_X86_BIGSMP) += bigsmp.o +obj-$(CONFIG_X86_ES7000) += es7000.o +obj-$(CONFIG_X86_ES7000) += ../../x86/mach-es7000/
arch/x86/mach-generic/probe.c +14 -1
@@ -16,6 +16,7 @@#include <asm/apicdef.h> #include <asm/genapic.h> +extern struct genapic apic_numaq;extern struct genapic apic_summit;extern struct genapic apic_bigsmp;extern struct genapic apic_es7000;
@@ -24,9 +25,18 @@ extern struct genapic apic_default;struct genapic *genapic = &apic_default;static struct genapic *apic_probe[]__initdata = { +#ifdef CONFIG_X86_NUMAQ + &apic_numaq, +#endif +#ifdef CONFIG_X86_SUMMIT &apic_summit, +#endif +#ifdef CONFIG_X86_BIGSMP &apic_bigsmp, +#endif +#ifdef CONFIG_X86_ES7000 &apic_es7000, +#endif &apic_default,/* must be last */ NULL , };
@@ -54,6 +64,7 @@ early_param("apic", parse_apic);void __init generic_bigsmp_probe (void ) { +#if CONFIG_X86_BIGSMP /* * This routine is used to switch to bigsmp mode when * - There is no apic= option specified by the user
@@ -67,6 +78,7 @@ void __init generic_bigsmp_probe(void)printk (KERN_INFO "Overriding APIC driver with %s\n" , genapic->name); } +#endif }void __init generic_apic_probe (void )
@@ -88,7 +100,8 @@ void __init generic_apic_probe(void)/* These functions can switch the APIC even after the initial ->probe() */ -int __init mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid) +int __init mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid) {int i;for (i =0 ; apic_probe[i]; ++i) {
arch/x86/pci/Makefile_32 +3 -2
@@ -13,10 +13,11 @@ pci-y := fixup.o pci-$(CONFIG_ACPI) += acpi.o pci-y += legacy.o irq.o -# Careful: VISWS and NUMAQ overrule the pci-y above. The colons are +# Careful: VISWS overrule the pci-y above. The colons are # therefor correct. This needs a proper fix by distangling the code. pci-$(CONFIG_X86_VISWS) := visws.o fixup.o -pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o + +pci-$(CONFIG_X86_NUMAQ) += numa.o # Necessary for NUMAQ as well pci-$(CONFIG_NUMA) += mp_bus_to_node.o
arch/x86/pci/numa.c +4 -25
@@ -6,45 +6,21 @@#include <linux/init.h> #include <linux/nodemask.h> #include <mach_apic.h> +#include <asm/mpspec.h> #include "pci.h" #define XQUAD_PORTIO_BASE 0xfe400000#define XQUAD_PORTIO_QUAD 0x40000/* 256k per quad. */ -int mp_bus_id_to_node[MAX_MP_BUSSES ];#define BUS2QUAD (global) (mp_bus_id_to_node[global]) -int mp_bus_id_to_local[MAX_MP_BUSSES ];#define BUS2LOCAL (global) (mp_bus_id_to_local[global]) -void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - mp_bus_id_to_node[m->mpc_busid] = quad; - mp_bus_id_to_local[m->mpc_busid] = local; -printk (KERN_INFO "Bus #%d is %s (node %d)\n" , - m->mpc_busid, name, quad); -} - -int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ];#define QUADLOCAL2BUS (quad,local) (quad_local_to_mp_bus_id[quad][local]) -void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - quad_local_to_mp_bus_id[quad][local] = m->mpc_busid; -}/* Where the IO area was mapped on multiquad, always 0 otherwise */ void *xquad_portio; -#ifdef CONFIG_X86_NUMAQ EXPORT_SYMBOL (xquad_portio); -#endif #define XQUAD_PORT_ADDR (port, quad) (xquad_portio + (XQUAD_PORTIO_QUAD*quad) + port)
@@ -179,6 +155,9 @@ static int __init pci_numa_init(void) {int quad; +if (!found_numaq) +return 0 ; + raw_pci_ops = &pci_direct_conf1_mq;if (pcibios_scanned++)
include/asm-x86/mach-generic/mach_mpparse.h +5 -2
@@ -1,7 +1,10 @@#ifndef _MACH_MPPARSE_H#define _MACH_MPPARSE_H 1 -int mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid); -int acpi_madt_oem_check (char *oem_id,char *oem_table_id); + +extern int mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid); + +extern int acpi_madt_oem_check (char *oem_id,char *oem_table_id);#endif
include/asm-x86/mach-numaq/mach_apic.h +8 -31
@@ -20,8 +20,14 @@ static inline cpumask_t target_cpus(void#define INT_DELIVERY_MODE dest_LowestPrio#define INT_DEST_MODE 0/* physical delivery on LOCAL quad */ -#define check_apicid_used (bitmap, apicid) physid_isset(apicid, bitmap) -#define check_apicid_present (bit) physid_isset(bit, phys_cpu_present_map) +static inline unsigned long check_apicid_used (physid_mask_t bitmap,int apicid) +{ +return physid_isset (apicid, bitmap); +} +static inline unsigned long check_apicid_present (int bit) +{ +return physid_isset (bit, phys_cpu_present_map); +}#define apicid_cluster (apicid) (apicid & 0xF0)static inline int apic_id_registered (void )
@@ -77,11 +83,6 @@ static inline int cpu_present_to_apicid(return BAD_APICID ; } -static inline int generate_logical_apicid (int quad,int phys_apicid) -{ -return (quad <<4 ) + (phys_apicid ? phys_apicid <<1 :1 ); -} -static inline int apicid_to_node (int logical_apicid) {return logical_apicid >>4 ;
@@ -95,30 +96,6 @@ static inline physid_mask_t apicid_to_cpreturn physid_mask_of_physid (cpu +4 *node); } -struct mpc_config_translation { -unsigned char mpc_type; -unsigned char trans_len; -unsigned char trans_type; -unsigned char trans_quad; -unsigned char trans_global; -unsigned char trans_local; -unsigned short trans_reserved; -}; - -static inline int mpc_apic_id (struct mpc_config_processor *m, -struct mpc_config_translation *translation_record) -{ -int quad = translation_record->trans_quad; -int logical_apicid =generate_logical_apicid (quad, m->mpc_apicid); - -printk ("Processor #%d %u:%u APIC version %d (quad %d, apic %d)\n" , - m->mpc_apicid, - (m->mpc_cpufeature &CPU_FAMILY_MASK ) >>8 , - (m->mpc_cpufeature &CPU_MODEL_MASK ) >>4 , - m->mpc_apicver, quad, logical_apicid); -return logical_apicid; -} -extern void *xquad_portio;static inline void setup_portio_remap (void )
include/asm-x86/mach-numaq/mach_mpparse.h +2 -9
@@ -1,14 +1,7 @@#ifndef __ASM_MACH_MPPARSE_H#define __ASM_MACH_MPPARSE_H -extern void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation); -extern void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation); - -/* Hook from generic ACPI tables.c */ -static inline void acpi_madt_oem_check (char *oem_id,char *oem_table_id) -{ -} +extern void numaq_mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid);#endif /* __ASM_MACH_MPPARSE_H */
include/asm-x86/mmzone_32.h +4 -14
@@ -12,11 +12,9 @@extern struct pglist_data *node_data[];#define NODE_DATA (nid) (node_data[nid]) -#ifdef CONFIG_X86_NUMAQ -#include <asm/numaq.h> -#elif defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ -#include <asm/srat.h> -#endif +#include <asm/numaq.h> +/* summit or generic arch */ +#include <asm/srat.h> extern int get_memcfg_numa_flat (void );/*
@@ -26,14 +24,11 @@ extern int get_memcfg_numa_flat(void);*/ static inline void get_memcfg_numa (void ) { -#ifdef CONFIG_X86_NUMAQ +if (get_memcfg_numaq ())return ; -#elif defined(CONFIG_ACPI_SRAT )if (get_memcfg_from_srat ())return ; -#endif -get_memcfg_numa_flat (); }
@@ -42,7 +37,6 @@ extern int early_pfn_to_nid(unsigned lon#else /* !CONFIG_NUMA */ #define get_memcfg_numa get_memcfg_numa_flat -#define get_zholes_size (n) (0)#endif /* CONFIG_NUMA */
@@ -83,9 +77,6 @@ static inline int pfn_to_nid(unsigned lo __pgdat->node_start_pfn + __pgdat->node_spanned_pages; \ }) -#ifdef CONFIG_X86_NUMAQ /* we have contiguous memory on NUMA-Q */ -#define pfn_valid (pfn) ((pfn) < num_physpages) -#else static inline int pfn_valid (int pfn) {int nid =pfn_to_nid (pfn);
@@ -94,7 +85,6 @@ static inline int pfn_valid(int pfn)return (pfn <node_end_pfn (nid)); return 0; } -#endif /* CONFIG_X86_NUMAQ */ #endif /* CONFIG_DISCONTIGMEM */
include/asm-x86/numaq.h +3 -2
@@ -157,9 +157,10 @@ struct sys_cfg_data {struct eachquadmem eq[MAX_NUMNODES ];/* indexed by quad id */ }; -static inline unsigned long *get_zholes_size (int nid) +#else +static inline int get_memcfg_numaq (void ) { -return NULL ; +return 0 ; }#endif /* CONFIG_X86_NUMAQ */ #endif /* NUMAQ_H */
include/asm-x86/srat.h +7 -5
@@ -27,11 +27,13 @@#ifndef _ASM_SRAT_H_#define _ASM_SRAT_H_ -#ifndef CONFIG_ACPI_SRAT -#error CONFIG_ACPI_SRAT not defined, and srat.h header has been included -#endif - +#ifdef CONFIG_ACPI_SRAT extern int get_memcfg_from_srat (void ); -extern unsigned long *get_zholes_size (int ); +#else +static inline int get_memcfg_from_srat (void ) +{ +return 0 ; +} +#endif #endif /* _ASM_SRAT_H_ */
arch/x86/mach-generic/numaq.c new file +41 -0
41 lines not on this page · raw message
arch/x86/mach-generic/bigsmp.c +0 -2
@@ -23,10 +23,8 @@ static int dmi_bigsmp; /* can be set bystatic int hp_ht_bigsmp (const struct dmi_system_id *d) { -#ifdef CONFIG_X86_GENERICARCH printk (KERN_NOTICE "%s detected: force use of apic=bigsmp\n" , d->ident); dmi_bigsmp =1 ; -#endif return 0 ; }
drivers/acpi/Kconfig +0 -1
@@ -4,7 +4,6 @@ menuconfig ACPI bool "ACPI (Advanced Configuration and Power Interface) Support" - depends on !X86_NUMAQ depends on !X86_VISWS depends on !IA64_HP_SIM depends on IA64 || X86
include/asm-x86/mpspec.h +6 -0
@@ -13,6 +13,12 @@ extern int apic_version[MAX_APICS];extern u8 apicid_2_node[];extern int pic_mode; +#ifdef CONFIG_X86_NUMAQ +extern int mp_bus_id_to_node[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_local[MAX_MP_BUSSES ]; +extern int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ]; +#endif +#define MAX_APICID 256#else
arch/x86/kernel/summit_32.c +2 -0
@@ -36,7 +36,9 @@ static struct rio_table_hdr *rio_table_hstatic struct scal_detail *scal_devs[MAX_NUMNODES ]__initdata ;static struct rio_detail *rio_devs[MAX_NUMNODES *4 ]__initdata ; +#ifndef CONFIG_X86_NUMAQ static int mp_bus_id_to_node[MAX_MP_BUSSES ]__initdata ; +#endif static int __init setup_pci_node_map_for_wpeg (int wpeg_num,int last_bus) {
arch/x86/boot/compressed/misc.c +0 -4
@@ -217,10 +217,6 @@ static char *vidmem;static int vidport;static int lines, cols; -#ifdef CONFIG_X86_NUMAQ -void *xquad_portio; -#endif -#include "../../../../lib/inflate.c" static void *malloc (int size)
arch/x86/Makefile +0 -18
@@ -117,29 +117,11 @@ mcore-$(CONFIG_X86_VOYAGER) := arch/x86/ mflags-$(CONFIG_X86_VISWS) := -Iinclude/asm-x86/mach-visws mcore-$(CONFIG_X86_VISWS) := arch/x86/mach-visws/ -# NUMAQ subarch support -mflags-$(CONFIG_X86_NUMAQ) := -Iinclude/asm-x86/mach-numaq -mcore-$(CONFIG_X86_NUMAQ) := arch/x86/mach-default/ - -# BIGSMP subarch support -mflags-$(CONFIG_X86_BIGSMP) := -Iinclude/asm-x86/mach-bigsmp -mcore-$(CONFIG_X86_BIGSMP) := arch/x86/mach-default/ - -#Summit subarch support -mflags-$(CONFIG_X86_SUMMIT) := -Iinclude/asm-x86/mach-summit -mcore-$(CONFIG_X86_SUMMIT) := arch/x86/mach-default/ - # generic subarchitecture mflags-$(CONFIG_X86_GENERICARCH):= -Iinclude/asm-x86/mach-generic fcore-$(CONFIG_X86_GENERICARCH) += arch/x86/mach-generic/ mcore-$(CONFIG_X86_GENERICARCH) := arch/x86/mach-default/ - -# ES7000 subarch support -mflags-$(CONFIG_X86_ES7000) := -Iinclude/asm-x86/mach-es7000 -fcore-$(CONFIG_X86_ES7000) := arch/x86/mach-es7000/ -mcore-$(CONFIG_X86_ES7000) := arch/x86/mach-default/ - # RDC R-321x subarch support mflags-$(CONFIG_X86_RDC321X) := -Iinclude/asm-x86/mach-rdc321x mcore-$(CONFIG_X86_RDC321X) := arch/x86/mach-default/
arch/x86/kernel/acpi/boot.c +2 -2
@@ -858,7 +858,7 @@ static int __init acpi_parse_madt_lapic_#ifdef CONFIG_X86_IO_APIC #define MP_ISA_BUS 0 -#if defined(CONFIG_X86_ES7000 ) || defined(CONFIG_X86_GENERICARCH ) +#ifdef CONFIG_X86_ES7000 extern int es7000_plat;#endif
@@ -1007,7 +1007,7 @@ void __init mp_config_acpi_legacy_irqs(vset_bit (MP_ISA_BUS , mp_bus_not_pci);Dprintk ("Bus #%d is ISA\n" ,MP_ISA_BUS ); -#if defined(CONFIG_X86_ES7000 ) || defined(CONFIG_X86_GENERICARCH ) +#ifdef CONFIG_X86_ES7000 /* * Older generations of ES7000 have no legacy identity mappings */
arch/x86/mach-es7000/Makefile +0 -1
@@ -3,4 +3,3 @@ # obj-$(CONFIG_X86_ES7000) := es7000plat.o -obj-$(CONFIG_X86_GENERICARCH) := es7000plat.o
arch/x86/mach-es7000/es7000plat.c +0 -47
53 lines not on this page · raw message
Re: [PATCH] x86: make generic arch support NUMAQ v5
Quoted 11 lines · Yinghai Lu
so it could fallback to normal numa.
NUMAQ depends on GENERICARCH
also decouple genericarch numa with acpi.
also make it fallback to bigsmp if apicid > 8.v3: return early if not
found_numaqinpci_numa_init
removexquad_portioinmisc.c
v4: make summit, bigsmp and es7000 depend on GENERICARCH too
v5: seperate apicid check for bigsmp to another patch
[PATCH] x86: introducemax_physical_apicidfor bigsmp switching
Do you have a NUMA-Q to test this on? Also, what is the baseline here as I would like to test it?
Quoted 55 lines
Signed-off-by Yinghai Lu <[email protected]>Index: linux-2.6/arch/x86/Kconfig
===================================================================arch/x86/Kconfig +1
-34@@ -264,36 +264,6 @@ config X86_VOYAGER If you do not specifically know you have a Voyager based machine, say N here, otherwise the kernel you build will not be bootable. -config X86_NUMAQ - bool "NUMAQ (IBM/Sequent)" - depends on SMP && X86_32 && PCI - select NUMA - help - This option is used for getting Linux to run on a (IBM/Sequent) NUMA - multiquad box. This changes the way that processors are bootstrapped, - and uses Clustered Logical APIC addressing mode instead of Flat Logical. - You will need a new lynxer.elf file to flash your firmware with - send - email to <[email protected]>. - -config X86_SUMMIT - bool "Summit/EXA (IBM x440)" - depends on X86_32 && SMP - help - This option is needed for IBM systems that use the Summit/EXA chipset. - In particular, it is needed for the x440. - - If you don't have one of these computers, you should say N here. - If you want to build a NUMA kernel, you must select ACPI. - -config X86_BIGSMP - bool "Support for other sub-arch SMP systems with more than 8 CPUs" - depends on X86_32 && SMP - help - This option is needed for the systems that have more than 8 CPUs - and if the system is not of any sub-arch type above. - - If you don't have such a system, you should say N here. - config X86_VISWS bool "SGI 320/540 (Visual Workstation)" depends on X86_32 && !PCI@@ -307,12 +277,33 @@ config X86_VISWS and vice versa. See <file:Documentation/sgi-visws.txt> for details. config X86_GENERICARCH - bool "Generic architecture (Summit, bigsmp, ES7000, default)" + bool "Generic architecture" depends on X86_32 help - This option compiles in the Summit, bigsmp, ES7000, default subarchitectures. - It is intended for a generic binary kernel. - If you want a NUMA kernel, select ACPI. We need SRAT for NUMA.
arch/x86/Kconfig config X86_VISWS · line 292
Quoted 10 lines
arch/x86/Kconfig +10
-0+ This option compiles in the NUMAQ, Summit, bigsmp, ES7000, default + subarchitectures. It is intended for a generic binary kernel. + if you select them all, kernel will probe it one by one. and will + fallback to default. + +if X86_GENERICARCH + +config X86_NUMAQ + bool "NUMAQ (IBM/Sequent)" + depends on SMP && X86_32 && PCI
Can we not just add && X86_GENERICARCH here instead of putting them in that if ?
Quoted 36 lines
arch/x86/Kconfig +23
-2+ select NUMA + help + This option is used for getting Linux to run on a NUMAQ (IBM/Sequent) + NUMA multiquad box. This changes the way that processors are + bootstrapped, and uses Clustered Logical APIC addressing mode instead + of Flat Logical. You will need a new lynxer.elf file to flash your + firmware with - send email to <[email protected]>. + +config X86_SUMMIT + bool "Summit/EXA (IBM x440)" + depends on X86_32 && SMP + help + This option is needed for IBM systems that use the Summit/EXA chipset. + In particular, it is needed for the x440. config X86_ES7000 bool "Support for Unisys ES7000 IA32 series"@@ -320,8 +311,15 @@ config X86_ES7000 help Support for Unisys ES7000 systems. Say 'Y' here if this kernel is supposed to run on an IA32-based Unisys ES7000 system. - Only choose this option if you have such a system, otherwise you - should say N here. + +config X86_BIGSMP + bool "Support for big SMP systems with more than 8 CPUs" + depends on X86_32 && SMP + help + This option is needed for the systems that have more than 8 CPUs + and if the system is not of any sub-arch type above. + +endif config X86_RDC321X bool "RDC R-321x SoC"
arch/x86/Kconfig config X86_PAE · line 911
Quoted 8 lines
arch/x86/Kconfig +2
-2@@ -908,9 +906,9 @@ config X86_PAE config NUMA bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)" depends on SMP - depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI) && EXPERIMENTAL) + depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || X86_SUMMIT && ACPI) && EXPERIMENTAL) default n if X86_PC - default y if (X86_NUMAQ || X86_SUMMIT) + default y if (X86_NUMAQ || X86_SUMMIT || X86_GENERICARCH)
If I am reading this right we are making all genericarch kernels NUMA, which before they were not. Hmmm is that going to cause problems elsewhere? Mind you can you get non-numa boxes any more?
If its only NUMAQ which makes that requireemnt it seems wrong to add GENERICARCH here. ie. its NUMAQ or SUMMIT that brings the requirement.
Quoted 16 lines
arch/x86/Kconfig +0
-0help Enable NUMA (Non Uniform Memory Access) support. The kernel will try to allocate memory used by a CPU on theIndex:
linux-2.6/arch/x86/kernel/io_apic_32.c
===================================================================arch/x86/kernel/io_apic_32.c +0
-1@@ -1715,7 +1715,6 @@ void disable_IO_APIC(void)* by Matt Domsch <[email protected]> Tue Dec 21 12:25:05 CST 1999 */ -#ifndef CONFIG_X86_NUMAQ static void __init setup_ioapic_ids_from_mpc (void ) {union IO_APIC_reg_00 reg_00;
arch/x86/kernel/io_apic_32.c static void __init setup_ioapic_ids_from · line 1731
Quoted 8 lines
arch/x86/kernel/io_apic_32.c +5
-0@@ -1725,6 +1724,11 @@ static void __init setup_ioapic_ids_fromunsigned char old_id;unsigned long flags; +#ifdef CONFIG_X86_NUMAQ +if (found_numaq) +return ; +#endif +
Could this not be always compiled in? As long as found_numaq is never 1 we should be ok.
Quoted 108 lines
arch/x86/kernel/io_apic_32.c +0
-3/* * Don't check I/O APIC IDs for xAPIC systems. They have * no meaning without the serial APIC bus. @@ -1821,9 +1825,6 @@ static void __init setup_ioapic_ids_fromapic_printk (APIC_VERBOSE ," ok.\n" ); } } -#else -static void __init setup_ioapic_ids_from_mpc (void ) { } -#endif int no_timer_check__initdata ;Index:
linux-2.6/arch/x86/kernel/mpparse.c
===================================================================arch/x86/kernel/mpparse.c +60
-2@@ -49,15 +49,73 @@ static int __init mpf_checksum(unsigned }#ifdef CONFIG_X86_NUMAQ +int found_numaq;/* * Have to match translation table entries to main table entries by counter * hence the mpc_record variable .... can't see a less disgusting way of * doing this .... */ +struct mpc_config_translation { +unsigned char mpc_type; +unsigned char trans_len; +unsigned char trans_type; +unsigned char trans_quad; +unsigned char trans_global; +unsigned char trans_local; +unsigned short trans_reserved; +}; +static int mpc_record;static struct mpc_config_translation *translation_table[MAX_MPC_ENTRY ]__cpuinitdata ; + +static inline int generate_logical_apicid (int quad,int phys_apicid) +{ +return (quad <<4 ) + (phys_apicid ? phys_apicid <<1 :1 ); +} + + +static inline int mpc_apic_id (struct mpc_config_processor *m, +struct mpc_config_translation *translation_record) +{ +int quad = translation_record->trans_quad; +int logical_apicid =generate_logical_apicid (quad, m->mpc_apicid); + +printk (KERN_DEBUG "Processor #%d %u:%u APIC version %d (quad %d, apic %d)\n" , + m->mpc_apicid, + (m->mpc_cpufeature &CPU_FAMILY_MASK ) >>8 , + (m->mpc_cpufeature &CPU_MODEL_MASK ) >>4 , + m->mpc_apicver, quad, logical_apicid); +return logical_apicid; +} + +int mp_bus_id_to_node[MAX_MP_BUSSES ]; + +int mp_bus_id_to_local[MAX_MP_BUSSES ]; + +static void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, +struct mpc_config_translation *translation) +{ +int quad = translation->trans_quad; +int local = translation->trans_local; + + mp_bus_id_to_node[m->mpc_busid] = quad; + mp_bus_id_to_local[m->mpc_busid] = local; +printk (KERN_INFO "Bus #%d is %s (node %d)\n" , + m->mpc_busid, name, quad); +} + +int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ]; +static void mpc_oem_pci_bus (struct mpc_config_bus *m, +struct mpc_config_translation *translation) +{ +int quad = translation->trans_quad; +int local = translation->trans_local; + + quad_local_to_mp_bus_id[quad][local] = m->mpc_busid; +} +#endif static void __cpuinit MP_processor_info (struct mpc_config_processor *m)@@ -321,11 +382,11 @@ static void __init smp_read_mpc_oem(stru } } -static inline void mps_oem_check (struct mp_config_table *mpc,char *oem, +void numaq_mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid) {if (strncmp (oem,"IBM NUMA" ,8 )) -printk ("Warning! May not be a NUMA-Q system!\n" ); +printk ("Warning! Not a NUMA-Q system!\n" );else found_numaq =1 ;@@ -388,7 +449,16 @@ static int __init smp_read_mpc(struct mpreturn 0 ;
arch/x86/kernel/mpparse.c static int __init smp_read_mpc(struct mp · line 459
Quoted 10 lines
arch/x86/kernel/mpparse.c +8
-1#ifdef CONFIG_X86_32 -mps_oem_check (mpc, oem, str); +/* +* need to make sure summit and es7000's mps_oem_check is safe to be +* called early via genericarch 's mps_oem_check +*/ +if (early) { +#ifdef CONFIG_X86_NUMAQ +numaq_mps_oem_check (mpc, oem, str); +#endif
Is there any reason we cannot use:
if (found_numaq) numaq_mps_oem_check(mpc, oem, str);
Also why is this dependant on 'early'. There doesn't seem to be such a check in the original path?
Quoted 99 lines
arch/x86/kernel/mpparse.c +2
-0+ } else +mps_oem_check (mpc, oem, str);#endif /* save the local APIC address, it might be non-default */ Index:
linux-2.6/arch/x86/kernel/numaq_32.c
===================================================================arch/x86/kernel/numaq_32.c +0
-12@@ -36,8 +36,6 @@#define MB_TO_PAGES (addr) ((addr) << (20 - PAGE_SHIFT)) -int found_numaq; -/* * Function: smp_dump_qct() * @@ -105,13 +103,3 @@ static int __init numaq_tsc_disable(void }arch_initcall (numaq_tsc_disable); -#ifdef CONFIG_ACPI -/* -* Dummy implementation: -*/ -struct pci_bus *__devinit -pci_acpi_scan_root (struct acpi_device *device,int domain,int busnum) -{ -return NULL ; -} -#endif Index: linux-2.6/arch/x86/mach-generic/Makefile
===================================================================arch/x86/mach-generic/Makefile +7
-3@@ -2,7 +2,11 @@ # Makefile for the generic architecture # -EXTRA_CFLAGS := -Iarch/x86/kernel +EXTRA_CFLAGS := -Iarch/x86/kernel -obj-y := probe.o summit.o bigsmp.o es7000.o default.o -obj-y += ../../x86/mach-es7000/ +obj-y := probe.o default.o +obj-$(CONFIG_X86_NUMAQ) += numaq.o +obj-$(CONFIG_X86_SUMMIT) += summit.o +obj-$(CONFIG_X86_BIGSMP) += bigsmp.o +obj-$(CONFIG_X86_ES7000) += es7000.o +obj-$(CONFIG_X86_ES7000) += ../../x86/mach-es7000/Index:
linux-2.6/arch/x86/mach-generic/probe.c
===================================================================arch/x86/mach-generic/probe.c +12
-0@@ -16,6 +16,7 @@#include <asm/apicdef.h> #include <asm/genapic.h> +extern struct genapic apic_numaq;extern struct genapic apic_summit;extern struct genapic apic_bigsmp;extern struct genapic apic_es7000;@@ -24,9 +25,18 @@ extern struct genapic apic_default;struct genapic *genapic = &apic_default;static struct genapic *apic_probe[]__initdata = { +#ifdef CONFIG_X86_NUMAQ + &apic_numaq, +#endif +#ifdef CONFIG_X86_SUMMIT &apic_summit, +#endif +#ifdef CONFIG_X86_BIGSMP &apic_bigsmp, +#endif +#ifdef CONFIG_X86_ES7000 &apic_es7000, +#endif &apic_default,/* must be last */ NULL , };@@ -54,6 +64,7 @@ early_param("apic", parse_apic);void __init generic_bigsmp_probe (void ) { +#if CONFIG_X86_BIGSMP /* * This routine is used to switch to bigsmp mode when * - There is no apic= option specified by the user @@ -67,6 +78,7 @@ void __init generic_bigsmp_probe(void)printk (KERN_INFO "Overriding APIC driver with %s\n" , genapic->name); } +#endif }void __init generic_apic_probe (void )
arch/x86/mach-generic/probe.c void __init generic_apic_probe(void) · line 107
Quoted 9 lines
arch/x86/mach-generic/probe.c +2
-1@@ -88,7 +100,8 @@ void __init generic_apic_probe(void)/* These functions can switch the APIC even after the initial ->probe() */ -int __init mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid) +int __init mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid) {int i;for (i =0 ; apic_probe[i]; ++i) {
That looks like an unrelated cleanup?
Quoted 235 lines
Index: linux-2.6/arch/x86/pci/Makefile_32
===================================================================arch/x86/pci/Makefile_32 +3
-2@@ -13,10 +13,11 @@ pci-y := fixup.o pci-$(CONFIG_ACPI) += acpi.o pci-y += legacy.o irq.o -# Careful: VISWS and NUMAQ overrule the pci-y above. The colons are +# Careful: VISWS overrule the pci-y above. The colons are # therefor correct. This needs a proper fix by distangling the code. pci-$(CONFIG_X86_VISWS) := visws.o fixup.o -pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o + +pci-$(CONFIG_X86_NUMAQ) += numa.o # Necessary for NUMAQ as well pci-$(CONFIG_NUMA) += mp_bus_to_node.oIndex:
linux-2.6/arch/x86/pci/numa.c
===================================================================arch/x86/pci/numa.c +4
-25@@ -6,45 +6,21 @@#include <linux/init.h> #include <linux/nodemask.h> #include <mach_apic.h> +#include <asm/mpspec.h> #include "pci.h" #define XQUAD_PORTIO_BASE 0xfe400000#define XQUAD_PORTIO_QUAD 0x40000/* 256k per quad. */ -int mp_bus_id_to_node[MAX_MP_BUSSES ];#define BUS2QUAD (global) (mp_bus_id_to_node[global]) -int mp_bus_id_to_local[MAX_MP_BUSSES ];#define BUS2LOCAL (global) (mp_bus_id_to_local[global]) -void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - mp_bus_id_to_node[m->mpc_busid] = quad; - mp_bus_id_to_local[m->mpc_busid] = local; -printk (KERN_INFO "Bus #%d is %s (node %d)\n" , - m->mpc_busid, name, quad); -} - -int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ];#define QUADLOCAL2BUS (quad,local) (quad_local_to_mp_bus_id[quad][local]) -void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - quad_local_to_mp_bus_id[quad][local] = m->mpc_busid; -}/* Where the IO area was mapped on multiquad, always 0 otherwise */ void *xquad_portio; -#ifdef CONFIG_X86_NUMAQ EXPORT_SYMBOL (xquad_portio); -#endif #define XQUAD_PORT_ADDR (port, quad) (xquad_portio + (XQUAD_PORTIO_QUAD*quad) + port)@@ -179,6 +155,9 @@ static int __init pci_numa_init(void) {int quad; +if (!found_numaq) +return 0 ; + raw_pci_ops = &pci_direct_conf1_mq;if (pcibios_scanned++)Index:
linux-2.6/include/asm-x86/mach-generic/mach_mpparse.h
===================================================================include/asm-x86/mach-generic/mach_mpparse.h +5
-2@@ -1,7 +1,10 @@#ifndef _MACH_MPPARSE_H#define _MACH_MPPARSE_H 1 -int mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid); -int acpi_madt_oem_check (char *oem_id,char *oem_table_id); + +extern int mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid); + +extern int acpi_madt_oem_check (char *oem_id,char *oem_table_id);#endif Index:
linux-2.6/include/asm-x86/mach-numaq/mach_apic.h
===================================================================include/asm-x86/mach-numaq/mach_apic.h +8
-31@@ -20,8 +20,14 @@ static inline cpumask_t target_cpus(void#define INT_DELIVERY_MODE dest_LowestPrio#define INT_DEST_MODE 0/* physical delivery on LOCAL quad */ -#define check_apicid_used (bitmap, apicid) physid_isset(apicid, bitmap) -#define check_apicid_present (bit) physid_isset(bit, phys_cpu_present_map) +static inline unsigned long check_apicid_used (physid_mask_t bitmap,int apicid) +{ +return physid_isset (apicid, bitmap); +} +static inline unsigned long check_apicid_present (int bit) +{ +return physid_isset (bit, phys_cpu_present_map); +}#define apicid_cluster (apicid) (apicid & 0xF0)static inline int apic_id_registered (void )@@ -77,11 +83,6 @@ static inline int cpu_present_to_apicid(return BAD_APICID ; } -static inline int generate_logical_apicid (int quad,int phys_apicid) -{ -return (quad <<4 ) + (phys_apicid ? phys_apicid <<1 :1 ); -} -static inline int apicid_to_node (int logical_apicid) {return logical_apicid >>4 ;@@ -95,30 +96,6 @@ static inline physid_mask_t apicid_to_cpreturn physid_mask_of_physid (cpu +4 *node); } -struct mpc_config_translation { -unsigned char mpc_type; -unsigned char trans_len; -unsigned char trans_type; -unsigned char trans_quad; -unsigned char trans_global; -unsigned char trans_local; -unsigned short trans_reserved; -}; - -static inline int mpc_apic_id (struct mpc_config_processor *m, -struct mpc_config_translation *translation_record) -{ -int quad = translation_record->trans_quad; -int logical_apicid =generate_logical_apicid (quad, m->mpc_apicid); - -printk ("Processor #%d %u:%u APIC version %d (quad %d, apic %d)\n" , - m->mpc_apicid, - (m->mpc_cpufeature &CPU_FAMILY_MASK ) >>8 , - (m->mpc_cpufeature &CPU_MODEL_MASK ) >>4 , - m->mpc_apicver, quad, logical_apicid); -return logical_apicid; -} -extern void *xquad_portio;static inline void setup_portio_remap (void )Index:
linux-2.6/include/asm-x86/mach-numaq/mach_mpparse.h
===================================================================include/asm-x86/mach-numaq/mach_mpparse.h +2
-9@@ -1,14 +1,7 @@#ifndef __ASM_MACH_MPPARSE_H#define __ASM_MACH_MPPARSE_H -extern void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation); -extern void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation); - -/* Hook from generic ACPI tables.c */ -static inline void acpi_madt_oem_check (char *oem_id,char *oem_table_id) -{ -} +extern void numaq_mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid);#endif /* __ASM_MACH_MPPARSE_H */ Index:
linux-2.6/include/asm-x86/mmzone_32.h
===================================================================include/asm-x86/mmzone_32.h +4
-13@@ -12,11 +12,9 @@extern struct pglist_data *node_data[];#define NODE_DATA (nid) (node_data[nid]) -#ifdef CONFIG_X86_NUMAQ -#include <asm/numaq.h> -#elif defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ -#include <asm/srat.h> -#endif +#include <asm/numaq.h> +/* summit or generic arch */ +#include <asm/srat.h> extern int get_memcfg_numa_flat (void );/* @@ -26,14 +24,11 @@ extern int get_memcfg_numa_flat(void);*/ static inline void get_memcfg_numa (void ) { -#ifdef CONFIG_X86_NUMAQ +if (get_memcfg_numaq ())return ; -#elif defined(CONFIG_ACPI_SRAT )if (get_memcfg_from_srat ())return ; -#endif -get_memcfg_numa_flat (); }@@ -42,7 +37,6 @@ extern int early_pfn_to_nid(unsigned lon#else /* !CONFIG_NUMA */ #define get_memcfg_numa get_memcfg_numa_flat -#define get_zholes_size (n) (0)#endif /* CONFIG_NUMA */ @@ -83,9 +77,6 @@ static inline int pfn_to_nid(unsigned lo __pgdat->node_start_pfn + __pgdat->node_spanned_pages; \ }) -#ifdef CONFIG_X86_NUMAQ /* we have contiguous memory on NUMA-Q */ -#define pfn_valid (pfn) ((pfn) < num_physpages) -#else static inline int pfn_valid (int pfn) {int nid =pfn_to_nid (pfn);
include/asm-x86/mmzone_32.h static inline int pfn_valid(int pfn) · line 97
Quoted 4 lines
include/asm-x86/mmzone_32.h +0
-1@@ -94,7 +85,6 @@ static inline int pfn_valid(int pfn)return (pfn <node_end_pfn (nid));return 0 ; } -#endif /* CONFIG_X86_NUMAQ */
Ok, that is a small change in pfn_valid for numaq, but essentially its a little less efficient. We can probabally live with that.
Quoted 285 lines
include/asm-x86/mmzone_32.h +0
-0#endif /* CONFIG_DISCONTIGMEM */ Index:
linux-2.6/include/asm-x86/numaq.h
===================================================================include/asm-x86/numaq.h +3
-2@@ -157,9 +157,10 @@ struct sys_cfg_data {struct eachquadmem eq[MAX_NUMNODES ];/* indexed by quad id */ }; -static inline unsigned long *get_zholes_size (int nid) +#else +static inline int get_memcfg_numaq (void ) { -return NULL ; +return 0 ; }#endif /* CONFIG_X86_NUMAQ */ #endif /* NUMAQ_H */ Index:
linux-2.6/include/asm-x86/srat.h
===================================================================include/asm-x86/srat.h +7
-5@@ -27,11 +27,13 @@#ifndef _ASM_SRAT_H_#define _ASM_SRAT_H_ -#ifndef CONFIG_ACPI_SRAT -#error CONFIG_ACPI_SRAT not defined, and srat.h header has been included -#endif - +#ifdef CONFIG_ACPI_SRAT extern int get_memcfg_from_srat (void ); -extern unsigned long *get_zholes_size (int ); +#else +static inline int get_memcfg_from_srat (void ) +{ +return 0 ; +} +#endif #endif /* _ASM_SRAT_H_ */ Index:
linux-2.6/arch/x86/mach-generic/numaq.c
===================================================================arch/x86/mach-generic/numaq.c new file +41
-0@@ -0,0 +1,41 @@ +/* +* APIC driver for the IBM NUMAQ chipset. +*/ +#define APIC_DEFINITION 1 +#include <linux/threads.h> +#include <linux/cpumask.h> +#include <linux/smp.h> +#include <asm/mpspec.h> +#include <asm/genapic.h> +#include <asm/fixmap.h> +#include <asm/apicdef.h> +#include <linux/kernel.h> +#include <linux/string.h> +#include <linux/init.h> +#include <asm/mach-numaq/mach_apic.h> +#include <asm/mach-numaq/mach_apicdef.h> +#include <asm/mach-numaq/mach_ipi.h> +#include <asm/mach-numaq/mach_mpparse.h> +#include <asm/mach-numaq/mach_wakecpu.h> +#include <asm/numaq.h> + +static int mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid) +{ +numaq_mps_oem_check (mpc, oem, productid); +return found_numaq; +} + +static int probe_numaq (void ) +{ +/* already know from get_memcfg_numaq() */ +return found_numaq; +} + +/* Hook from generic ACPI tables.c */ +static int acpi_madt_oem_check (char *oem_id,char *oem_table_id) +{ +return 0 ; +} + +struct genapic apic_numaq =APIC_INIT ("NUMAQ" , probe_numaq);Index:
linux-2.6/arch/x86/mach-generic/bigsmp.c
===================================================================arch/x86/mach-generic/bigsmp.c +0
-2@@ -23,10 +23,8 @@ static int dmi_bigsmp; /* can be set bystatic int hp_ht_bigsmp (const struct dmi_system_id *d) { -#ifdef CONFIG_X86_GENERICARCH printk (KERN_NOTICE "%s detected: force use of apic=bigsmp\n" , d->ident); dmi_bigsmp =1 ; -#endif return 0 ; }Index: linux-2.6/drivers/acpi/Kconfig
===================================================================drivers/acpi/Kconfig +0
-1@@ -4,7 +4,6 @@ menuconfig ACPI bool "ACPI (Advanced Configuration and Power Interface) Support" - depends on !X86_NUMAQ depends on !X86_VISWS depends on !IA64_HP_SIM depends on IA64 || X86Index:
linux-2.6/include/asm-x86/mpspec.h
===================================================================include/asm-x86/mpspec.h +6
-0@@ -13,6 +13,12 @@ extern int apic_version[MAX_APICS];extern u8 apicid_2_node[];extern int pic_mode; +#ifdef CONFIG_X86_NUMAQ +extern int mp_bus_id_to_node[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_local[MAX_MP_BUSSES ]; +extern int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ]; +#endif +#define MAX_APICID 256#else Index:
linux-2.6/arch/x86/kernel/summit_32.c
===================================================================arch/x86/kernel/summit_32.c +2
-0@@ -36,7 +36,9 @@ static struct rio_table_hdr *rio_table_hstatic struct scal_detail *scal_devs[MAX_NUMNODES ]__initdata ;static struct rio_detail *rio_devs[MAX_NUMNODES *4 ]__initdata ; +#ifndef CONFIG_X86_NUMAQ static int mp_bus_id_to_node[MAX_MP_BUSSES ]__initdata ; +#endif static int __init setup_pci_node_map_for_wpeg (int wpeg_num,int last_bus) {Index:
linux-2.6/arch/x86/boot/compressed/misc.c
===================================================================arch/x86/boot/compressed/misc.c +0
-4@@ -217,10 +217,6 @@ static char *vidmem;static int vidport;static int lines, cols; -#ifdef CONFIG_X86_NUMAQ -void *xquad_portio; -#endif -#include "../../../../lib/inflate.c" static void *malloc (int size)Index: linux-2.6/arch/x86/Makefile
===================================================================arch/x86/Makefile +0
-18@@ -117,29 +117,11 @@ mcore-$(CONFIG_X86_VOYAGER) := arch/x86/ mflags-$(CONFIG_X86_VISWS) := -Iinclude/asm-x86/mach-visws mcore-$(CONFIG_X86_VISWS) := arch/x86/mach-visws/ -# NUMAQ subarch support -mflags-$(CONFIG_X86_NUMAQ) := -Iinclude/asm-x86/mach-numaq -mcore-$(CONFIG_X86_NUMAQ) := arch/x86/mach-default/ - -# BIGSMP subarch support -mflags-$(CONFIG_X86_BIGSMP) := -Iinclude/asm-x86/mach-bigsmp -mcore-$(CONFIG_X86_BIGSMP) := arch/x86/mach-default/ - -#Summit subarch support -mflags-$(CONFIG_X86_SUMMIT) := -Iinclude/asm-x86/mach-summit -mcore-$(CONFIG_X86_SUMMIT) := arch/x86/mach-default/ - # generic subarchitecture mflags-$(CONFIG_X86_GENERICARCH):= -Iinclude/asm-x86/mach-generic fcore-$(CONFIG_X86_GENERICARCH) += arch/x86/mach-generic/ mcore-$(CONFIG_X86_GENERICARCH) := arch/x86/mach-default/ - -# ES7000 subarch support -mflags-$(CONFIG_X86_ES7000) := -Iinclude/asm-x86/mach-es7000 -fcore-$(CONFIG_X86_ES7000) := arch/x86/mach-es7000/ -mcore-$(CONFIG_X86_ES7000) := arch/x86/mach-default/ - # RDC R-321x subarch support mflags-$(CONFIG_X86_RDC321X) := -Iinclude/asm-x86/mach-rdc321x mcore-$(CONFIG_X86_RDC321X) := arch/x86/mach-default/Index:
linux-2.6/arch/x86/kernel/acpi/boot.c
===================================================================arch/x86/kernel/acpi/boot.c +2
-2@@ -858,7 +858,7 @@ static int __init acpi_parse_madt_lapic_#ifdef CONFIG_X86_IO_APIC #define MP_ISA_BUS 0 -#if defined(CONFIG_X86_ES7000 ) || defined(CONFIG_X86_GENERICARCH ) +#ifdef CONFIG_X86_ES7000 extern int es7000_plat;#endif @@ -1007,7 +1007,7 @@ void __init mp_config_acpi_legacy_irqs(vset_bit (MP_ISA_BUS , mp_bus_not_pci);Dprintk ("Bus #%d is ISA\n" ,MP_ISA_BUS ); -#if defined(CONFIG_X86_ES7000 ) || defined(CONFIG_X86_GENERICARCH ) +#ifdef CONFIG_X86_ES7000 /* * Older generations of ES7000 have no legacy identity mappings */ Index: linux-2.6/arch/x86/mach-es7000/Makefile
===================================================================arch/x86/mach-es7000/Makefile +0
-1@@ -3,4 +3,3 @@ # obj-$(CONFIG_X86_ES7000) := es7000plat.o -obj-$(CONFIG_X86_GENERICARCH) := es7000plat.oIndex:
linux-2.6/arch/x86/mach-es7000/es7000plat.c
===================================================================arch/x86/mach-es7000/es7000plat.c +0
-48@@ -177,53 +177,6 @@ find_unisys_acpi_oem_table(unsigned long }#endif -/* -* This file also gets compiled if CONFIG_X86_GENERICARCH is set. Generic -* arch already has got following function definitions (asm-generic/es7000.c) -* hence no need to define these for that case. -*/ -#ifndef CONFIG_X86_GENERICARCH -void es7000_sw_apic (void ); -void __init enable_apic_mode (void ) -{ -es7000_sw_apic (); -return ; -} - -__init int mps_oem_check (struct mp_config_table *mpc,char *oem, -char *productid) -{ -if (mpc->mpc_oemptr) { -struct mp_config_oemtable *oem_table = - (struct mp_config_oemtable *)mpc->mpc_oemptr; -if (!strncmp (oem,"UNISYS" ,6 )) -return parse_unisys_oem ((char *)oem_table); - } -return 0 ; -} -#ifdef CONFIG_ACPI -/* Hook from generic ACPI tables.c */ -int __init acpi_madt_oem_check (char *oem_id,char *oem_table_id) -{ -unsigned long oem_addr; -if (!find_unisys_acpi_oem_table (&oem_addr)) { -if (es7000_check_dsdt ()) -return parse_unisys_oem ((char *)oem_addr); -else { -setup_unisys (); -return 1 ; - } - } -return 0 ; -} -#else -int __init acpi_madt_oem_check (char *oem_id,char *oem_table_id) -{ -return 0 ; -} -#endif -#endif /* COFIG_X86_GENERICARCH */ -static void es7000_spin (int n) { --
Quoted 4 lines
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On the face of it the idea seems sound. The NUMAQ changes look ok on a quick scan. I will need to see this applied and tested to be sure its really sane.
-apw
Re: [PATCH] x86: make generic arch support NUMAQ v5
Quoted 118 lines · Andy Whitcroft
Quoted 11 lines · Yinghai Lu
so it could fallback to normal numa.
NUMAQ depends on GENERICARCH
also decouple genericarch numa with acpi.
also make it fallback to bigsmp if apicid > 8.v3: return early if not
found_numaqinpci_numa_init
removexquad_portioinmisc.c
v4: make summit, bigsmp and es7000 depend on GENERICARCH too
v5: seperate apicid check for bigsmp to another patch
[PATCH] x86: introducemax_physical_apicidfor bigsmp switchingDo you have a NUMA-Q to test this on? Also, what is the baseline here as I would like to test it?
Quoted 55 lines
Signed-off-by Yinghai Lu <[email protected]>Index: linux-2.6/arch/x86/Kconfig
===================================================================arch/x86/Kconfig +1
-34@@ -264,36 +264,6 @@ config X86_VOYAGER If you do not specifically know you have a Voyager based machine, say N here, otherwise the kernel you build will not be bootable. -config X86_NUMAQ - bool "NUMAQ (IBM/Sequent)" - depends on SMP && X86_32 && PCI - select NUMA - help - This option is used for getting Linux to run on a (IBM/Sequent) NUMA - multiquad box. This changes the way that processors are bootstrapped, - and uses Clustered Logical APIC addressing mode instead of Flat Logical. - You will need a new lynxer.elf file to flash your firmware with - send - email to <[email protected]>. - -config X86_SUMMIT - bool "Summit/EXA (IBM x440)" - depends on X86_32 && SMP - help - This option is needed for IBM systems that use the Summit/EXA chipset. - In particular, it is needed for the x440. - - If you don't have one of these computers, you should say N here. - If you want to build a NUMA kernel, you must select ACPI. - -config X86_BIGSMP - bool "Support for other sub-arch SMP systems with more than 8 CPUs" - depends on X86_32 && SMP - help - This option is needed for the systems that have more than 8 CPUs - and if the system is not of any sub-arch type above. - - If you don't have such a system, you should say N here. - config X86_VISWS bool "SGI 320/540 (Visual Workstation)" depends on X86_32 && !PCI@@ -307,12 +277,33 @@ config X86_VISWS and vice versa. See <file:Documentation/sgi-visws.txt> for details. config X86_GENERICARCH - bool "Generic architecture (Summit, bigsmp, ES7000, default)" + bool "Generic architecture" depends on X86_32 help - This option compiles in the Summit, bigsmp, ES7000, default subarchitectures. - It is intended for a generic binary kernel. - If you want a NUMA kernel, select ACPI. We need SRAT for NUMA.arch/x86/Kconfig config X86_VISWS · line 292
Quoted 10 lines
arch/x86/Kconfig +10
-0+ This option compiles in the NUMAQ, Summit, bigsmp, ES7000, default + subarchitectures. It is intended for a generic binary kernel. + if you select them all, kernel will probe it one by one. and will + fallback to default. + +if X86_GENERICARCH + +config X86_NUMAQ + bool "NUMAQ (IBM/Sequent)" + depends on SMP && X86_32 && PCICan we not just add &&
X86_GENERICARCHhere instead of putting them in that if ?Quoted 33 lines
arch/x86/Kconfig +23
-2+ select NUMA + help + This option is used for getting Linux to run on a NUMAQ (IBM/Sequent) + NUMA multiquad box. This changes the way that processors are + bootstrapped, and uses Clustered Logical APIC addressing mode instead + of Flat Logical. You will need a new lynxer.elf file to flash your + firmware with - send email to <[email protected]>. + +config X86_SUMMIT + bool "Summit/EXA (IBM x440)" + depends on X86_32 && SMP + help + This option is needed for IBM systems that use the Summit/EXA chipset. + In particular, it is needed for the x440. config X86_ES7000 bool "Support for Unisys ES7000 IA32 series"@@ -320,8 +311,15 @@ config X86_ES7000 help Support for Unisys ES7000 systems. Say 'Y' here if this kernel is supposed to run on an IA32-based Unisys ES7000 system. - Only choose this option if you have such a system, otherwise you - should say N here. + +config X86_BIGSMP + bool "Support for big SMP systems with more than 8 CPUs" + depends on X86_32 && SMP + help + This option is needed for the systems that have more than 8 CPUs + and if the system is not of any sub-arch type above. + +endif
Quoted 15 lines
arch/x86/Kconfig config X86_PAE · line 911
Quoted 11 lines
arch/x86/Kconfig +2
-2config X86_RDC321X bool "RDC R-321x SoC"@@ -908,9 +906,9 @@ config X86_PAE config NUMA bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)" depends on SMP - depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI) && EXPERIMENTAL) + depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || X86_SUMMIT && ACPI) && EXPERIMENTAL) default n if X86_PC - default y if (X86_NUMAQ || X86_SUMMIT) + default y if (X86_NUMAQ || X86_SUMMIT || X86_GENERICARCH)If I am reading this right we are making all genericarch kernels NUMA, which before they were not. Hmmm is that going to cause problems elsewhere? Mind you can you get non-numa boxes any more?
yes, you still can select genericarch without numa
Quoted 23 lines
If its only NUMAQ which makes that requireemnt it seems wrong to add GENERICARCH here. ie. its NUMAQ or SUMMIT that brings the requirement.
Quoted 19 lines
arch/x86/Kconfig +0
-0help Enable NUMA (Non Uniform Memory Access) support. The kernel will try to allocate memory used by a CPU on theIndex:
linux-2.6/arch/x86/kernel/io_apic_32.c
===================================================================arch/x86/kernel/io_apic_32.c +0
-1@@ -1715,7 +1715,6 @@ void disable_IO_APIC(void)* by Matt Domsch <[email protected]> Tue Dec 21 12:25:05 CST 1999 */ -#ifndef CONFIG_X86_NUMAQ static void __init setup_ioapic_ids_from_mpc (void ) {union IO_APIC_reg_00 reg_00;@@ -1725,6 +1724,11 @@ static void __init setup_ioapic_ids_fromunsigned char old_id;unsigned long flags;
Quoted 8 lines
arch/x86/kernel/io_apic_32.c static void __init setup_ioapic_ids_from · line 1731
Quoted 5 lines
arch/x86/kernel/io_apic_32.c +5
-0+#ifdef CONFIG_X86_NUMAQ +if (found_numaq) +return ; +#endif +Could this not be always compiled in? As long as
found_numaqis never 1 we should be ok.
wonder if someone don't want to have extra code for numaq check compiled in?
Quoted 122 lines
Quoted 109 lines
arch/x86/kernel/io_apic_32.c +0
-3/* * Don't check I/O APIC IDs for xAPIC systems. They have * no meaning without the serial APIC bus. @@ -1821,9 +1825,6 @@ static void __init setup_ioapic_ids_fromapic_printk (APIC_VERBOSE ," ok.\n" ); } } -#else -static void __init setup_ioapic_ids_from_mpc (void ) { } -#endif int no_timer_check__initdata ;Index:
linux-2.6/arch/x86/kernel/mpparse.c
===================================================================arch/x86/kernel/mpparse.c +60
-2@@ -49,15 +49,73 @@ static int __init mpf_checksum(unsigned }#ifdef CONFIG_X86_NUMAQ +int found_numaq;/* * Have to match translation table entries to main table entries by counter * hence the mpc_record variable .... can't see a less disgusting way of * doing this .... */ +struct mpc_config_translation { +unsigned char mpc_type; +unsigned char trans_len; +unsigned char trans_type; +unsigned char trans_quad; +unsigned char trans_global; +unsigned char trans_local; +unsigned short trans_reserved; +}; +static int mpc_record;static struct mpc_config_translation *translation_table[MAX_MPC_ENTRY ]__cpuinitdata ; + +static inline int generate_logical_apicid (int quad,int phys_apicid) +{ +return (quad <<4 ) + (phys_apicid ? phys_apicid <<1 :1 ); +} + + +static inline int mpc_apic_id (struct mpc_config_processor *m, +struct mpc_config_translation *translation_record) +{ +int quad = translation_record->trans_quad; +int logical_apicid =generate_logical_apicid (quad, m->mpc_apicid); + +printk (KERN_DEBUG "Processor #%d %u:%u APIC version %d (quad %d, apic %d)\n" , + m->mpc_apicid, + (m->mpc_cpufeature &CPU_FAMILY_MASK ) >>8 , + (m->mpc_cpufeature &CPU_MODEL_MASK ) >>4 , + m->mpc_apicver, quad, logical_apicid); +return logical_apicid; +} + +int mp_bus_id_to_node[MAX_MP_BUSSES ]; + +int mp_bus_id_to_local[MAX_MP_BUSSES ]; + +static void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, +struct mpc_config_translation *translation) +{ +int quad = translation->trans_quad; +int local = translation->trans_local; + + mp_bus_id_to_node[m->mpc_busid] = quad; + mp_bus_id_to_local[m->mpc_busid] = local; +printk (KERN_INFO "Bus #%d is %s (node %d)\n" , + m->mpc_busid, name, quad); +} + +int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ]; +static void mpc_oem_pci_bus (struct mpc_config_bus *m, +struct mpc_config_translation *translation) +{ +int quad = translation->trans_quad; +int local = translation->trans_local; + + quad_local_to_mp_bus_id[quad][local] = m->mpc_busid; +} +#endif static void __cpuinit MP_processor_info (struct mpc_config_processor *m)@@ -321,11 +382,11 @@ static void __init smp_read_mpc_oem(stru } } -static inline void mps_oem_check (struct mp_config_table *mpc,char *oem, +void numaq_mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid) {if (strncmp (oem,"IBM NUMA" ,8 )) -printk ("Warning! May not be a NUMA-Q system!\n" ); +printk ("Warning! Not a NUMA-Q system!\n" );else found_numaq =1 ;@@ -388,7 +449,16 @@ static int __init smp_read_mpc(struct mpreturn 0 ;arch/x86/kernel/mpparse.c static int __init smp_read_mpc(struct mp · line 459
Quoted 10 lines
arch/x86/kernel/mpparse.c +8
-1#ifdef CONFIG_X86_32 -mps_oem_check (mpc, oem, str); +/* +* need to make sure summit and es7000's mps_oem_check is safe to be +* called early via genericarch 's mps_oem_check +*/ +if (early) { +#ifdef CONFIG_X86_NUMAQ +numaq_mps_oem_check (mpc, oem, str); +#endif Is there any reason we cannot use:
Quoted 5 lines
if (found_numaq) numaq_mps_oem_check(mpc, oem, str);Also why is this dependant on 'early'. There doesn't seem to be such a check in the original path?
because I wonder if extra early calling for mps_oem_check is safe for summit, es7000.
Quoted 104 lines
Quoted 104 lines
arch/x86/kernel/mpparse.c +2
-0+ } else +mps_oem_check (mpc, oem, str);#endif /* save the local APIC address, it might be non-default */ Index:
linux-2.6/arch/x86/kernel/numaq_32.c
===================================================================arch/x86/kernel/numaq_32.c +0
-12@@ -36,8 +36,6 @@#define MB_TO_PAGES (addr) ((addr) << (20 - PAGE_SHIFT)) -int found_numaq; -/* * Function: smp_dump_qct() * @@ -105,13 +103,3 @@ static int __init numaq_tsc_disable(void }arch_initcall (numaq_tsc_disable); -#ifdef CONFIG_ACPI -/* -* Dummy implementation: -*/ -struct pci_bus *__devinit -pci_acpi_scan_root (struct acpi_device *device,int domain,int busnum) -{ -return NULL ; -} -#endif Index: linux-2.6/arch/x86/mach-generic/Makefile
===================================================================arch/x86/mach-generic/Makefile +7
-3@@ -2,7 +2,11 @@ # Makefile for the generic architecture # -EXTRA_CFLAGS := -Iarch/x86/kernel +EXTRA_CFLAGS := -Iarch/x86/kernel -obj-y := probe.o summit.o bigsmp.o es7000.o default.o -obj-y += ../../x86/mach-es7000/ +obj-y := probe.o default.o +obj-$(CONFIG_X86_NUMAQ) += numaq.o +obj-$(CONFIG_X86_SUMMIT) += summit.o +obj-$(CONFIG_X86_BIGSMP) += bigsmp.o +obj-$(CONFIG_X86_ES7000) += es7000.o +obj-$(CONFIG_X86_ES7000) += ../../x86/mach-es7000/Index:
linux-2.6/arch/x86/mach-generic/probe.c
===================================================================arch/x86/mach-generic/probe.c +12
-0@@ -16,6 +16,7 @@#include <asm/apicdef.h> #include <asm/genapic.h> +extern struct genapic apic_numaq;extern struct genapic apic_summit;extern struct genapic apic_bigsmp;extern struct genapic apic_es7000;@@ -24,9 +25,18 @@ extern struct genapic apic_default;struct genapic *genapic = &apic_default;static struct genapic *apic_probe[]__initdata = { +#ifdef CONFIG_X86_NUMAQ + &apic_numaq, +#endif +#ifdef CONFIG_X86_SUMMIT &apic_summit, +#endif +#ifdef CONFIG_X86_BIGSMP &apic_bigsmp, +#endif +#ifdef CONFIG_X86_ES7000 &apic_es7000, +#endif &apic_default,/* must be last */ NULL , };@@ -54,6 +64,7 @@ early_param("apic", parse_apic);void __init generic_bigsmp_probe (void ) { +#if CONFIG_X86_BIGSMP /* * This routine is used to switch to bigsmp mode when * - There is no apic= option specified by the user @@ -67,6 +78,7 @@ void __init generic_bigsmp_probe(void)printk (KERN_INFO "Overriding APIC driver with %s\n" , genapic->name); } +#endif }void __init generic_apic_probe (void )@@ -88,7 +100,8 @@ void __init generic_apic_probe(void)/* These functions can switch the APIC even after the initial ->probe() */
Quoted 8 lines
arch/x86/mach-generic/probe.c void __init generic_apic_probe(void) · line 107
Quoted 6 lines
arch/x86/mach-generic/probe.c +2
-1-int __init mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid) +int __init mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid) {int i;for (i =0 ; apic_probe[i]; ++i) {That looks like an unrelated cleanup?
yeah.
Quoted 529 lines
Quoted 236 lines
Index: linux-2.6/arch/x86/pci/Makefile_32
===================================================================arch/x86/pci/Makefile_32 +3
-2@@ -13,10 +13,11 @@ pci-y := fixup.o pci-$(CONFIG_ACPI) += acpi.o pci-y += legacy.o irq.o -# Careful: VISWS and NUMAQ overrule the pci-y above. The colons are +# Careful: VISWS overrule the pci-y above. The colons are # therefor correct. This needs a proper fix by distangling the code. pci-$(CONFIG_X86_VISWS) := visws.o fixup.o -pci-$(CONFIG_X86_NUMAQ) := numa.o irq.o + +pci-$(CONFIG_X86_NUMAQ) += numa.o # Necessary for NUMAQ as well pci-$(CONFIG_NUMA) += mp_bus_to_node.oIndex:
linux-2.6/arch/x86/pci/numa.c
===================================================================arch/x86/pci/numa.c +4
-25@@ -6,45 +6,21 @@#include <linux/init.h> #include <linux/nodemask.h> #include <mach_apic.h> +#include <asm/mpspec.h> #include "pci.h" #define XQUAD_PORTIO_BASE 0xfe400000#define XQUAD_PORTIO_QUAD 0x40000/* 256k per quad. */ -int mp_bus_id_to_node[MAX_MP_BUSSES ];#define BUS2QUAD (global) (mp_bus_id_to_node[global]) -int mp_bus_id_to_local[MAX_MP_BUSSES ];#define BUS2LOCAL (global) (mp_bus_id_to_local[global]) -void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - mp_bus_id_to_node[m->mpc_busid] = quad; - mp_bus_id_to_local[m->mpc_busid] = local; -printk (KERN_INFO "Bus #%d is %s (node %d)\n" , - m->mpc_busid, name, quad); -} - -int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ];#define QUADLOCAL2BUS (quad,local) (quad_local_to_mp_bus_id[quad][local]) -void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation) -{ -int quad = translation->trans_quad; -int local = translation->trans_local; - - quad_local_to_mp_bus_id[quad][local] = m->mpc_busid; -}/* Where the IO area was mapped on multiquad, always 0 otherwise */ void *xquad_portio; -#ifdef CONFIG_X86_NUMAQ EXPORT_SYMBOL (xquad_portio); -#endif #define XQUAD_PORT_ADDR (port, quad) (xquad_portio + (XQUAD_PORTIO_QUAD*quad) + port)@@ -179,6 +155,9 @@ static int __init pci_numa_init(void) {int quad; +if (!found_numaq) +return 0 ; + raw_pci_ops = &pci_direct_conf1_mq;if (pcibios_scanned++)Index:
linux-2.6/include/asm-x86/mach-generic/mach_mpparse.h
===================================================================include/asm-x86/mach-generic/mach_mpparse.h +5
-2@@ -1,7 +1,10 @@#ifndef _MACH_MPPARSE_H#define _MACH_MPPARSE_H 1 -int mps_oem_check (struct mp_config_table *mpc,char *oem,char *productid); -int acpi_madt_oem_check (char *oem_id,char *oem_table_id); + +extern int mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid); + +extern int acpi_madt_oem_check (char *oem_id,char *oem_table_id);#endif Index:
linux-2.6/include/asm-x86/mach-numaq/mach_apic.h
===================================================================include/asm-x86/mach-numaq/mach_apic.h +8
-31@@ -20,8 +20,14 @@ static inline cpumask_t target_cpus(void#define INT_DELIVERY_MODE dest_LowestPrio#define INT_DEST_MODE 0/* physical delivery on LOCAL quad */ -#define check_apicid_used (bitmap, apicid) physid_isset(apicid, bitmap) -#define check_apicid_present (bit) physid_isset(bit, phys_cpu_present_map) +static inline unsigned long check_apicid_used (physid_mask_t bitmap,int apicid) +{ +return physid_isset (apicid, bitmap); +} +static inline unsigned long check_apicid_present (int bit) +{ +return physid_isset (bit, phys_cpu_present_map); +}#define apicid_cluster (apicid) (apicid & 0xF0)static inline int apic_id_registered (void )@@ -77,11 +83,6 @@ static inline int cpu_present_to_apicid(return BAD_APICID ; } -static inline int generate_logical_apicid (int quad,int phys_apicid) -{ -return (quad <<4 ) + (phys_apicid ? phys_apicid <<1 :1 ); -} -static inline int apicid_to_node (int logical_apicid) {return logical_apicid >>4 ;@@ -95,30 +96,6 @@ static inline physid_mask_t apicid_to_cpreturn physid_mask_of_physid (cpu +4 *node); } -struct mpc_config_translation { -unsigned char mpc_type; -unsigned char trans_len; -unsigned char trans_type; -unsigned char trans_quad; -unsigned char trans_global; -unsigned char trans_local; -unsigned short trans_reserved; -}; - -static inline int mpc_apic_id (struct mpc_config_processor *m, -struct mpc_config_translation *translation_record) -{ -int quad = translation_record->trans_quad; -int logical_apicid =generate_logical_apicid (quad, m->mpc_apicid); - -printk ("Processor #%d %u:%u APIC version %d (quad %d, apic %d)\n" , - m->mpc_apicid, - (m->mpc_cpufeature &CPU_FAMILY_MASK ) >>8 , - (m->mpc_cpufeature &CPU_MODEL_MASK ) >>4 , - m->mpc_apicver, quad, logical_apicid); -return logical_apicid; -} -extern void *xquad_portio;static inline void setup_portio_remap (void )Index:
linux-2.6/include/asm-x86/mach-numaq/mach_mpparse.h
===================================================================include/asm-x86/mach-numaq/mach_mpparse.h +2
-9@@ -1,14 +1,7 @@#ifndef __ASM_MACH_MPPARSE_H#define __ASM_MACH_MPPARSE_H -extern void mpc_oem_bus_info (struct mpc_config_bus *m,char *name, -struct mpc_config_translation *translation); -extern void mpc_oem_pci_bus (struct mpc_config_bus *m, -struct mpc_config_translation *translation); - -/* Hook from generic ACPI tables.c */ -static inline void acpi_madt_oem_check (char *oem_id,char *oem_table_id) -{ -} +extern void numaq_mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid);#endif /* __ASM_MACH_MPPARSE_H */ Index:
linux-2.6/include/asm-x86/mmzone_32.h
===================================================================include/asm-x86/mmzone_32.h +4
-13@@ -12,11 +12,9 @@extern struct pglist_data *node_data[];#define NODE_DATA (nid) (node_data[nid]) -#ifdef CONFIG_X86_NUMAQ -#include <asm/numaq.h> -#elif defined(CONFIG_ACPI_SRAT )/* summit or generic arch */ -#include <asm/srat.h> -#endif +#include <asm/numaq.h> +/* summit or generic arch */ +#include <asm/srat.h> extern int get_memcfg_numa_flat (void );/* @@ -26,14 +24,11 @@ extern int get_memcfg_numa_flat(void);*/ static inline void get_memcfg_numa (void ) { -#ifdef CONFIG_X86_NUMAQ +if (get_memcfg_numaq ())return ; -#elif defined(CONFIG_ACPI_SRAT )if (get_memcfg_from_srat ())return ; -#endif -get_memcfg_numa_flat (); }@@ -42,7 +37,6 @@ extern int early_pfn_to_nid(unsigned lon#else /* !CONFIG_NUMA */ #define get_memcfg_numa get_memcfg_numa_flat -#define get_zholes_size (n) (0)#endif /* CONFIG_NUMA */ @@ -83,9 +77,6 @@ static inline int pfn_to_nid(unsigned lo __pgdat->node_start_pfn + __pgdat->node_spanned_pages; \ }) -#ifdef CONFIG_X86_NUMAQ /* we have contiguous memory on NUMA-Q */ -#define pfn_valid (pfn) ((pfn) < num_physpages) -#else static inline int pfn_valid (int pfn) {int nid =pfn_to_nid (pfn);include/asm-x86/mmzone_32.h static inline int pfn_valid(int pfn) · line 97
Quoted 4 lines
include/asm-x86/mmzone_32.h +0
-1@@ -94,7 +85,6 @@ static inline int pfn_valid(int pfn)return (pfn <node_end_pfn (nid));return 0 ; } -#endif /* CONFIG_X86_NUMAQ */ Ok, that is a small change in
pfn_validfor numaq, but essentially its a little less efficient. We can probabally live with that.Quoted 285 lines
include/asm-x86/mmzone_32.h +0
-0#endif /* CONFIG_DISCONTIGMEM */ Index:
linux-2.6/include/asm-x86/numaq.h
===================================================================include/asm-x86/numaq.h +3
-2@@ -157,9 +157,10 @@ struct sys_cfg_data {struct eachquadmem eq[MAX_NUMNODES ];/* indexed by quad id */ }; -static inline unsigned long *get_zholes_size (int nid) +#else +static inline int get_memcfg_numaq (void ) { -return NULL ; +return 0 ; }#endif /* CONFIG_X86_NUMAQ */ #endif /* NUMAQ_H */ Index:
linux-2.6/include/asm-x86/srat.h
===================================================================include/asm-x86/srat.h +7
-5@@ -27,11 +27,13 @@#ifndef _ASM_SRAT_H_#define _ASM_SRAT_H_ -#ifndef CONFIG_ACPI_SRAT -#error CONFIG_ACPI_SRAT not defined, and srat.h header has been included -#endif - +#ifdef CONFIG_ACPI_SRAT extern int get_memcfg_from_srat (void ); -extern unsigned long *get_zholes_size (int ); +#else +static inline int get_memcfg_from_srat (void ) +{ +return 0 ; +} +#endif #endif /* _ASM_SRAT_H_ */ Index:
linux-2.6/arch/x86/mach-generic/numaq.c
===================================================================arch/x86/mach-generic/numaq.c new file +41
-0@@ -0,0 +1,41 @@ +/* +* APIC driver for the IBM NUMAQ chipset. +*/ +#define APIC_DEFINITION 1 +#include <linux/threads.h> +#include <linux/cpumask.h> +#include <linux/smp.h> +#include <asm/mpspec.h> +#include <asm/genapic.h> +#include <asm/fixmap.h> +#include <asm/apicdef.h> +#include <linux/kernel.h> +#include <linux/string.h> +#include <linux/init.h> +#include <asm/mach-numaq/mach_apic.h> +#include <asm/mach-numaq/mach_apicdef.h> +#include <asm/mach-numaq/mach_ipi.h> +#include <asm/mach-numaq/mach_mpparse.h> +#include <asm/mach-numaq/mach_wakecpu.h> +#include <asm/numaq.h> + +static int mps_oem_check (struct mp_config_table *mpc,char *oem, +char *productid) +{ +numaq_mps_oem_check (mpc, oem, productid); +return found_numaq; +} + +static int probe_numaq (void ) +{ +/* already know from get_memcfg_numaq() */ +return found_numaq; +} + +/* Hook from generic ACPI tables.c */ +static int acpi_madt_oem_check (char *oem_id,char *oem_table_id) +{ +return 0 ; +} + +struct genapic apic_numaq =APIC_INIT ("NUMAQ" , probe_numaq);Index:
linux-2.6/arch/x86/mach-generic/bigsmp.c
===================================================================arch/x86/mach-generic/bigsmp.c +0
-2@@ -23,10 +23,8 @@ static int dmi_bigsmp; /* can be set bystatic int hp_ht_bigsmp (const struct dmi_system_id *d) { -#ifdef CONFIG_X86_GENERICARCH printk (KERN_NOTICE "%s detected: force use of apic=bigsmp\n" , d->ident); dmi_bigsmp =1 ; -#endif return 0 ; }Index: linux-2.6/drivers/acpi/Kconfig
===================================================================drivers/acpi/Kconfig +0
-1@@ -4,7 +4,6 @@ menuconfig ACPI bool "ACPI (Advanced Configuration and Power Interface) Support" - depends on !X86_NUMAQ depends on !X86_VISWS depends on !IA64_HP_SIM depends on IA64 || X86Index:
linux-2.6/include/asm-x86/mpspec.h
===================================================================include/asm-x86/mpspec.h +6
-0@@ -13,6 +13,12 @@ extern int apic_version[MAX_APICS];extern u8 apicid_2_node[];extern int pic_mode; +#ifdef CONFIG_X86_NUMAQ +extern int mp_bus_id_to_node[MAX_MP_BUSSES ]; +extern int mp_bus_id_to_local[MAX_MP_BUSSES ]; +extern int quad_local_to_mp_bus_id [NR_CPUS /4 ][4 ]; +#endif +#define MAX_APICID 256#else Index:
linux-2.6/arch/x86/kernel/summit_32.c
===================================================================arch/x86/kernel/summit_32.c +2
-0@@ -36,7 +36,9 @@ static struct rio_table_hdr *rio_table_hstatic struct scal_detail *scal_devs[MAX_NUMNODES ]__initdata ;static struct rio_detail *rio_devs[MAX_NUMNODES *4 ]__initdata ; +#ifndef CONFIG_X86_NUMAQ static int mp_bus_id_to_node[MAX_MP_BUSSES ]__initdata ; +#endif static int __init setup_pci_node_map_for_wpeg (int wpeg_num,int last_bus) {Index:
linux-2.6/arch/x86/boot/compressed/misc.c
===================================================================arch/x86/boot/compressed/misc.c +0
-4@@ -217,10 +217,6 @@ static char *vidmem;static int vidport;static int lines, cols; -#ifdef CONFIG_X86_NUMAQ -void *xquad_portio; -#endif -#include "../../../../lib/inflate.c" static void *malloc (int size)Index: linux-2.6/arch/x86/Makefile
===================================================================arch/x86/Makefile +0
-18@@ -117,29 +117,11 @@ mcore-$(CONFIG_X86_VOYAGER) := arch/x86/ mflags-$(CONFIG_X86_VISWS) := -Iinclude/asm-x86/mach-visws mcore-$(CONFIG_X86_VISWS) := arch/x86/mach-visws/ -# NUMAQ subarch support -mflags-$(CONFIG_X86_NUMAQ) := -Iinclude/asm-x86/mach-numaq -mcore-$(CONFIG_X86_NUMAQ) := arch/x86/mach-default/ - -# BIGSMP subarch support -mflags-$(CONFIG_X86_BIGSMP) := -Iinclude/asm-x86/mach-bigsmp -mcore-$(CONFIG_X86_BIGSMP) := arch/x86/mach-default/ - -#Summit subarch support -mflags-$(CONFIG_X86_SUMMIT) := -Iinclude/asm-x86/mach-summit -mcore-$(CONFIG_X86_SUMMIT) := arch/x86/mach-default/ - # generic subarchitecture mflags-$(CONFIG_X86_GENERICARCH):= -Iinclude/asm-x86/mach-generic fcore-$(CONFIG_X86_GENERICARCH) += arch/x86/mach-generic/ mcore-$(CONFIG_X86_GENERICARCH) := arch/x86/mach-default/ - -# ES7000 subarch support -mflags-$(CONFIG_X86_ES7000) := -Iinclude/asm-x86/mach-es7000 -fcore-$(CONFIG_X86_ES7000) := arch/x86/mach-es7000/ -mcore-$(CONFIG_X86_ES7000) := arch/x86/mach-default/ - # RDC R-321x subarch support mflags-$(CONFIG_X86_RDC321X) := -Iinclude/asm-x86/mach-rdc321x mcore-$(CONFIG_X86_RDC321X) := arch/x86/mach-default/Index:
linux-2.6/arch/x86/kernel/acpi/boot.c
===================================================================arch/x86/kernel/acpi/boot.c +2
-2@@ -858,7 +858,7 @@ static int __init acpi_parse_madt_lapic_#ifdef CONFIG_X86_IO_APIC #define MP_ISA_BUS 0 -#if defined(CONFIG_X86_ES7000 ) || defined(CONFIG_X86_GENERICARCH ) +#ifdef CONFIG_X86_ES7000 extern int es7000_plat;#endif @@ -1007,7 +1007,7 @@ void __init mp_config_acpi_legacy_irqs(vset_bit (MP_ISA_BUS , mp_bus_not_pci);Dprintk ("Bus #%d is ISA\n" ,MP_ISA_BUS ); -#if defined(CONFIG_X86_ES7000 ) || defined(CONFIG_X86_GENERICARCH ) +#ifdef CONFIG_X86_ES7000 /* * Older generations of ES7000 have no legacy identity mappings */ Index: linux-2.6/arch/x86/mach-es7000/Makefile
===================================================================arch/x86/mach-es7000/Makefile +0
-1@@ -3,4 +3,3 @@ # obj-$(CONFIG_X86_ES7000) := es7000plat.o -obj-$(CONFIG_X86_GENERICARCH) := es7000plat.oIndex:
linux-2.6/arch/x86/mach-es7000/es7000plat.c
===================================================================arch/x86/mach-es7000/es7000plat.c +0
-48@@ -177,53 +177,6 @@ find_unisys_acpi_oem_table(unsigned long }#endif -/* -* This file also gets compiled if CONFIG_X86_GENERICARCH is set. Generic -* arch already has got following function definitions (asm-generic/es7000.c) -* hence no need to define these for that case. -*/ -#ifndef CONFIG_X86_GENERICARCH -void es7000_sw_apic (void ); -void __init enable_apic_mode (void ) -{ -es7000_sw_apic (); -return ; -} - -__init int mps_oem_check (struct mp_config_table *mpc,char *oem, -char *productid) -{ -if (mpc->mpc_oemptr) { -struct mp_config_oemtable *oem_table = - (struct mp_config_oemtable *)mpc->mpc_oemptr; -if (!strncmp (oem,"UNISYS" ,6 )) -return parse_unisys_oem ((char *)oem_table); - } -return 0 ; -} -#ifdef CONFIG_ACPI -/* Hook from generic ACPI tables.c */ -int __init acpi_madt_oem_check (char *oem_id,char *oem_table_id) -{ -unsigned long oem_addr; -if (!find_unisys_acpi_oem_table (&oem_addr)) { -if (es7000_check_dsdt ()) -return parse_unisys_oem ((char *)oem_addr); -else { -setup_unisys (); -return 1 ; - } - } -return 0 ; -} -#else -int __init acpi_madt_oem_check (char *oem_id,char *oem_table_id) -{ -return 0 ; -} -#endif -#endif /* COFIG_X86_GENERICARCH */ -static void es7000_spin (int n) { --
Quoted 8 lines
Quoted 4 lines
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/On the face of it the idea seems sound. The NUMAQ changes look ok on a quick scan. I will need to see this applied and tested to be sure its really sane.
thanks.
YH
PATCH 1/1 x86: make generic arch support NUMAQ - fix
In reply to Yinghai Lufix typo in bigsmp switching
arch/x86/mach-generic/probe.c +1 -1
@@ -64,7 +64,7 @@ early_param("apic", parse_apic);void __init generic_bigsmp_probe (void ) { -#if CONFIG_X86_BIGSMP +#ifdef CONFIG_X86_BIGSMP /* * This routine is used to switch to bigsmp mode when * - There is no apic= option specified by the user
PATCH 1/1 x86: make generic arch support NUMAQ - fix #2
In reply to Yinghai Ludo not need reserve if it early scan smp table
we are checking mptable early for numaq, so don't need to reserve_bootmem for it. bootmem is not there yet.
do the samething like 64 bit.
find it on 64g above system from 64 bit kernel kexec to 32 bit kernel with numaq support
arch/x86/kernel/mpparse.c +5 -4
@@ -853,9 +853,13 @@ static int __init smp_scan_config(unsigned long base, unsigned long length, smp_found_config =1 ;#endif mpf_found = mpf; -#ifdef CONFIG_X86_32 +printk (KERN_INFO "found SMP MP-table at [%p] %08lx\n" , mpf,virt_to_phys (mpf)); + +if (!reserve) +return 1 ; +#ifdef CONFIG_X86_32 reserve_bootmem (virt_to_phys (mpf),PAGE_SIZE ,BOOTMEM_DEFAULT );if (mpf->mpf_physptr) {
@@ -877,9 +881,6 @@ static int __init smp_scan_config(unsigned long base, unsigned long length, }#else -if (!reserve) -return 1 ; -reserve_bootmem_generic (virt_to_phys (mpf),PAGE_SIZE ,BOOTMEM_DEFAULT );if (mpf->mpf_physptr)
Ingo Molnar
AppliedRe: [PATCH] x86: introduce max_physical_apicid for bigsmp switching
In reply to Yinghai LuQuoted 6 lines · Yinghai Lu
one multi-sockets system with 3 or 4 ioapics, when 4 dualcore cpus or 2 quadcore cpus installed, need to switch to bigsmp or physflat. because cpu apic id is [4,11] instead of [0,7], and we need to check max apic id instead of cpu numbers.
also add check for 32 bit when acpi is not compiled in or acpi=off
applied to tip/x86/mpparse, thanks.
Ingo
Ingo Molnar
AppliedRe: [PATCH] x86: make generic arch support NUMAQ v5
In reply to Yinghai LuQuoted 10 lines · Yinghai Lu
so it could fallback to normal numa.
NUMAQ depends on GENERICARCH
also decouple genericarch numa with acpi.
also make it fallback to bigsmp if apicid > 8.v3: return early if not
found_numaqinpci_numa_init
removexquad_portioinmisc.c
v4: make summit, bigsmp and es7000 depend on GENERICARCH too
v5: seperate apicid check for bigsmp to another patch
[PATCH] x86: introducemax_physical_apicidfor bigsmp switching
applied to tip/x86/mpparse, thanks.
Ingo