Linux 2.6.25.5
Subsystems (3)
We (the -stable team) are announcing the release of the 2.6.25.5 kernel.
It contains a one security bug fix. If you are using CIFS or SNMP NAT you could be vulnerable and are encouraged to upgrade.
I'll also be replying to this message with a copy of the patch between 2.6.25.4 and 2.6.25.5
The updated 2.6.25.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.25.y.git
and can be browsed at the normal kernel.org git web browser:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-2.6.25.y.git;a=summarythanks,
-chris
--------
Makefile | 2 +- fs/cifs/asn1.c | 14 ++++++++++++++ net/ipv4/netfilter/nf_nat_snmp_basic.c | 14 ++++++++++++++ 3 files changed, 29 insertions(+), 1 deletion(-)
Chris Wright (2):
asn1: additional sanity checking during BER decoding (CVE-2008-1673) Linux 2.6.25.5
Makefile +1 -1
@@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 25 -EXTRAVERSION = .4 +EXTRAVERSION = .5 NAME = Funky Weasel is Jiggy wit it # *DOCUMENTATION*
fs/cifs/asn1.c +14 -0
@@ -186,6 +186,11 @@ asn1_length_decode(struct asn1_ctx *ctx, unsigned int *def, unsigned int *len) } } } + +/* don't trust len bigger than ctx buffer */ +if (*len > ctx->end - ctx->pointer) +return 0 ; +return 1 ; }
@@ -203,6 +208,10 @@ asn1_header_decode(struct asn1_ctx *ctx,if (!asn1_length_decode (ctx, &def, &len))return 0 ; +/* primitive shall be definite, indefinite shall be constructed */ +if (*con ==ASN1_PRI && !def) +return 0 ; +if (def) *eoc = ctx->pointer + len;else
@@ -389,6 +398,11 @@ asn1_oid_decode(struct asn1_ctx *ctx,unsigned long *optr; size = eoc - ctx->pointer +1 ; + +/* first subid actually encodes first two subids */ +if (size <2 || size >ULONG_MAX /sizeof (unsigned long )) +return 0 ; + *oid =kmalloc (size *sizeof (unsigned long ),GFP_ATOMIC );if (*oid ==NULL )return 0 ;
net/ipv4/netfilter/nf_nat_snmp_basic.c +14 -0
@@ -231,6 +231,11 @@ static unsigned char asn1_length_decode(struct asn1_ctx *ctx, } } } + +/* don't trust len bigger than ctx buffer */ +if (*len > ctx->end - ctx->pointer) +return 0 ; +return 1 ; }
@@ -249,6 +254,10 @@ static unsigned char asn1_header_decode(struct asn1_ctx *ctx,if (!asn1_length_decode (ctx, &def, &len))return 0 ; +/* primitive shall be definite, indefinite shall be constructed */ +if (*con ==ASN1_PRI && !def) +return 0 ; +if (def) *eoc = ctx->pointer + len;else
@@ -433,6 +442,11 @@ static unsigned char asn1_oid_decode(struct asn1_ctx *ctx,unsigned long *optr; size = eoc - ctx->pointer +1 ; + +/* first subid actually encodes first two subids */ +if (size <2 || size >ULONG_MAX /sizeof (unsigned long )) +return 0 ; + *oid =kmalloc (size *sizeof (unsigned long ),GFP_ATOMIC );if (*oid ==NULL ) {if (net_ratelimit ())