Skip to contentSkip to conversation

Missing patch from stable [1/7]

PATCH Willy Tarreau 1 participant 1 message Jun 8, 2008 Ecrypt file system

lore
Share & tools
lore
#0 lore raw

Hi,

this patch from mainline seems suitable for -stable, but was not proposed for inclusion. I think we should include it for next review unless the author disagrees.

Thanks,
Willy
--

Quoted 1 line

From 9c3580aa52195699065bc2d7242b1c7e3e6903fa Mon Sep 17 00:00:00 2001

From: Miklos Szeredi <[email protected]>
Date: Tue, 29 Apr 2008 00:59:48 -0700
Subject: ecryptfs: add missing lock around notify_change

Callers of notify_change() need to hold i_mutex.

---
 fs/ecryptfs/inode.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
fs/ecryptfs/inode.c +2 -0
index a7d5d7d..1623ebf 100644
@@ -908,7 +908,9 @@ static int ecryptfs_setattr(struct dentry *dentry, struct iattr *ia)
 	if (ia->ia_valid & (ATTR_KILL_SUID | ATTR_KILL_SGID))
 		ia->ia_valid &= ~ATTR_MODE;
 
+	mutex_lock(&lower_dentry->d_inode->i_mutex);
 	rc = notify_change(lower_dentry, ia);
+	mutex_unlock(&lower_dentry->d_inode->i_mutex);
 out:
 	fsstack_copy_attr_all(inode, lower_inode, NULL);
 	return rc;
Signature · 1 line
1.5.3.8