Skip to contentSkip to conversation

s3c2410 watchdog fixes for next kernel release

PATCH NAK Ben Dooks 2 participants 9 messages Jun 22, 2008 – Jun 23, 2008

Subsystems (2)
lore
Share & tools
lore

Ben Dooks

author
#0 lore raw

cover s3c2410 watchdog fixes for next kernel release

Updates for s3c2410 watchdog for the next kernel release.

Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
author
#1 lore raw

PATCH 1/3 WATCHDOG: Fix NULL usage in s3c2410_wdt driver.

Fix comparison of a pointer to 0, instead of using NULL for a invalid pointer.

drivers/watchdog/s3c2410_wdt.c +1 -1
Index: linux-2.6.26-rc5-quilt1/drivers/watchdog/s3c2410_wdt.c
===================================================================
@@ -377,7 +377,7 @@ static int s3c2410wdt_probe(struct platf
 	}
 
 	wdt_base = ioremap(res->start, size);
-	if (wdt_base == 0) {
+	if (wdt_base == NULL) {
 		dev_err(dev, "failed to ioremap() region\n");
 		ret = -EINVAL;
 		goto err_req;
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
#2 lore raw

Re: [patch 1/3] WATCHDOG: Fix NULL usage in s3c2410_wdt driver.

Quoted 4 lines · On Sun, 22 Jun 2008 22:36:49 +0100 Ben Dooks <[email protected]> wrote:

Fix comparison of a pointer to 0, instead of using NULL for a invalid pointer.

Looks ok but wants applying after the current big pending pile in the maintainers in queue as they've all been tidied up to coding style.

author
#3 lore raw

PATCH 2/3 WATCHDOG: Clean out header of s3c2410_wdt driver.

In reply to Ben Dooks

Remove the changelog from the top of the driver, which is redundant as this information is more accurately represented from the revision control holding the file.

drivers/watchdog/s3c2410_wdt.c +0 -12
Index: linux-2.6.26-rc5-quilt1/drivers/watchdog/s3c2410_wdt.c
===================================================================
@@ -21,18 +21,6 @@
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
- *
- * Changelog:
- *	05-Oct-2004	BJD	Added semaphore init to stop crashes on open
- *				Fixed tmr_count / wdt_count confusion
- *				Added configurable debug
- *
- *	11-Jan-2005	BJD	Fixed divide-by-2 in timeout code
- *
- *	25-Jan-2005	DA	Added suspend/resume support
- *				Replaced reboot notifier with .shutdown method
- *
- *	10-Mar-2005	LCVR	Changed S3C2410_VA to S3C24XX_VA
 */
 
 #include <linux/module.h>
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
#4 lore raw

Re: [patch 2/3] WATCHDOG: Clean out header of s3c2410_wdt driver.

Quoted 6 lines · On Sun, 22 Jun 2008 22:36:50 +0100 Ben Dooks <[email protected]> wrote:

Remove the changelog from the top of the driver, which is redundant as this information is more accurately represented from the revision control holding the file.

NAK. This is going to clash with the big pile of changes stuck in the maintainers in queue.

author
#5 lore raw

Re: [patch 2/3] WATCHDOG: Clean out header of s3c2410_wdt driver.

Quoted 8 lines · Alan Cox
Quoted 5 lines · On Sun, 22 Jun 2008 22:36:50 +0100 Ben Dooks <[email protected]> wrote:

Remove the changelog from the top of the driver, which is redundant as this information is more accurately represented from the revision control holding the file.

Quoted 4 lines
Quoted 1 line

NAK. This is going to clash with the big pile of changes stuck in the maintainers in queue.

Then why, as the original driver authour and current maintainer do I not get told about this? This isn't the first time I've come to apply this sort of thing and find that someone else has slipped in an 'trivial' change such as whitespace that breaks an entire patch series.

Do people not bother to check who wrote the driver or who is the current maintainer before doing these things?

Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
#6 lore raw

Re: [patch 2/3] WATCHDOG: Clean out header of s3c2410_wdt driver.

O> > NAK. This is going to clash with the big pile of changes stuck in the

Quoted 10 lines
Quoted 1 line

maintainers in queue.

Then why, as the original driver authour and current maintainer do I not get told about this? This isn't the first time I've come to apply this sort of thing and find that someone else has slipped in an 'trivial' change such as whitespace that breaks an entire patch series.

Do people not bother to check who wrote the driver or who is the current maintainer before doing these things?

Yes - and posted patch series to the lists. The entire watchdog tree went systematically through the cleanup process. Then I've queued a small series of patches which are a proposed rework of Wim's idea about changing the API for watchdogs entirely.

It has slipped back out of sight of most people for ages because Wim has been attending to other things so it has been queued for about 3 weeks.

Alan

author
#7 lore raw

PATCH 3/3 WATCHDOG: Fix s3c2410_wdt driver coding style issues

In reply to Ben Dooks

Fixup coding style issues in the s3c2410_wdt driver.

drivers/watchdog/s3c2410_wdt.c +4 -3
Index: linux-2.6.26-rc5-quilt1/drivers/watchdog/s3c2410_wdt.c
===================================================================
@@ -199,7 +199,7 @@ static int s3c2410wdt_set_heartbeat(int 
 
 static int s3c2410wdt_open(struct inode *inode, struct file *file)
 {
-	if(down_trylock(&open_lock))
+	if (down_trylock(&open_lock))
 		return -EBUSY;
 
 	if (nowayout)
@@ -237,7 +237,7 @@ static ssize_t s3c2410wdt_write(struct f
 	/*
 	 *	Refresh the timer.
 	 */
-	if(len) {
+	if (len) {
 		if (!nowayout) {
 			size_t i;
 
@@ -256,6 +256,7 @@ static ssize_t s3c2410wdt_write(struct f
 
 		s3c2410wdt_keepalive();
 	}
+
 	return len;
 }
 
@@ -356,7 +357,7 @@ static int s3c2410wdt_probe(struct platf
 		return -ENOENT;
 	}
 
-	size = (res->end-res->start)+1;
+	size = (res->end - res->start) + 1;
 	wdt_mem = request_mem_region(res->start, size, pdev->name);
 	if (wdt_mem == NULL) {
 		dev_err(dev, "failed to get memory region\n");
Signature · 3 lines
Ben ([email protected], http://www.fluff.org/)

  'a smiley only costs 4 bytes'
#8 lore raw

Re: [patch 3/3] WATCHDOG: Fix s3c2410_wdt driver coding style issues

Quoted 3 lines · On Sun, 22 Jun 2008 22:36:51 +0100 Ben Dooks <[email protected]> wrote:

Fixup coding style issues in the s3c2410_wdt driver.

NAK

This is already dealt with in the big pile of patches queued with the maintainer along with much more.

Alan