Skip to contentSkip to conversation

workqueues: schedule_on_each_cpu: use flush_work()

PATCH In review Oleg Nesterov 1 participant 1 message Jun 29, 2008 Workqueue

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 workqueues: schedule_on_each_cpu: use flush_work()

Change schedule_on_each_cpu() to use flush_work() instead of flush_workqueue(), this way we don't wait for other work_struct's which can be queued meanwhile.

kernel/workqueue.c renamed from kernel/workqueue.c~WQ_3_USE_FLUSH_WORK +2 -1
@@ -653,7 +653,8 @@ int schedule_on_each_cpu(work_func_t fun
 		set_bit(WORK_STRUCT_PENDING, work_data_bits(work));
 		__queue_work(per_cpu_ptr(keventd_wq->cpu_wq, cpu), work);
 	}
-	flush_workqueue(keventd_wq);
+	for_each_online_cpu(cpu)
+		flush_work(per_cpu_ptr(works, cpu));
 	put_online_cpus();
 	free_percpu(works);
 	return 0;