IB/IPoIB: Fix change mtu when switching to UD mode
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): 20080630160651.GA6024@mtls03
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): 20080701071559.GE6024@mtls03
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 7 lines · Or Gerlitz
The calls to
dev_set_mtufrom the bonding driver are from the device .set_mtu function and this means that the caller have taken the appropriate locking needed (set mtu is done on the master which in turn does it on the slaves). Recently, I worked on some change to bonding and throughout this work I learned on the need (must) to call the rtnl locking when invoking adev_set_xfunction who further doescall_netdevice_notifiers(), see
Quoted 6 lines
"the correct locking context for the notifier calls (which is RTNL and nothing else)"
comment from the bonding maintainer in
http://marc.info/?l=linux-netdev&m=121201324611292&w=2
I see, though I would expect to see a comment stating this requirement both at the documentation of call_netdevice_notifiers() and that of dev_set_mtu() and any other exported functions that requires this kind of locking.
Moreover, in this specific case, it appears that it is not required to take the rtlnl lock -- if it would be a must, I would have experienced a dump_stack() due to
ASSERT_RTNL();
in bond_alb_handle_active_change().
The fact that I did not hit such an assert does not mean I may avoid taking the rtnl lock but it appears to me that the issue is not well undrestood.
Quoted 9 lines · Eli Cohen
I see, though I would expect to see a comment stating this requirement both at the documentation of
call_netdevice_notifiers()and that ofdev_set_mtu()and any other exported functions that requires this kind of locking.
Moreover, in this specific case, it appears that it is not required to take the rtlnl lock -- if it would be a must, I would have experienced adump_stack()due to
Quoted 3 lines
ASSERT_RTNL();in
bond_alb_handle_active_change().
Or some other function registered for notifications.
Quoted 11 lines
The fact that I did not hit such an assert does not mean I may avoid taking the rtnl lock but it appears to me that the issue is not well undrestood.
_______________________________________________
general mailing list
[email protected]
http://lists.openfabrics.org/cgi-bin/mailman/listinfo/generalTo unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general