Skip to contentSkip to conversation

A minimally power-aware driver treats all messages as SUSPEND?

DISCUSSION Uwe Kleine-König 5 participants 7 messages Jul 1, 2008 – Jul 2, 2008

lore
Share & tools
lore
#0 lore raw

Hello,

include/linux/pm.h claims:

	A minimally power-aware driver treats all messages as SUSPEND
	[...].

This was introduced in commit 82bb67f2 by David Brownell. At this time PM_EVENT_HIBERNATE didn't exist. This was added in 3a2d5b70 by Rafael J. Wysocki without updating the above sentence. I think a minimally power-aware driver should treat all messages as HIBERNATE, shouldn't it?

Best regards
Uwe

Signature · 3 lines
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
#1 lore raw
Quoted 11 lines · Uwe Kleine-König

Hello,

include/linux/pm.h claims:

	A minimally power-aware driver treats all messages as SUSPEND
	[...].

This was introduced in commit 82bb67f2 by David Brownell. At this time PM_EVENT_HIBERNATE didn't exist. This was added in 3a2d5b70 by Rafael J. Wysocki without updating the above sentence. I think a minimally power-aware driver should treat all messages as HIBERNATE, shouldn't it?

No, I don't think so. In the majority of cases, SUSPEND is equivalent to the combination of FREEZE and HIBERNATE.

Still, this is going to change anyway with the introduction of the new suspend/hibernation callbacks that are scheduled for 2.6.27.

Thanks,
Rafael

#2 lore raw

Hello Rafael,

Quoted 6 lines · Rafael J. Wysocki
Quoted 5 lines · Uwe Kleine-König

include/linux/pm.h claims:

A minimally power-aware driver treats all messages as SUSPEND [...].

Quoted 7 lines
Quoted 4 lines

This was introduced in commit 82bb67f2 by David Brownell. At this time PM_EVENT_HIBERNATE didn't exist. This was added in 3a2d5b70 by Rafael J. Wysocki without updating the above sentence. I think a minimally power-aware driver should treat all messages as HIBERNATE, shouldn't it?

No, I don't think so. In the majority of cases, SUSPEND is equivalent to the combination of FREEZE and HIBERNATE.

I didn't get that. I thought SUSPEND is suspend-to-ram and HIBERNATE is suspend-to-disk, so HIBERNATE is the "deeper sleep".
With that I might have to do less on SUSPEND because some state might be preserved after the machine comes up again.

Quoted 2 lines

Still, this is going to change anyway with the introduction of the new suspend/hibernation callbacks that are scheduled for 2.6.27.

in next?

Best regards
Uwe

Signature · 3 lines
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
#3 lore raw
Quoted 16 lines · Uwe Kleine-König

Hello Rafael,

Quoted 6 lines · Rafael J. Wysocki
Quoted 5 lines · Uwe Kleine-König

include/linux/pm.h claims:

A minimally power-aware driver treats all messages as SUSPEND [...].

Quoted 7 lines
Quoted 4 lines

This was introduced in commit 82bb67f2 by David Brownell. At this time PM_EVENT_HIBERNATE didn't exist. This was added in 3a2d5b70 by Rafael J. Wysocki without updating the above sentence. I think a minimally power-aware driver should treat all messages as HIBERNATE, shouldn't it?

No, I don't think so. In the majority of cases, SUSPEND is equivalent to the combination of FREEZE and HIBERNATE.

Quoted 8 lines

I didn't get that. I thought SUSPEND is suspend-to-ram and HIBERNATE is suspend-to-disk, so HIBERNATE is the "deeper sleep".
With that I might have to do less on SUSPEND because some state might be preserved after the machine comes up again.

Quoted 2 lines

Still, this is going to change anyway with the introduction of the new suspend/hibernation callbacks that are scheduled for 2.6.27.

in next?

Yes.

Thanks,
Rafael

#6 lore raw
In reply to Uwe Kleine-König
Quoted 5 lines · Uwe Kleine-König

This was introduced in commit 82bb67f2 by David Brownell. At this time PM_EVENT_HIBERNATE didn't exist. This was added in 3a2d5b70 by Rafael J. Wysocki without updating the above sentence. I think a minimally power-aware driver should treat all messages as HIBERNATE, shouldn't it?

No.

A minimally power-aware driver should aim to work with STR.

HIBERNATE should be a secondary goal (if even that).

Linus

#4 lore raw
In reply to Uwe Kleine-König
Quoted 2 lines · Uwe Kleine-König

With that I might have to do less on SUSPEND because some state might be preserved after the machine comes up again.

The only hardware state guaranteed by ACPI is the contents of RAM. It's valid for the platform to cut the power rails to everything else, so from a driver point of view it's almost always equivalent to hibernation.

Signature · 1 line
Matthew Garrett | [email protected]
#5 lore raw
Quoted 9 lines · Matthew Garrett
Quoted 2 lines · Uwe Kleine-König

With that I might have to do less on SUSPEND because some state might be preserved after the machine comes up again.

The only hardware state guaranteed by ACPI is the contents of RAM. It's valid for the platform to cut the power rails to everything else, so from a driver point of view it's almost always equivalent to hibernation.

Right. And moreover ... the way many drivers support suspend-to-RAM in that "minimally power-aware" sense is kind of brain-dead: they resume by resetting and re-initializing everything!! Which trashes any state that the hardware may have been preserving.

So, there's no no real difference between SUSPEND and HIBERNATE modes unless drivers do more than that bare minimum.

The more intelligent drivers will leverage hardware low power states, and be able to use one of potentially many "retention" modes. Those are the drivers which may well support wakeup events; issuing wakeups requiress the device to stay at least partially functional.

- Dave