Skip to contentSkip to conversation

scheduler fixes

GIT PULL Toralf Förster 1 participant 1 message Jul 1, 2008

lore
Share & tools
lore
#0 lore raw

Hello,

I've one question related to that patch:

kernel/sched.c int sched_group_set_rt_period(struct task_group *tg, long rt_period_us) · line 8508

Quoted 12 lines · At Tue Jul 1 22:35:30 CEST 2008 Ingo Molnar wrote :
kernel/sched.c +3 -0
index a66e856..94ead43 100644
@@ -8502,6 +8502,9 @@ int sched_group_set_rt_period(struct task_group *tg, long rt_period_us)
 	rt_period = (u64)rt_period_us * NSEC_PER_USEC;
 	rt_runtime = tg->rt_bandwidth.rt_runtime;
 
+	if (rt_period == 0)
+		return -EINVAL;
+
 	return tg_set_bandwidth(tg, rt_period, rt_runtime);

Why isn't the check be make before rt_runtime is set ?

Signature · 4 lines
MfG/Sincerely

Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3