Skip to contentSkip to conversation

tvaudio: Stop I2C driver ID abuse

PATCH Markus Rechberger 1 participant 2 messages Jul 10, 2008 2 messages not in the archive Media (V4L/DVB)

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive

Hi Jean,

Quoted 10 lines · Jean Delvare

The tvaudio driver is using "official" I2C device IDs for internal purpose. There must be some historical reason behind this but anyway, it shouldn't do that. As the stored values are never used, the easiest way to fix the problem is simply to remove them altogether.

---
This patch was already sent on:
* 2008-05-07

how would you identify what chip driver is attached in the attach_inform callback, using string compare to the name? using the ID was more comfortable actually, but I understand your point for removing it too.

thanks,
Markus

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

#3 lore raw
In reply to a message not in the archive

Hi,

Quoted 16 lines · Jean Delvare

Hi Markus,

Quoted 6 lines · Markus Rechberger
Quoted 5 lines · Jean Delvare

The tvaudio driver is using "official" I2C device IDs for internal purpose. There must be some historical reason behind this but anyway, it shouldn't do that. As the stored values are never used, the easiest way to fix the problem is simply to remove them altogether.

Quoted 6 lines
Quoted 1 line

how would you identify what chip driver is attached in the attach_inform callback, using string compare to the name? using the ID was more comfortable actually, but I understand your point for removing it too.

Quoted 6 lines

attach_inform doesn't know anything about struct CHIPDESC as defined by the tvaudio driver, in which the IDs in question were stored. The driver ID which attach_inform knows and cares about is client->driver-id, which is properly set to I2C_DRIVERID_TVAUDIO by the tvaudio driver. My patch doesn't change that.

ah thanks, I mistaked that one.

Markus

Quoted 7 lines

Note that my patch is really only removing dead code. These IDs were simply never used.

Thanks,
--
Jean Delvare

--
video4linux-list mailing list
Unsubscribe mailto:[email protected]?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list