v1.3.4-rc1 released

Hello,

the first release candidate for v1.3.4 is out. Well, actually it's more some mile stone than a real release candidate as we still have a couple of issues that need to be fixed before we can consider a release:

PPC:

- MPC8272ADS:
pci.c: In function 'ft_pci_setup':
pci.c:460: error: 'bd_t' has no member named 'pci_clk'
=> will be fixed as suggested on ML

- MVBC_P:
e1000.c: In function 'e1000_read_mac_addr':
e1000.c:518: warning: integer constant is too large for 'long' type
mvbc_p.c: In function 'mvbc_init_gpio':
mvbc_p.c:112: warning: format '%08x' expects type 'unsigned int', but argument 2 has type 'long unsign ed int'
mvbc_p.c:123: warning: dereferencing type-punned pointer will break strict-aliasing rules mvbc_p.c: In function 'mvbc_p_load_fpga':
mvbc_p.c:247: warning: implicit declaration of function 'fpga_load'

- W7OLMG:
post2.c: In function 'dtt_test':
post2.c:81: error: 'DTT_READ_TEMP' undeclared (first use in this function) post2.c:81: error: (Each undeclared identifier is reported only once post2.c:81: error: for each function it appears in.) post2.c:82: error: 'DTT_TEMP_SET' undeclared (first use in this function) post2.c:83: error: 'DTT_TEMP_HYST' undeclared (first use in this function) make[1]: *** [/work/wd/tmp-ppc/board/w7o/post2.o] Error 1 make[1]: *** Waiting for unfinished jobs....
make: *** [/work/wd/tmp-ppc/board/w7o/libw7o.a] Error 2

- haleakala_nand:
make[1]: *** No rule to make target /work/wd/tmp-ppc/nand_spl/board/amcc/kilauea/.depend', needed by all'. Stop.

[Out-of-tree building fails, in-tree it works.]

- kilauea_nand:
make[1]: *** No rule to make target /work/wd/tmp-ppc/nand_spl/board/amcc/kilauea/.depend', needed by all'. Stop.

[Out-of-tree building fails, in-tree it works.]

- sacsng:
main.c: In function 'abortboot':
main.c:119: warning: too many arguments for format

Here we need some clever idea to deal with configurable command prompts. I will look into this asap.

- sc3:
main.c: In function 'abortboot':
main.c:119: warning: too many arguments for format

- actux4:
actux4.c:83: warning: left shift count >= width of type actux4.c:83: warning: left shift count >= width of type

- adsvix:
cmd_ide.c: In function '__ide_outb':
cmd_ide.c:825: warning: implicit declaration of function 'outb'
cmd_ide.c: In function '__ide_inb':
cmd_ide.c:834: warning: implicit declaration of function 'inb'
pcmcia.c:39:2: warning: #warning "Board will only supply 5V, wait for next HW spin for selectable power" common/libcommon.a(cmd_ide.o): In function `__ide_outb':
/home/wd/git/u-boot/work/common/cmd_ide.c:825: undefined reference to outb' common/libcommon.a(cmd_ide.o): In function __ide_inb':
/home/wd/git/u-boot/work/common/cmd_ide.c:834: undefined reference to `inb'

- apollon:
make: *** /work/wd/tmp-arm/onenand_ipl/board/apollon: No such file or directory. Stop.

- at91rm9200dk:
In file included from /home/wd/git/u-boot/work/include/nand.h:32,
from board.c:48:
/home/wd/git/u-boot/work/include/linux/mtd/nand.h:82:1: warning: "NAND_CTL_SETCLE" redefined
In file included from /work/wd/tmp-arm/include/config.h:2,
from /home/wd/git/u-boot/work/include/common.h:35,
from board.c:41:
/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:153:1: warning: this is the location of the previous definition In file included from /home/wd/git/u-boot/work/include/nand.h:32,
from board.c:48:
/home/wd/git/u-boot/work/include/linux/mtd/nand.h:84:1: warning: "NAND_CTL_CLRCLE" redefined
In file included from /work/wd/tmp-arm/include/config.h:2,
from /home/wd/git/u-boot/work/include/common.h:35,
from board.c:41:
/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:152:1: warning: this is the location of the previous definition In file included from /home/wd/git/u-boot/work/include/nand.h:32,
from board.c:48:
/home/wd/git/u-boot/work/include/linux/mtd/nand.h:86:1: warning: "NAND_CTL_SETALE" redefined
In file included from /work/wd/tmp-arm/include/config.h:2,
from /home/wd/git/u-boot/work/include/common.h:35,
from board.c:41:
/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:151:1: warning: this is the location of the previous definition In file included from /home/wd/git/u-boot/work/include/nand.h:32,
from board.c:48:
/home/wd/git/u-boot/work/include/linux/mtd/nand.h:88:1: warning: "NAND_CTL_CLRALE" redefined
In file included from /work/wd/tmp-arm/include/config.h:2,
from /home/wd/git/u-boot/work/include/common.h:35,
from board.c:41:
/home/wd/git/u-boot/work/include/configs/at91rm9200dk.h:150:1: warning: this is the location of the previous definition

- csb637:
In file included from /home/wd/git/u-boot/work/include/nand.h:32,
from board.c:48:
/home/wd/git/u-boot/work/include/linux/mtd/nand.h:82:1: warning: "NAND_CTL_SETCLE" redefined In file included from /work/wd/tmp-arm/include/config.h:2,
from /home/wd/git/u-boot/work/include/common.h:35,
from board.c:41:
/home/wd/git/u-boot/work/include/configs/csb637.h:156:1: warning: this is the location of the previous definition In file included from /home/wd/git/u-boot/work/include/nand.h:32,
from board.c:48:
/home/wd/git/u-boot/work/include/linux/mtd/nand.h:84:1: warning: "NAND_CTL_CLRCLE" redefined In file included from /work/wd/tmp-arm/include/config.h:2,
from /home/wd/git/u-boot/work/include/common.h:35,
from board.c:41:
/home/wd/git/u-boot/work/include/configs/csb637.h:155:1: warning: this is the location of the previous definition In file included from /home/wd/git/u-boot/work/include/nand.h:32,
from board.c:48:
/home/wd/git/u-boot/work/include/linux/mtd/nand.h:86:1: warning: "NAND_CTL_SETALE" redefined In file included from /work/wd/tmp-arm/include/config.h:2,
from /home/wd/git/u-boot/work/include/common.h:35,
from board.c:41:
/home/wd/git/u-boot/work/include/configs/csb637.h:154:1: warning: this is the location of the previous definition In file included from /home/wd/git/u-boot/work/include/nand.h:32,
from board.c:48:
/home/wd/git/u-boot/work/include/linux/mtd/nand.h:88:1: warning: "NAND_CTL_CLRALE" redefined In file included from /work/wd/tmp-arm/include/config.h:2,
from /home/wd/git/u-boot/work/include/common.h:35,
from board.c:41:
/home/wd/git/u-boot/work/include/configs/csb637.h:153:1: warning: this is the location of the previous definition

- ixp boards broken because of NPE Microcode issue

- m501sk, voiceblue:
main.c: In function 'abortboot':
main.c:215: warning: too many arguments for format

See above.

Please help testing and cleaning up the bugs.

Thanks.

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
To be is to program.

:-)

:-(

I'll look at this tonight. Maybe the code is being more clever than it should be or maybe I was simply stupider than I should have been.

Best regards,
gvb

This board seems to be using the legacy NAND interface, but doesn't define CFG_NAND_LEGACY. It also doesn't define CONFIG_CMD_NAND; if one does so, then it gets build errors (with or without CFG_NAND_LEGACY).

Likewise.

-Scott

So is there an easy way to fix these boards?

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You don't need a weatherman to know which way the wind blows.
                                                          - Bob Dylan

Enable CFG_NAND_LEGACY and CONFIG_CMD_NAND, include whatever header that the NAND macros depend on, fix any other build breaks, and test the result. I don't have the hardware to do that last step, so I'll leave it up to the board maintainer.

-Scott

OK, thanks - I think I fixed it for at91rm9200dk, and disabled NAND support for csb637.

Best regards,

Wolfgang Denk

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"The POP3 server service depends on the SMTP  server  service,  which
failed to start because of the following error: The operation comple-
ted successfully."                         -- Windows NT Server v3.51