Skip to contentSkip to conversation

updated transaction fixes patch

PATCH In review Josef Bacik 1 participant 1 message Jul 18, 2008 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 3/5 updated transaction fixes patch

Hello,

Here's an updated patch that fixes the exiting a function without stopping the transaction problems. Applies cleanly to the unstable tree. Thanks,

Josef

extent-tree.c +3 -1
diff -r f661d8fc8b9f extent-tree.c
@@ -3191,8 +3191,10 @@ next:
 	ret = btrfs_search_slot(trans, root, &key, path, -1, 1);
 	if (ret > 0)
 		ret = -EIO;
-	if (ret < 0)
+	if (ret < 0) {
+		btrfs_end_transaction(trans, root);
 		goto out;
+	}
 
 	clear_extent_bits(&info->block_group_cache, key.objectid,
 			  key.objectid + key.offset - 1,
ioctl.c +4 -2
diff -r f661d8fc8b9f ioctl.c
@@ -78,8 +78,10 @@ static noinline int create_subvol(struct
 	leaf = btrfs_alloc_free_block(trans, root, root->leafsize,
 				      objectid, trans->transid, 0, 0,
 				      0, 0);
-	if (IS_ERR(leaf))
-		return PTR_ERR(leaf);
+	if (IS_ERR(leaf)) {
+		ret = PTR_ERR(leaf);
+		goto fail;
+	}
 
 	btrfs_set_header_nritems(leaf, 0);
 	btrfs_set_header_level(leaf, 0);