Skip to contentSkip to conversation

kmemcheck: include module.h to prevent warnings

PATCH Applied Randy Dunlap 4 participants 4 messages Jul 24, 2008 – Jul 26, 2008

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kmemcheck: include module.h to prevent warnings

From: Randy Dunlap <[email protected]>

kmemcheck/shadow.c needs to include <linux/module.h> to prevent the following warnings:

linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration

---
 arch/x86/mm/kmemcheck/shadow.c |    1 +
 1 file changed, 1 insertion(+)
arch/x86/mm/kmemcheck/shadow.c +1 -0
@@ -1,5 +1,6 @@
 #include <linux/kmemcheck.h>
 #include <linux/mm.h>
+#include <linux/module.h>
 
 #include <asm/page.h>
 #include <asm/pgtable.h>

---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

kmemcheck/shadow.c needs to include <linux/module.h> to prevent the following warnings:

linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration

Looks good to me.

Quoted 19 lines
---
 arch/x86/mm/kmemcheck/shadow.c |    1 +
 1 file changed, 1 insertion(+)
arch/x86/mm/kmemcheck/shadow.c +1 -1
@@ -1,5 +1,6 @@
 #include <linux/kmemcheck.h>
 #include <linux/mm.h>
+#include <linux/module.h>
 
 #include <asm/page.h>
 #include <asm/pgtable.h>
 
 
---

~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/

Applied
#2 lore raw
In reply to Randy Dunlap
Quoted 8 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

kmemcheck/shadow.c needs to include <linux/module.h> to prevent the following warnings:

linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration

applied to tip/kmemcheck - thanks Randy.

Ingo

#3 lore raw
Quoted 5 lines · Ingo Molnar
Quoted 2 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Quoted 8 lines
Quoted 6 lines

kmemcheck/shadow.c needs to include <linux/module.h> to prevent the following warnings:

linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL' linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration

applied to tip/kmemcheck - thanks Randy.

I am obviously also grateful for this patch. Thanks!

Vegard

Signature · 4 lines
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036