Skip to contentSkip to conversation

locking: fix mutex @key parameter kernel-doc notation

PATCH In review Randy Dunlap 3 participants 3 messages Jul 25, 2008 – Jul 28, 2008 Driver core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 locking: fix mutex @key parameter kernel-doc notation

From: Randy Dunlap <[email protected]>

Fix @key parameter to mutex_init() and one of its callers.

Warning(linux-2.6.26-git11//drivers/base/class.c:210): No description found for parameter 'key'

---
 drivers/base/class.c |    1 +
 kernel/mutex.c       |    1 +
 2 files changed, 2 insertions(+)
drivers/base/class.c +1 -0
@@ -198,6 +198,7 @@ static void class_create_release(struct 
  * class_create - create a struct class structure
  * @owner: pointer to the module that is to "own" this struct class
  * @name: pointer to a string for the name of this class.
+ * @key: the lock_class_key for this class; used by mutex lock debugging
  *
  * This is used to create a struct class pointer that can then be used
  * in calls to device_create().
kernel/mutex.c +1 -0
@@ -34,6 +34,7 @@
 /***
  * mutex_init - initialize the mutex
  * @lock: the mutex to be initialized
+ * @key: the lock_class_key for the class; used by mutex lock debugging
  *
  * Initialize the mutex to unlocked state.
  *
#1 lore raw
Quoted 8 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix @key parameter to mutex_init() and one of its callers.

Warning(linux-2.6.26-git11//drivers/base/class.c:210): No description found for parameter 'key'

applied to tip/core/urgent, thanks Randy. Greg, any objections?

Ingo

Acked-by Greg Kroah-Hartman
#2 lore raw
Quoted 5 lines · Ingo Molnar
Quoted 2 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Quoted 8 lines
Quoted 6 lines

Fix @key parameter to mutex_init() and one of its callers.

Warning(linux-2.6.26-git11//drivers/base/class.c:210): No description found for parameter 'key'

applied to tip/core/urgent, thanks Randy. Greg, any objections?

No objection from me:

thanks,

greg k-h