Skip to contentSkip to conversation

Use the common declaration in NAND/OneNAND state

PATCH New Scott Wood 2 participants 6 messages Jul 25, 2008 – Jul 29, 2008 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20080725072334.GA24675@july

Scott Wood

author
#1 lore raw

PATCH 1/3 Use the common declaration in NAND/OneNAND state

Quoted 1 line · Kyungmin Park

Use the common declaration in NAND/OneNAND state

As previously requested, please base this patch against the testing branch of the u-boot-nand-flash repository.

-Scott

#2 lore raw

PATCH 1/3 Use the common declaration in NAND/OneNAND state

Hi,

Quoted 6 lines · Scott Wood
Quoted 1 line · Kyungmin Park

Use the common declaration in NAND/OneNAND state

As previously requested, please base this patch against the testing branch of the u-boot-nand-flash repository.

I re-generate patches against u-boot-nand-flash but it's same as previous ones. There are no hunks and failed.

Thank you,
Kyungmin Park

author
#3 lore raw

PATCH 1/3 Use the common declaration in NAND/OneNAND state

Quoted 4 lines · Kyungmin Park

Hi,

Quoted 1 line · Scott Wood

On Fri, Jul 25, 2008 at 04:23:34PM +0900, Kyungmin Park wrote:

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Use the common declaration in NAND/OneNAND state

As previously requested, please base this patch against the testing branch of the u-boot-nand-flash repository.

I re-generate patches against u-boot-nand-flash but it's same as previous ones. There are no hunks and failed.

Did you use the testing branch?

-Scott

#4 lore raw

PATCH 1/3 Use the common declaration in NAND/OneNAND state

Quoted 7 lines · Scott Wood
Quoted 6 lines · Kyungmin Park

Hi,

Quoted 3 lines · Scott Wood
Quoted 1 line · Kyungmin Park

Use the common declaration in NAND/OneNAND state

Quoted 9 lines
Quoted 6 lines
Quoted 3 lines

As previously requested, please base this patch against the testing branch of the u-boot-nand-flash repository.

I re-generate patches against u-boot-nand-flash but it's same as previous ones. There are no hunks and failed.

Did you use the testing branch?

Yes, I tested it.
And I got the mail from 'fathi' it can work both NAND and OneNAND.

Thank you,
Kyungmin Park

author
#5 lore raw

PATCH 1/3 Use the common declaration in NAND/OneNAND state

In reply to a message not in the archive
Quoted 4 lines · Kyungmin Park
(quoted diff) +4 -0
+/*
+ * Enumeration for NAND/OneNAND flash chip state
+ */
+enum {

Review

Quoted 10 lines
(quoted diff) +10 -0
+	FL_READY,
+	FL_READING,
+	FL_WRITING,
+	FL_ERASING,
+	FL_SYNCING,
+	FL_CACHEDPRG,
+	FL_UNLOCKING,
+	FL_LOCKING,
+	FL_RESETING,
+};

You add FL_CACHEDPRG, FL_UNLOCKING, and FL_RESETING, besides just combining the two definitions. Please describe what they're for in the changelog.

-Scott

#6 lore raw

PATCH 1/3 Use the common declaration in NAND/OneNAND state

Quoted 11 lines · Scott Wood
Quoted 10 lines · Kyungmin Park
(quoted diff) +10 -0
+/*
+ * Enumeration for NAND/OneNAND flash chip state
+ */
+enum {
+     FL_READY,
+     FL_READING,
+     FL_WRITING,
+     FL_ERASING,
+     FL_SYNCING,
+     FL_CACHEDPRG,
Quoted 9 lines

Review

Quoted 4 lines
(quoted diff) +4 -0
+     FL_UNLOCKING,
+     FL_LOCKING,
+     FL_RESETING,
+};

You add FL_CACHEDPRG, FL_UNLOCKING, and FL_RESETING, besides just combining the two definitions. Please describe what they're for in the changelog.

I just simple merged and only add FL_RESETING for next OneNAND patches. see "Use correct wait function instead of dummy loop" patch. It uses the FL_RESETING.

Thank you,
Kyungmin Park