move root inode IRELE into xfs_unmountfs
PATCH 1/6 move root inode IRELE into xfs_unmountfs
The root inode is allocated in xfs_mountfs so it should be release in xfs_unmountfs. For the unmount case that means we do it after the the xfs_sync(mp, SYNC_WAIT | SYNC_CLOSE) in the forced shutdown case and the dmapi unmount event. Note that both reference the rip variable which might be freed by that time in case inode flushing has kicked in, so strictly speaking this might count as a bug fix
Signed-off-by Christoph Hellwig <[email protected]>
fs/xfs/linux-2.6/xfs_super.c +0 -4
@@ -1182,8 +1182,6 @@ xfs_fs_put_super( error =xfs_unmount_flush (mp,0 );WARN_ON (error); -IRELE (rip); -/* * If we're forcing a shutdown, typically because of a media error, * we want to make sure we invalidate dirty pages that belong to
@@ -1683,8 +1681,6 @@ xfs_fs_fill_super( error =xfs_unmount_flush (mp,0 );WARN_ON (error); -IRELE (mp->m_rootip); -xfs_unmountfs (mp); goto out_free_fsname; }
fs/xfs/xfs_mount.c +2 -0
@@ -1250,6 +1250,8 @@ xfs_unmountfs(xfs_mount_t *mp)__uint64_t resblks;int error =0 ; +IRELE (mp->m_rootip); +/* * We can potentially deadlock here if we have an inode cluster * that has been freed has it's buffer still pinned in memory because