Skip to contentSkip to conversation

IB/ipath: use unsigned long for irqflags

PATCH In review Vegard Nossum 3 participants 3 messages Jul 29, 2008 – Jul 31, 2008 InfiniBand

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 IB/ipath: use unsigned long for irqflags

PS: Using a bit more context once the patch is applied, it's easier to spot where the flags are used.

The semantic patch I used was this:

@@
expression lock;
identifier flags;
expression subclass;
@@

- unsigned int flags;
+ unsigned long flags;

...

<+...

(
spin_lock_irqsave(lock, flags)
|
_spin_lock_irqsave(lock)
|
spin_unlock_irqrestore(lock, flags)
|
_spin_unlock_irqrestore(lock, flags)
|
read_lock_irqsave(lock, flags)
|
_read_lock_irqsave(lock)
|
read_unlock_irqrestore(lock, flags)
|
_read_unlock_irqrestore(lock, flags)
|
write_lock_irqsave(lock, flags)
|
_write_lock_irqsave(lock)
|
write_unlock_irqrestore(lock, flags)
|
_write_unlock_irqrestore(lock, flags)
|
spin_lock_irqsave_nested(lock, flags, subclass)
|
_spin_lock_irqsave_nested(lock, subclass)
|
spin_unlock_irqrestore(lock, flags)
|
_spin_unlock_irqrestore(lock, flags)
|
_raw_spin_lock_flags(lock, flags)
|
__raw_spin_lock_flags(lock, flags)
)

...+>

Quoted 1 line

From 5f2136195f7c345c7d68925029a66aa4e41ad4e8 Mon Sep 17 00:00:00 2001

From: Vegard Nossum <[email protected]>
Date: Tue, 29 Jul 2008 13:28:58 +0200
Subject: [PATCH] IB/ipath: use unsigned long for irqflags

This patch was generated using the Coccinelle framework.

Cc Ralph Campbell <[email protected]>
Cc Julia Lawall <[email protected]>
Cc Alexey Dobriyan <[email protected]>
---
 drivers/infiniband/hw/ipath/ipath_verbs.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/infiniband/hw/ipath/ipath_verbs.c +3 -3
index 55c7188..b766e40 100644
@@ -1021,7 +1021,7 @@ static void sdma_complete(void *cookie, int status)
 	struct ipath_verbs_txreq *tx = cookie;
 	struct ipath_qp *qp = tx->qp;
 	struct ipath_ibdev *dev = to_idev(qp->ibqp.device);
-	unsigned int flags;
+	unsigned long flags;
 	enum ib_wc_status ibs = status == IPATH_SDMA_TXREQ_S_OK ?
 		IB_WC_SUCCESS : IB_WC_WR_FLUSH_ERR;
 
@@ -1051,7 +1051,7 @@ static void sdma_complete(void *cookie, int status)
 
 static void decrement_dma_busy(struct ipath_qp *qp)
 {
-	unsigned int flags;
+	unsigned long flags;
 
 	if (atomic_dec_and_test(&qp->s_dma_busy)) {
 		spin_lock_irqsave(&qp->s_lock, flags);
@@ -1221,7 +1221,7 @@ static int ipath_verbs_send_pio(struct ipath_qp *qp,
 	unsigned flush_wc;
 	u32 control;
 	int ret;
-	unsigned int flags;
+	unsigned long flags;
 
 	piobuf = ipath_getpiobuf(dd, plen, NULL);
 	if (unlikely(piobuf == NULL)) {
Signature · 1 line
1.5.5.1
#2 lore raw
Quoted 1 line · Roland Dreier

Yikes... thanks, applied for 2.6.27

You got a "Yikes". Congratulations :)

julia