Skip to contentSkip to conversation

x86: Coding style fixes to arch/x86/lib/strstr_32.c

PATCH In review Paolo Ciarrocchi 2 participants 2 messages Aug 2, 2008 – Aug 4, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 3/5 x86: Coding style fixes to arch/x86/lib/strstr_32.c

Before:
total: 3 errors, 0 warnings, 31 lines checked

After:
total: 0 errors, 0 warnings, 31 lines checked

paolo@paolo-desktop:~/linux.trees.git$ md5sum /tmp/strstr_32.o.*
c96006ec3387862e5bacb139207a3098  /tmp/strstr_32.o.after
c96006ec3387862e5bacb139207a3098  /tmp/strstr_32.o.before
---
 arch/x86/lib/strstr_32.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
arch/x86/lib/strstr_32.c +3 -3
index 42e8a50..8e2d55f 100644
@@ -23,9 +23,9 @@ __asm__ __volatile__(
 	"jne 1b\n\t"
 	"xorl %%eax,%%eax\n\t"
 	"2:"
-	:"=a" (__res), "=&c" (d0), "=&S" (d1)
-	:"0" (0), "1" (0xffffffff), "2" (cs), "g" (ct)
-	:"dx", "di");
+	: "=a" (__res), "=&c" (d0), "=&S" (d1)
+	: "0" (0), "1" (0xffffffff), "2" (cs), "g" (ct)
+	: "dx", "di");
 return __res;
 }
 
Signature · 1 line
1.5.6.rc1.21.g03300
#1 lore raw
Quoted 7 lines · Paolo Ciarrocchi

Before:
total: 3 errors, 0 warnings, 31 lines checked

After:
total: 0 errors, 0 warnings, 31 lines checked

paolo@paolo-desktop:~/linux.trees.git$ md5sum /tmp/strstr_32.o.*

It seems very tempting to merge this file with arch/x86/lib/string_32.c, or is there any compelling reason to keep these two separate?

Quoted 13 lines

c96006ec3387862e5bacb139207a3098 /tmp/strstr_32.o.after c96006ec3387862e5bacb139207a3098 /tmp/strstr_32.o.before

---
 arch/x86/lib/strstr_32.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
arch/x86/lib/strstr_32.c +0 -0
index 42e8a50..8e2d55f 100644

arch/x86/lib/strstr_32.c __asm__ __volatile__( · line 29

Quoted 10 lines
arch/x86/lib/strstr_32.c +3 -3
@@ -23,9 +23,9 @@ __asm__ __volatile__(
 	"jne 1b\n\t"
 	"xorl %%eax,%%eax\n\t"
 	"2:"
-	:"=a" (__res), "=&c" (d0), "=&S" (d1)
-	:"0" (0), "1" (0xffffffff), "2" (cs), "g" (ct)
-	:"dx", "di");
+	: "=a" (__res), "=&c" (d0), "=&S" (d1)
+	: "0" (0), "1" (0xffffffff), "2" (cs), "g" (ct)
+	: "dx", "di");
 return __res;

It's strange that checkpatch.pl does not cater for such an obvious style violation as this last line.

Dmitri

Quoted 2 lines
arch/x86/lib/strstr_32.c +0 -0
 }