Skip to contentSkip to conversation

Update pom-ng docs for new iptables snapshots

PATCH Applied Phil Oester 4 participants 5 messages Aug 2, 2008 – Aug 15, 2008 netfilter

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Update pom-ng docs for new iptables snapshots

Attempting to run pom-ng's runme against an iptables snapshot which has not yet had release.sh run in it will fail. Update docs to reflect this.

This closes bugzilla #538.

Phil

README +5 -1
diff -ruN pom-orig/README pom-new/README
@@ -2,9 +2,13 @@
    This is the patch-o-matic-ng distribution by the netfilter project
    (http://www.netfilter.org/)
 
-   As of iptables-1.2.7, patch-o-matic is distributed as a seperate
+   As of iptables-1.2.7, patch-o-matic is distributed as a separate
    package, available from ftp://ftp.netfilter.org/pub/patch-o-matic-ng.
 
+   NOTE: if you are building against an unreleased (snapshot) version
+   of iptables, make sure you have run release.sh in the iptables tree.
+   Otherwise, runme will fail as it won't find the iptables Makefile.
+
#1 lore raw
Quoted 5 lines · Phil Oester

Attempting to run pom-ng's runme against an iptables snapshot which has not yet had release.sh run in it will fail. Update docs to reflect this.

This closes bugzilla #538.

I'd rather address it by stating its seemingly obsoletedness that has been discussed in previous threads.
In other words, svn rm * && svn commit, and keep the repository for history.

#2 lore raw
Quoted 6 lines · Jan Engelhardt
Quoted 4 lines · Phil Oester

Attempting to run pom-ng's runme against an iptables snapshot which has not yet had release.sh run in it will fail. Update docs to reflect this.

Quoted 6 lines
Quoted 1 line

This closes bugzilla #538.

I'd rather address it by stating its seemingly obsoletedness that has been discussed in previous threads.
In other words, svn rm * && svn commit, and keep the repository for history.

We can do that, but for now I would prefer this patch since I don't have the time for checking whether we still want anything.

The patch doesn't apply cleanly though:

patching file README
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file README.rej

Not sure what the problem is ...

#3 lore raw
Quoted 10 lines · Patrick McHardy

We can do that, but for now I would prefer this patch since I don't have the time for checking whether we still want anything.

The patch doesn't apply cleanly though:

patching file README
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file README.rej

Not sure what the problem is ...

Neither am I, as I just verified it applies cleanly against patch-o-matic-ng-20080814 snapshot. Snapshot not reflecting SVN or git reality? Attached again to be sure.

Phil

README +5 -1
diff -ruN pom-orig/README pom-new/README
@@ -2,9 +2,13 @@
    This is the patch-o-matic-ng distribution by the netfilter project
    (http://www.netfilter.org/)
 
-   As of iptables-1.2.7, patch-o-matic is distributed as a seperate
+   As of iptables-1.2.7, patch-o-matic is distributed as a separate
    package, available from ftp://ftp.netfilter.org/pub/patch-o-matic-ng.
 
+   NOTE: if you are building against an unreleased (snapshot) version
+   of iptables, make sure you have run release.sh in the iptables tree.
+   Otherwise, runme will fail as it won't find the iptables Makefile.
+
 ================================================================
 
 FOLLOW THESE STEPS:
maintainer Applied
#4 lore raw
Quoted 10 lines · Phil Oester
Quoted 9 lines · Patrick McHardy

We can do that, but for now I would prefer this patch since I don't have the time for checking whether we still want anything.

The patch doesn't apply cleanly though:

patching file README
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file README.rej

Quoted 5 lines
Quoted 1 line

Not sure what the problem is ...

Neither am I, as I just verified it applies cleanly against patch-o-matic-ng-20080814 snapshot. Snapshot not reflecting SVN or git reality? Attached again to be sure.

Applied. Thanks Phil. Please, please sign-off-by your patches (even if they are for the userspace tools, we're doing so since we switched to git).

Signature · 1 line
"Los honestos son inadaptados sociales" -- Les Luthiers