Skip to contentSkip to conversation

ide-tape: remove idetape_init_rq()

PATCH Bartlomiej Zolnierkiewicz 1 participant 1 message Aug 6, 2008 libata

lore
Share & tools
lore
#0 lore raw

idetape_init_rq() is only used in idetape_queue_pc_head() so inline it there.

---
 drivers/ide/ide-tape.c |   11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/ide/ide-tape.c +3 -8
Index: b/drivers/ide/ide-tape.c
===================================================================
@@ -689,13 +689,6 @@ static void idetape_create_request_sense
 	pc->req_xfer = 20;
 }
 
-static void idetape_init_rq(struct request *rq, u8 cmd)
-{
-	blk_rq_init(NULL, rq);
-	rq->cmd_type = REQ_TYPE_SPECIAL;
-	rq->cmd[13] = cmd;
-}
-
 /*
  * Generate a new packet command request in front of the request queue, before
  * the current request, so that it will be processed immediately, on the next
@@ -716,11 +709,13 @@ static void idetape_queue_pc_head(ide_dr
 {
 	struct ide_tape_obj *tape = drive->driver_data;
 
-	idetape_init_rq(rq, REQ_IDETAPE_PC1);
+	blk_rq_init(NULL, rq);
+	rq->cmd_type = REQ_TYPE_SPECIAL;
 	rq->cmd_flags |= REQ_PREEMPT;
 	rq->buffer = (char *) pc;
 	rq->rq_disk = tape->disk;
 	memcpy(rq->cmd, pc->c, 12);
+	rq->cmd[13] = REQ_IDETAPE_PC1;
 	ide_do_drive_cmd(drive, rq);
 }