Skip to contentSkip to conversation

kvm: qemu: Add missing DEPLIBS in Makefile.target

PATCH Applied Yang, Sheng 2 participants 3 messages Aug 13, 2008 – Aug 18, 2008 KVM

lore
Share & tools
lore

Yang, Sheng

author
#0 lore raw

PATCH 1/1 kvm: qemu: Add missing DEPLIBS in Makefile.target

From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00 2001
From: Sheng Yang <[email protected]>
Date: Wed, 13 Aug 2008 11:35:17 +0800
Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target

Seems this flags is missing during merging long ago... And this result in updating of libkvm.a didn't affect make process of qemu, which is very puzzling...

Signed-off-by Sheng Yang <[email protected]>
---
 qemu/Makefile.target |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
qemu/Makefile.target +1 -1
index f4df081..c09af57 100644
@@ -741,7 +741,7 @@ firmware.o: firmware.c
 	$(CC) $(HELPER_CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -c -o $@ $<
 endif
 
-$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a
+$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(DEPLIBS)
 	$(CC) $(LDFLAGS) -o $@ $^ $(LIBS) $(SDL_LIBS) $(COCOA_LIBS)

$(CURSES_LIBS) $(BRLAPI_LIBS) $(VDE_LIBS)

endif # !CONFIG_USER_ONLY
--
1.5.4.5

From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00 2001
From: Sheng Yang <[email protected]>
Date: Wed, 13 Aug 2008 11:35:17 +0800
Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target

Seems this flags is missing during merging long ago... And this result in updating of libkvm.a didn't affect make process of qemu, which is very puzzling...

Signed-off-by Sheng Yang <[email protected]>
---
 qemu/Makefile.target |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
qemu/Makefile.target +1 -1
index f4df081..c09af57 100644
@@ -741,7 +741,7 @@ firmware.o: firmware.c
 	$(CC) $(HELPER_CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -c -o $@ $<
 endif
 
-$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a
+$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(DEPLIBS)
 	$(CC) $(LDFLAGS) -o $@ $^ $(LIBS) $(SDL_LIBS) $(COCOA_LIBS) $(CURSES_LIBS) $(BRLAPI_LIBS) $(VDE_LIBS)
 
 endif # !CONFIG_USER_ONLY
Signature · 1 line
1.5.4.5
author
#1 lore raw
Quoted 8 lines · Sheng

From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00 2001 From: Sheng Yang <[email protected]>
Date: Wed, 13 Aug 2008 11:35:17 +0800
Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target

Seems this flags is missing during merging long ago... And this result in updating of libkvm.a didn't affect make process of qemu, which is very puzzling...

Avi, comments?
BTW: Commits 68439f0a742138188176f35bb606c4aa6b702fd3 drop this.

Signature · 2 lines
regards
Yang, Sheng
Quoted 22 lines
Signed-off-by Sheng Yang <[email protected]>
---
 qemu/Makefile.target |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
qemu/Makefile.target +1 -1
index f4df081..c09af57 100644
@@ -741,7 +741,7 @@ firmware.o: firmware.c
 	$(CC) $(HELPER_CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -c -o $@ $<
 endif
 
-$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a
+$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(DEPLIBS)
 	$(CC) $(LDFLAGS) -o $@ $^ $(LIBS) $(SDL_LIBS) $(COCOA_LIBS)
 $(CURSES_LIBS) $(BRLAPI_LIBS) $(VDE_LIBS)

endif # !CONFIG_USER_ONLY
--
1.5.4.5

Applied
#2 lore raw
In reply to Yang, Sheng
Quoted 7 lines · Sheng

From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00 2001
From: Sheng Yang <[email protected]>
Date: Wed, 13 Aug 2008 11:35:17 +0800
Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target

Seems this flags is missing during merging long ago... And this result in updating of libkvm.a didn't affect make process of qemu, which is very puzzling...

Applied, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function