Skip to contentSkip to conversation

PalmLD IDE

PATCH Marek Vasut 1 participant 1 message Aug 16, 2008 2 messages not in the archive libata

lore
Share & tools
lore
#2 lore raw
In reply to a message not in the archive

Dne Saturday 16 of August 2008 11:08:03 Russell King - ARM Linux napsal(a):

Quoted 8 lines · Marek Vasut
Quoted 2 lines

This patch adds palmld ide channel support, same as previous patch, I think this can be merged since it wont break anything.

I think this one also needs review by the Linux ATA folk. Mention to them that it's part of a patchset for ARM and that you'd prefer it to be merged into the ARM tree.

Quoted 5 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+static const char drvname[] = "pata_palmld";
+MODULE_ALIAS("platform: "drvname);

Have you tried building this as a module? Also, IIRC, there isn't supposed to be a space after the colon...

Ok, I fixed the issues and CCed linux-ide and the maintainer.

Thanks

From 8881f9cbf66a3050de328f6c020f864ca04c1e9b Mon Sep 17 00:00:00 2001
From: Marek <[email protected]>
Date: Sat, 16 Aug 2008 16:25:34 +0200
Subject: [PATCH] PalmLD: IDE support
Support for Palm LifeDrive's internal harddrive

---
 drivers/ata/Kconfig       |    9 +++
 drivers/ata/Makefile      |    1 +
 drivers/ata/pata_palmld.c |  145 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 155 insertions(+), 0 deletions(-)
 create mode 100644 drivers/ata/pata_palmld.c
drivers/ata/Kconfig +9 -0
index ae84949..8e43d11 100644
@@ -533,6 +533,15 @@ config PATA_OPTIDMA
 
 	  If unsure, say N.
 
+config PATA_PALMLD
+	tristate "Palm LifeDrive PATA support"
+	depends on MACH_PALMLD
+	help
+	  This option enables support for Palm LifeDrive's internal ATA
+	  port via the new ATA layer.
+
+	  If unsure, say N.
+
 config PATA_PCMCIA
 	tristate "PCMCIA PATA support"
 	depends on PCMCIA
drivers/ata/Makefile +1 -0
index 674965f..2b393c9 100644
@@ -50,6 +50,7 @@ obj-$(CONFIG_PATA_MPC52xx)	+= pata_mpc52xx.o
 obj-$(CONFIG_PATA_MARVELL)	+= pata_marvell.o
 obj-$(CONFIG_PATA_MPIIX)	+= pata_mpiix.o
 obj-$(CONFIG_PATA_OLDPIIX)	+= pata_oldpiix.o
+obj-$(CONFIG_PATA_PALMLD)	+= pata_palmld.o
 obj-$(CONFIG_PATA_PCMCIA)	+= pata_pcmcia.o
 obj-$(CONFIG_PATA_PDC2027X)	+= pata_pdc2027x.o
 obj-$(CONFIG_PATA_PDC_OLD)	+= pata_pdc202xx_old.o
drivers/ata/pata_palmld.c new file +145 -0

145 lines not on this page · raw message

Signature · 1 line
1.5.6