msr: Fix NULL pointer deref due to msr_open on nonexistent CPUs
Subsystems (2)
PATCH 1/1 msr: Fix NULL pointer deref due to msr_open on nonexistent CPUs
msr_open tests for someone trying to open a device for a nonexistent CPU. However, the function always returns 0, not ret like it should, hence userspace can BUG the kernel trivially. This bug was introduced by the cdev lock_kernel pushdown patch last May.
The BUG can be reproduced with these commands:
# mknod fubar c 202 8 <-- pick a number less than NR_CPUS that is not
the number of an online CPU
# cat fubar---
arch/x86/kernel/msr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/msr.c +1 -1
@@ -131,7 +131,7 @@ static int msr_open(struct inode *inode, struct file *file) ret = -EIO ;/* MSR not supported */ out:unlock_kernel (); -return 0 ; +return ret; }/*
Ingo Molnar
AppliedQuoted 10 lines · Darrick J. Wong
msr_opentests for someone trying to open a device for a nonexistent CPU. However, the function always returns 0, not ret like it should, hence userspace can BUG the kernel trivially. This bug was introduced by the cdevlock_kernelpushdown patch last May.The BUG can be reproduced with these commands:
# mknod fubar c 202 8 <-- pick a number less than NR_CPUS that is not the number of an online CPU # cat fubar
applied to tip/x86/urgent - thanks Darrick.
Ingo
arch/x86/kernel/msr.c static int msr_open(struct inode *inode, struct file *file) · line 134
Quoted 7 lines · On Thu, 14 Aug 2008 15:43:33 -0700 "Darrick J. Wong" <[email protected]> wrote:
msr_opentests for someone trying to open a device for a nonexistent CPU. However, the function always returns 0, not ret like it should, hence userspace can BUG the kernel trivially. This bug was introduced by the cdevlock_kernelpushdown patch last May.arch/x86/kernel/msr.c +1
-1-return 0 ; +return ret;
Oops, that was pretty silly. Apologies for the screwup.
jon